From: sashiko-bot@kernel.org
To: "Qianhui Xu" <xiaqinghuan@mail.ustc.edu.cn>, devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet
Date: Tue, 17 Nov 2026 05:34:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-218214@kernel.org> (raw)
In-Reply-To: <20261117052029.31900-1-xiaqinghuan@mail.ustc.edu.cn>
Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [Medium] arm64: dts: qcom: undocumented lenovo,elden board compatible
in sm8750-lenovo-elden.dts
- [Medium] arm64: dts: qcom: undocumented willsemi,wl2868c compatible
and missing driver for pmic@2f
- [Medium] arm64: dts: qcom: sm8750-lenovo-elden.dts lacks core boot
infrastructure and regulator consumers
- [Low] arm64: dts: qcom: non-alphabetical phandle node ordering in
sm8750-lenovo-elden.dts
--
commit a64b24438a9a6e099bff47eb441ee5126bd53503
Author: Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet
This commit adds a devicetree for the Qualcomm SM8750-based Lenovo Legion
Y700 Gen4 tablet with board clocks, reserved GPIOs, and a Willsemi WL2868C
camera PMIC on i2c10.
> diff --git a/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
> new file mode 100644
> index 0000000000000..73f4452f46120
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8750-lenovo-elden.dts
> @@ -0,0 +1,129 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2026, Qianhui Xu <xiaqinghuan@mail.ustc.edu.cn>
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include "sm8750.dtsi"
> +
> +/ {
> + model = "Lenovo Legion Y700 Gen4";
> + compatible = "lenovo,elden", "qcom,sm8750";
[Severity: Medium]
Is the "lenovo,elden" board compatible documented in
Documentation/devicetree/bindings/arm/qcom.yaml? The qcom,sm8750 board
entry currently lists only qcom,sm8750-mtp and qcom,sm8750-qrd, so make
dtbs_check fails schema validation on sm8750-lenovo-elden.dtb.
[ ... ]
> + /*
> + * VSYS of the camera PMIC is the always-on system rail of the tablet.
> + * The SPMI PMICs that generate it are not described yet, so it is
> + * modelled as a fixed regulator without a voltage constraint.
> + */
> + wl2868c_vsys: regulator-vsys {
> + compatible = "regulator-fixed";
> + regulator-name = "wl2868c_vsys";
> + regulator-always-on;
> + };
> +};
> +
> +&gpi_dma2 {
> + status = "okay";
> +};
> +
> +&qupv3_2 {
> + status = "okay";
> +};
> +
> +&i2c10 {
> + status = "okay";
[Severity: Low]
This isn't a bug, but phandle node overrides in Qualcomm board devicetrees
are kept in alphabetical order, so &i2c10 should come before &qupv3_2.
> +
> + pmic@2f {
> + compatible = "willsemi,wl2868c";
> + reg = <0x2f>;
> + reset-gpios = <&tlmm 126 GPIO_ACTIVE_LOW>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&camera_pmic_default>;
> + vsys-supply = <&wl2868c_vsys>;
[Severity: Medium]
Is there a devicetree binding schema or in-tree driver for
"willsemi,wl2868c"? Without a binding under
Documentation/devicetree/bindings/, make dtbs_check fails on pmic@2f, and
without a matching driver in the tree, the PMIC and its child regulators
never bind at runtime.
> +
> + regulators {
> + /* Voltages include the offsets programmed by stock firmware. */
> + camera_ldo1: ldo1 {
> + regulator-name = "camera_ldo1";
> + regulator-min-microvolt = <1128000>;
> + regulator-max-microvolt = <1128000>;
> + };
> +
> + camera_ldo2: ldo2 {
> + regulator-name = "camera_ldo2";
> + regulator-min-microvolt = <1288000>;
> + regulator-max-microvolt = <1288000>;
> + };
> +
> + camera_ldo3: ldo3 {
> + regulator-name = "camera_ldo3";
> + regulator-min-microvolt = <2816000>;
> + regulator-max-microvolt = <2816000>;
> + };
> +
> + camera_ldo4: ldo4 {
> + regulator-name = "camera_ldo4";
> + regulator-min-microvolt = <2824000>;
> + regulator-max-microvolt = <2824000>;
> + };
> +
> + camera_ldo5: ldo5 {
> + regulator-name = "camera_ldo5";
> + regulator-min-microvolt = <2808000>;
> + regulator-max-microvolt = <2808000>;
> + };
> +
> + /* LDO6 is not wired out on this board. */
> + camera_ldo7: ldo7 {
> + regulator-name = "camera_ldo7";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + };
> + };
> + };
> +};
[Severity: Medium]
Can sm8750-lenovo-elden.dts boot to a usable system without core platform
infrastructure such as the SPMI PMICs, apps_rsc RPMh regulators, console, or
storage? As added, the board devicetree omits the base platform nodes needed
to boot and instead only describes the camera PMIC, feeding its vsys-supply
from a voltage-less placeholder fixed regulator (wl2868c_vsys) while leaving
camera_ldo1 through camera_ldo7 without any consumers.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052029.31900-1-xiaqinghuan@mail.ustc.edu.cn?part=1
prev parent reply other threads:[~2026-11-17 5:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 5:20 [PATCH v7] arm64: dts: qcom: sm8750-lenovo-elden: add Lenovo Legion Y700 Gen4, a Qualcomm SM8750-based tablet Qianhui Xu
2026-11-17 5:34 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218214@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=xiaqinghuan@mail.ustc.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.