All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "William Chuang" <founder@logarcheon.com>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH 2/2] ext4: reserve an orphan credit for inline data writes
Date: Tue, 17 Nov 2026 05:36:17 +0000	[thread overview]
Message-ID: <sashiko-outbox-218215@kernel.org> (raw)
In-Reply-To: <20261117052750.2955-3-founder@logarcheon.com>

> ext4_generic_write_inline_data() starts its handle with one credit.
> ext4_prepare_inline_data() uses it when it creates or grows the inline
> data xattr and dirties the inode table block.
> 
> If the copy from user space then comes up short, write_end calls
> ext4_write_inline_data_end(), which sees pos + len > i_size and calls
> ext4_orphan_add() under the same handle.  That dirties a second block,
> the orphan file block or the superblock, and the handle has no credit
> left for it:
> 
>   WARNING: fs/jbd2/transaction.c:1598 at jbd2_journal_dirty_metadata
>   Call Trace:
>    __ext4_handle_dirty_metadata
>    ext4_orphan_file_add
>    ext4_orphan_add
> [ ... ]
> 
> Fixes: f19d5870cbf7 ("ext4: add normal write support for inline data")
> Reported-by: syzbot+e8180f5590685cbc9037@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=e8180f5590685cbc9037
> Signed-off-by: William Chuang <founder@logarcheon.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117052750.2955-1-founder@logarcheon.com?part=2


      reply	other threads:[~2026-11-17  5:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  5:27 [PATCH 0/2] ext4: fix two journal credit shortfalls behind one syzbot report William Chuang
2026-11-17  5:28 ` [PATCH 1/2] ext4: reserve quota credits in swap_inode_boot_loader() William Chuang
2026-11-17  6:00   ` sashiko-bot
2026-11-17  5:28 ` [PATCH 2/2] ext4: reserve an orphan credit for inline data writes William Chuang
2026-11-17  5:36   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218215@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=founder@logarcheon.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.