All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Dibin Moolakadan Subrahmanian"
	<dibin.moolakadan.subrahmanian@intel.com>,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [CI v2] drm/i915/dmc: Test Xe3p_LPD DMC v2.44
Date: Tue, 17 Nov 2026 05:52:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-218231@kernel.org> (raw)
In-Reply-To: <20261117054435.2400369-2-dibin.moolakadan.subrahmanian@intel.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] drm/i915/dmc: hardcoded CI-only firmware path in
  XE3P_LPD_DMC_PATH
--

commit ed909a746bf02d67d8c52eef0997ebf7ab5fd53b
Author: Dibin Moolakadan Subrahmanian <dibin.moolakadan.subrahmanian@intel.com>

drm/i915/dmc: Test Xe3p_LPD DMC v2.44

This commit replaces the default unversioned Xe3p_LPD firmware path macro
with a hardcoded path to version 2.44 for testing.

> diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
> index 6611765fd62c8..5b580044a028c 100644
> --- a/drivers/gpu/drm/i915/display/intel_dmc.c
> +++ b/drivers/gpu/drm/i915/display/intel_dmc.c
> @@ -125,7 +125,7 @@ static bool dmc_firmware_param_disabled(struct intel_display *display)
>  #define DISPLAY_VER13_DMC_MAX_FW_SIZE	0x20000
>  #define DISPLAY_VER12_DMC_MAX_FW_SIZE	ICL_DMC_MAX_FW_SIZE
>  
> -#define XE3P_LPD_DMC_PATH		DMC_PATH(xe3p_lpd)
> +#define XE3P_LPD_DMC_PATH		"i915/xe3p_lpd_dmc_ver2_44.bin"
>  MODULE_FIRMWARE(XE3P_LPD_DMC_PATH);

[Severity: High]
Does hardcoding a versioned firmware path here break default firmware
loading and initramfs packaging on Xe3p_LPD systems with standard
unversioned linux-firmware blobs?

During driver initialization on Xe3p_LPD, intel_dmc_init() acquires a
runtime power management wakeref via intel_dmc_runtime_pm_get(), selects
this path in dmc_firmware_default(), and schedules dmc_load_work_fn().
Because dmc_fallback_path() only provides a fallback for Alder Lake-P,
request_firmware() fails when the versioned file is absent and
dmc_load_work_fn() returns early without calling
intel_dmc_runtime_pm_put(), leaving the microcontroller unprogrammed and
display runtime power management permanently disabled.

A specific firmware blob can be tested without modifying the default path
by passing the dmc_firmware_path module parameter.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117054435.2400369-2-dibin.moolakadan.subrahmanian@intel.com?part=1

  reply	other threads:[~2026-11-17  5:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  9:15 [PATCH] [CI] drm/i915/dmc: Test Xe3p_LPD DMC v2.44 Dibin Moolakadan Subrahmanian
2026-11-05  9:21 ` sashiko-bot
2026-11-05  9:39 ` ✓ CI.KUnit: success for " Patchwork
2026-11-05 10:24 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-06  5:03 ` ✓ Xe.CI.FULL: " Patchwork
2026-11-17  5:44 ` [CI v2] " Dibin Moolakadan Subrahmanian
2026-11-17  5:52   ` sashiko-bot [this message]
2026-11-17  5:55 ` ✓ CI.KUnit: success for drm/i915/dmc: Test Xe3p_LPD DMC v2.44 (rev2) Patchwork
2026-11-17  6:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17  7:36 ` ✓ i915.CI.BAT: success for drm/i915/dmc: Test Xe3p_LPD DMC v2.44 Patchwork
2026-11-17 12:05 ` ✗ i915.CI.Full: failure " Patchwork
2026-11-17 19:03 ` ✗ Xe.CI.FULL: failure for drm/i915/dmc: Test Xe3p_LPD DMC v2.44 (rev2) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218231@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dibin.moolakadan.subrahmanian@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.