From: sashiko-bot@kernel.org
To: "Fenglin Wu" <fenglin.wu@oss.qualcomm.com>
Cc: linux-rtc@vger.kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH v2 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance
Date: Tue, 17 Nov 2026 07:49:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-218383@kernel.org> (raw)
In-Reply-To: <20261116-gio-framework-rtc-driver-2026-10-12-v2-2-b60e6fe33831@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] soc: qcom: pmic_glink_gio: race queuing init_work during
remove()
--
commit 48ca37803eec968c264abeb517c30d1b0bb846fc
Author: Fenglin Wu <fenglin.wu@oss.qualcomm.com>
soc: qcom: pmic_glink: Add GIO pmic_glink instance
This commit adds a PMIC GLINK auxiliary driver for the General I/O (GIO)
register space and alert interface exposed by the SoCCP firmware, and
enables the GIO auxiliary device on Glymur.
> diff --git a/drivers/soc/qcom/pmic_glink_gio.c b/drivers/soc/qcom/pmic_glink_gio.c
> new file mode 100644
> index 0000000000000..9a28f88152b25
> --- /dev/null
> +++ b/drivers/soc/qcom/pmic_glink_gio.c
[ ... ]
> +static void pmic_glink_gio_pdr_notify(void *priv, int state)
> +{
> + struct pmic_glink_gio *pgio = priv;
> + bool service_up;
> +
> + service_up = state == SERVREG_SERVICE_STATE_UP;
> +
> + scoped_guard(spinlock_irqsave, &pgio->lock) {
> + if (pgio->removing)
> + return;
> +
> + WRITE_ONCE(pgio->service_up, service_up);
> + if (!service_up && pgio->pending) {
> + pgio->ack_error = -ENETRESET;
> + pmic_glink_gio_complete_transaction(pgio);
> + }
> +
> + if (!service_up)
> + pmic_gio_set_state(pgio->gio, PMIC_GIO_STATE_DOWN);
> + }
> +
> + if (service_up)
> + queue_work(pgio->wq, &pgio->init_work);
> +}
[ ... ]
> +static int pmic_glink_gio_probe(struct auxiliary_device *adev,
> + const struct auxiliary_device_id *id)
> +{
> + struct pmic_glink_gio *pgio;
> + struct device *dev = &adev->dev;
> + int ret;
> +
> + pgio = devm_kzalloc(dev, sizeof(*pgio), GFP_KERNEL);
> + if (!pgio)
> + return -ENOMEM;
> +
> + pgio->dev = dev;
> + spin_lock_init(&pgio->lock);
> + init_completion(&pgio->ack);
> + INIT_WORK(&pgio->init_work, pmic_glink_gio_init_work);
> + dev_set_drvdata(dev, pgio);
> +
> + pgio->client = devm_pmic_glink_client_alloc(dev, PMIC_GLINK_OWNER_GIO,
> + pmic_glink_gio_callback,
> + pmic_glink_gio_pdr_notify,
> + pgio);
> + if (IS_ERR(pgio->client))
> + return PTR_ERR(pgio->client);
> +
> + pgio->gio = devm_pmic_gio_register(dev, &pmic_glink_gio_ops, pgio);
> + if (IS_ERR(pgio->gio))
> + return dev_err_probe(dev, PTR_ERR(pgio->gio), "failed to register GIO device\n");
> +
> + pgio->wq = alloc_ordered_workqueue("pmic_glink_gio", 0);
> + if (!pgio->wq)
> + return -ENOMEM;
> +
> + ret = devm_add_action_or_reset(dev, pmic_glink_gio_destroy_wq, pgio->wq);
> + if (ret)
> + return ret;
> +
> + pmic_glink_client_register(pgio->client);
> +
> + return 0;
> +}
> +
> +static void pmic_glink_gio_remove(struct auxiliary_device *adev)
> +{
> + struct pmic_glink_gio *pgio = dev_get_drvdata(&adev->dev);
> +
> + scoped_guard(spinlock_irqsave, &pgio->lock) {
> + pgio->removing = true;
> + WRITE_ONCE(pgio->service_up, false);
> + if (pgio->pending) {
> + pgio->ack_error = -ENODEV;
> + pmic_glink_gio_complete_transaction(pgio);
> + }
> + pmic_gio_set_state(pgio->gio, PMIC_GIO_STATE_DOWN);
> + }
> +
> + cancel_work_sync(&pgio->init_work);
> + flush_workqueue(pgio->wq);
> +}
[Severity: Medium]
Can pmic_glink_gio_pdr_notify() queue pgio->init_work onto pgio->wq while
or after the workqueue is destroyed during teardown?
pmic_glink_gio_pdr_notify() checks pgio->removing under pgio->lock, but
releases pgio->lock before calling queue_work(pgio->wq, &pgio->init_work).
In addition, pmic_glink_gio_probe() registers devm_pmic_glink_client_alloc()
before devm_add_action_or_reset(dev, pmic_glink_gio_destroy_wq, pgio->wq),
so devres destroys pgio->wq before _devm_pmic_glink_release_client()
unlinks pgio->client under pg->client_lock:
CPU0 CPU1
pmic_glink_state_notify_clients()
lock(&pg->client_lock)
pmic_glink_gio_pdr_notify()
lock(&pgio->lock)
/* pgio->removing is false */
unlock(&pgio->lock)
pmic_glink_gio_remove()
lock(&pgio->lock)
pgio->removing = true
unlock(&pgio->lock)
cancel_work_sync(&pgio->init_work)
flush_workqueue(pgio->wq)
devres_release_all()
pmic_glink_gio_destroy_wq()
destroy_workqueue(pgio->wq)
queue_work(pgio->wq, ...)
<-- WARN_ONCE / use-after-free on pgio->wq
Keeping queue_work(pgio->wq, &pgio->init_work) inside the pgio->lock
critical section in pmic_glink_gio_pdr_notify() (as GIO_OPCODE_ALERT_IND
does in pmic_glink_gio_callback()) avoids queuing work after pgio->removing
is set.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-gio-framework-rtc-driver-2026-10-12-v2-0-b60e6fe33831@oss.qualcomm.com?part=2
next prev parent reply other threads:[~2026-11-17 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 7:33 [PATCH v2 0/3] soc: qcom: Add Qualcomm PMIC GIO framework and RTC driver using it Fenglin Wu
2026-11-17 7:33 ` [PATCH v2 1/3] soc: qcom: Add pmic-gio GIO framework driver Fenglin Wu
2026-11-17 7:54 ` sashiko-bot
2026-11-17 7:33 ` [PATCH v2 2/3] soc: qcom: pmic_glink: Add GIO pmic_glink instance Fenglin Wu
2026-11-17 7:49 ` sashiko-bot [this message]
2026-11-17 7:33 ` [PATCH v2 3/3] rtc: Add Qualcomm GIO RTC driver Fenglin Wu
2026-11-17 7:45 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218383@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=fenglin.wu@oss.qualcomm.com \
--cc=linux-rtc@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.