From: sashiko-bot@kernel.org
To: zhaoguohan@kylinos.cn
Cc: virtualization@lists.linux.dev,
"Michael S. Tsirkin" <mst@redhat.com>,
"Eugenio Perez" <eperezma@redhat.com>
Subject: Re: [PATCH v2 1/2] vhost: set dirty log bits without pinning pages on x86
Date: Tue, 17 Nov 2026 08:44:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-218427@kernel.org> (raw)
In-Reply-To: <20261117083323.89502-2-zhaoguohan@kylinos.cn>
> From: "Michael S. Tsirkin" <mst@redhat.com>
>
> vhost had a TODO to replace page pinning with a version
> of set_bit that works on userspace memory, since forever.
>
> It is really best to avoid GUP on fast path entirely.
> Implement set_bit_user and use it in vhost, to do just that.
>
> Should not be too hard for non-x86 too.
>
> Reported-by: Khan Zhao <zhaoguohan@kylinos.cn>
> Link: https://lore.kernel.org/all/20261112085631.128819-1-zhaoguohan@kylinos.cn/
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> [Khan: declare efault with __label__ so it is local to the macro]
> Signed-off-by: Khan Zhao <zhaoguohan@kylinos.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117083323.89502-1-zhaoguohan@kylinos.cn?part=1
next prev parent reply other threads:[~2026-11-17 8:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:33 [PATCH v2 0/2] vhost: set dirty log bits without pinning pages on x86 zhaoguohan
2026-11-17 8:33 ` [PATCH v2 1/2] " zhaoguohan
2026-11-17 8:44 ` sashiko-bot [this message]
2026-11-17 8:33 ` [PATCH v2 2/2] tools/virtio: add a vhost dirty log test zhaoguohan
2026-11-17 8:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218427@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=eperezma@redhat.com \
--cc=mst@redhat.com \
--cc=sashiko-reviews@lists.linux.dev \
--cc=virtualization@lists.linux.dev \
--cc=zhaoguohan@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.