From: sashiko-bot@kernel.org
To: "Siqi Chen" <chensiqi@uniontech.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: as3668: Propagate chip ID read errors
Date: Tue, 17 Nov 2026 08:46:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-218433@kernel.org> (raw)
In-Reply-To: <20261117083917.3304865-1-chensiqi@uniontech.com>
> i2c_smbus_read_byte_data() returns a negative error code on failure.
> Storing the result in a u8 truncates that error and causes probe to
> report a bogus chip ID and return -ENODEV.
>
> Store the result in an int and propagate read failures before checking
> the chip ID.
>
> An AI coding assistant was used to identify the issue and help develop
> the fix.
>
> The change was compile-tested with W=1. No hardware testing was
> performed.
>
> Fixes: c7dd343a3756 ("leds: as3668: Driver for the ams Osram 4-channel i2c LED driver")
> Cc: stable@vger.kernel.org
> Signed-off-by: Siqi Chen <chensiqi@uniontech.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117083917.3304865-1-chensiqi@uniontech.com?part=1
next prev parent reply other threads:[~2026-11-17 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 8:39 [PATCH] leds: as3668: Propagate chip ID read errors Siqi Chen
2026-11-17 8:46 ` sashiko-bot [this message]
2026-11-17 12:59 ` Griffin Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218433@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=chensiqi@uniontech.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.