All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Xuanqiang Luo" <xuanqiang.luo@linux.dev>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v1] net/mlx5e: TX, Do not open a multi-packet WQE for a single packet
Date: Tue, 17 Nov 2026 08:58:10 +0000	[thread overview]
Message-ID: <sashiko-outbox-218443@kernel.org> (raw)
In-Reply-To: <20261117085036.3138779-1-xuanqiang.luo@linux.dev>

> From: Xuanqiang Luo <luoxuanqiang@kylinos.cn>
> 
> A multi-packet WQE (MPWQE, added by commit 5af75c747e2a ("net/mlx5e:
> Enhanced TX MPWQE for SKBs")) lets several packets share one WQE, so the
> control and Ethernet segments are fetched by the device once per batch
> instead of once per packet. This saves PCIe bandwidth and CPU cycles, but
> only if the WQE carries more than one packet.
> 
> With skb_tx_mpwqe enabled, which is the default, mlx5e_xmit() sends every
> skb accepted by mlx5e_tx_skb_supports_mpwqe() through an MPWQE session.
> A session stays open between two calls only while the stack sets
> xmit_more. A packet without xmit_more closes the session and rings the
> doorbell. Hence a packet that comes without xmit_more while no session is
> open opens a session just for itself and closes it right away. Such a WQE
> takes one WQEBB, as a regular WQE does for the same packet, and the
> [ ... ]
> than a single packet MPWQE does (mlx5e_sq_calc_wqe_attr(),
> mlx5e_accel_tx_finish()); the packet rate above shows that it is more
> than compensated.
> 
> Signed-off-by: Xuanqiang Luo <luoxuanqiang@kylinos.cn>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117085036.3138779-1-xuanqiang.luo@linux.dev?part=1


      reply	other threads:[~2026-11-17  8:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:50 [PATCH net-next v1] net/mlx5e: TX, Do not open a multi-packet WQE for a single packet Xuanqiang Luo
2026-11-17  8:58 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218443@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=xuanqiang.luo@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.