All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Frédéric Mahé" <frederic.mahe@cirad.fr>
Cc: linux-pci@vger.kernel.org
Subject: Re: [PATCH] PCI: spacemit-k1: Request the Gen2 speed change once the link is up
Date: Tue, 17 Nov 2026 09:03:53 +0000	[thread overview]
Message-ID: <sashiko-outbox-218445@kernel.org> (raw)
In-Reply-To: <20261117085508.83388-1-frederic.mahe@cirad.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] PCI: spacemit-k1: missing Fixes trailer for Gen2 speed change
  fix
--

commit 842cad793224659cfdb7e69af083d16f7d380bad
Author: Frédéric Mahé <frederic.mahe@cirad.fr>

> PCI: spacemit-k1: Request the Gen2 speed change once the link is up
>
> On a Banana Pi BPI-F3, an NVMe SSD in the M.2 slot (pcie1) always comes
> up at 2.5 GT/s, although the root port and the drive both support
> 5 GT/s. The Directed Speed Change that dw_pcie_setup_rc() requests
> before the LTSSM is enabled has no effect on K1. Setting Retrain Link
> in the root port's Link Control from userspace brings the link to
> 5 GT/s, so the link itself is fine.
>
> Once the link is up, request the speed change again, wait for the
> controller to clear SPEED_CHANGE (as pci-imx6 does), then briefly for
> Link Status to report the new speed. A port with nothing behind it is
> skipped after 100 ms.
>
> With an SK hynix BC511, the link now trains at 5 GT/s x2 and fio
> sequential read goes from 397 to 575-640 MB/s. Data verified with fio
> crc32c. The empty pcie2 port behaves as before.
>
> This change was developed with the help of Claude (Anthropic); I
> reviewed and tested it on hardware.
>
> Signed-off-by: Frédéric Mahé <frederic.mahe@cirad.fr>

[Severity: Low]
This fixes Gen2 link training in the initial SpacemiT K1 PCIe driver.
Should the commit message include a Fixes tag?

  Fixes: ff64e078e45f ("PCI: spacemit: Add SpacemiT PCIe host driver")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117085508.83388-1-frederic.mahe@cirad.fr?part=1

  reply	other threads:[~2026-11-17  9:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:55 [PATCH] PCI: spacemit-k1: Request the Gen2 speed change once the link is up Frédéric Mahé
2026-11-17  8:55 ` Frédéric Mahé
2026-11-17  9:03 ` sashiko-bot [this message]
2026-11-17 21:42 ` Aurelien Jarno
2026-11-17 21:42   ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218445@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=frederic.mahe@cirad.fr \
    --cc=linux-pci@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.