From: sashiko-bot@kernel.org
To: "Haoli Zhang" <26031212468@stu.xidian.edu.cn>
Cc: linux-ext4@vger.kernel.org, tytso@mit.edu
Subject: Re: [PATCH] ext4: validate in-inode xattrs before listing
Date: Tue, 17 Nov 2026 09:23:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-218477@kernel.org> (raw)
In-Reply-To: <20261117090147.3950327-1-26031212468@stu.xidian.edu.cn>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] ext4: missing Fixes trailer for commit 5701875f9609 in commit
message
--
commit 26f87c9d23ca6ed689130ab579bf0e8089b835d5
Author: Haoli Zhang <26031212468@stu.xidian.edu.cn>
> ext4: validate in-inode xattrs before listing
>
> ext4_iget() validates in-inode xattrs when it reads an inode. However,
> ext4_xattr_ibody_list() fetches the inode-table data again with
> ext4_get_inode_loc() and passes the entries to ext4_xattr_list_entries()
> without validating this read. If the re-read data contains a malformed
> xattr entry, the listing loop can advance beyond the valid in-inode xattr
> area and read invalid memory.
>
> Validate the in-inode xattrs from this read with xattr_check_inode()
> before listing them. If validation fails, skip the listing and return the
> error after releasing the inode-table buffer.
>
> Reported-by: syzbot+3fbf2337de43f5581aec@syzkaller.appspotmail.com
> Closes: https://syzbot.org/bug?extid=3fbf2337de43f5581aec
> Co-developed-by: Jinning Zhang <25031212117@stu.xidian.edu.cn>
> Signed-off-by: Jinning Zhang <25031212117@stu.xidian.edu.cn>
> Co-developed-by: Bin Yu <byu@xidian.edu.cn>
> Signed-off-by: Bin Yu <byu@xidian.edu.cn>
> Signed-off-by: Haoli Zhang <26031212468@stu.xidian.edu.cn>
[Severity: Low]
5701875f9609 ("ext4: fix out-of-bound read in
ext4_xattr_inode_dec_ref_all()") moved xattr_check_inode() into
ext4_iget_extra_inode() and removed it from ext4_xattr_ibody_list().
Should this include:
Fixes: 5701875f9609 ("ext4: fix out-of-bound read in ext4_xattr_inode_dec_ref_all()")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117090147.3950327-1-26031212468@stu.xidian.edu.cn?part=1
prev parent reply other threads:[~2026-11-17 9:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 9:01 [PATCH] ext4: validate in-inode xattrs before listing Haoli Zhang
2026-11-17 9:23 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218477@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=26031212468@stu.xidian.edu.cn \
--cc=linux-ext4@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.