All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yang Siyuan" <hsyysy@163.com>
Cc: linux-sunxi@lists.linux.dev, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: allwinner: rg35xx: keep RTL8821CS powered during suspend
Date: Tue, 17 Nov 2026 09:27:47 +0000	[thread overview]
Message-ID: <sashiko-outbox-218483@kernel.org> (raw)
In-Reply-To: <20261117092024.12163-1-hsyysy@163.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] arm64: dts: allwinner: missing Fixes trailer on RG35XX-Plus
  suspend fix
--

commit 6bc1ccf6bdee4d4322a5c25361fc4b5c6087cce2
Author: Yang Siyuan <hsyysy@163.com>

> arm64: dts: allwinner: rg35xx: keep RTL8821CS powered during suspend
>
> The RTL8821CS SDIO WiFi on the RG35XX Plus/SP is soldered and powered by
> CLDO4.  rtw88's SDIO suspend callback asks the MMC host to keep power
> during system suspend:
>
>     rtw88_8821cs mmc1:0001:1: Failed to host PM flag MMC_PM_KEEP_POWER
>
> sdio_set_host_pm_flags() only accepts MMC_PM_KEEP_POWER when the host's
> pm_caps contains it, and mmc_of_parse() sets that flag from the
> "keep-power-in-suspend" DT property.  Without it, the first s2idle
> suspend aborts with -EINVAL before the system can enter suspend.
>
> Add keep-power-in-suspend to &mmc1 so the WiFi stays powered and s2idle
> works.  Tested on an Anbernic RG35XX-SP: the board suspends and resumes
> from the lid switch, and the WiFi reconnects after resume.
>
> Signed-off-by: Yang Siyuan <hsyysy@163.com>

[Severity: Low]
Since this fixes broken s2idle suspend on the RG35XX Plus/H/SP boards
where &mmc1 was introduced without keep-power-in-suspend, should this
include:

  Fixes: 398e5fdf60ed ("arm64: dts: allwinner: h700: Add RG35XX-Plus DTS")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117092024.12163-1-hsyysy@163.com?part=1

  reply	other threads:[~2026-11-17  9:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:20 [PATCH] arm64: dts: allwinner: rg35xx: keep RTL8821CS powered during suspend Yang Siyuan
2026-11-17  9:27 ` sashiko-bot [this message]
2026-11-17  9:45 ` [PATCH v2] " Yang Siyuan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218483@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hsyysy@163.com \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.