From: sashiko-bot@kernel.org
To: "Yang Siyuan" <hsyysy@163.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH RESEND] usb: phy: generic: request the vbus supply only when it is described
Date: Tue, 17 Nov 2026 09:30:08 +0000 [thread overview]
Message-ID: <sashiko-outbox-218486@kernel.org> (raw)
In-Reply-To: <20261117091956.12103-1-hsyysy@163.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] usb: phy: generic: missing Fixes trailer for commit 03e607cbb293
--
commit 56f1331b1fa011c1da842446fa9ad5d7fb41931f
Author: Yang Siyuan <hsyysy@163.com>
> usb: phy: generic: request the vbus supply only when it is described
>
> usb_phy_gen_create_phy() unconditionally asks for an exclusive "vbus"
> regulator. The legacy usb_phy_generic platform device registered by USB
> glue drivers (e.g. sunxi MUSB) has no firmware node, so the lookup ends
> up in the dummy-regulator path and the regulator core warns:
>
> usb_phy_generic usb_phy_generic.1.auto: dummy supplies not allowed for
> exclusive requests (id=vbus)
>
> Only issue the request when the device firmware actually describes a
> vbus-supply, and keep treating -ENODEV as "not present".
>
> Signed-off-by: Yang Siyuan <hsyysy@163.com>
[Severity: Low]
Since this fixes the unconditional devm_regulator_get_exclusive() call,
should the commit message include a Fixes tag?
Fixes: 03e607cbb293 ("usb: phy: generic: Get the vbus supply")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117091956.12103-1-hsyysy@163.com?part=1
next prev parent reply other threads:[~2026-11-17 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 9:19 [PATCH RESEND] usb: phy: generic: request the vbus supply only when it is described Yang Siyuan
2026-11-17 9:30 ` sashiko-bot [this message]
2026-11-17 9:45 ` [PATCH v2] " Yang Siyuan
2026-11-17 9:55 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218486@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=hsyysy@163.com \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.