All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Caleb James DeLisle" <cjd@cjdns.fr>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v12 3/5] clocksource/timer-econet-en751221: Disable IRQ until cevt registered
Date: Tue, 17 Nov 2026 10:01:35 +0000	[thread overview]
Message-ID: <sashiko-outbox-218560@kernel.org> (raw)
In-Reply-To: <20261117095117.173316-4-cjd@cjdns.fr>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] clocksource/timer-econet-en751221: missing Fixes trailer for IRQ
  race fix
--

commit 93affbec7851d413710a9c422ba505847184084a
Author: Caleb James DeLisle <cjd@cjdns.fr>

> clocksource/timer-econet-en751221: Disable IRQ until cevt registered
>
> Eliminate a race condition where cevt_interrupt may trigger before
> clockevents_config_and_register has been called, and dev->event_handler
> is at that point NULL. Additionally, NULL check dev->event_handler in
> interrupt callback just in case clockevents_config_and_register failed.
>
> Signed-off-by: Caleb James DeLisle <cjd@cjdns.fr>

[Severity: Low]
This fixes a race condition and potential NULL pointer dereference in
cevt_interrupt() and cevt_init_cpu(). Should it include a Fixes: tag for
the commit that introduced the driver?

  Fixes: 3b4c33ac87d0 ("clocksource/drivers: Add EcoNet Timer HPT driver")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117095117.173316-1-cjd@cjdns.fr?part=3

  reply	other threads:[~2026-11-17 10:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  9:51 [PATCH v12 0/5] clocksource/timer-econet-en751221: Support irq number per timer Caleb James DeLisle
2026-11-17  9:51 ` [PATCH v12 1/5] dt-bindings: timer: econet: Update EN751627 for multi-IRQ Caleb James DeLisle
2026-11-17 10:01   ` sashiko-bot
2026-11-17  9:51 ` [PATCH v12 2/5] clocksource/timer-econet-en751221: Init teardown on error if possible Caleb James DeLisle
2026-11-17  9:51 ` [PATCH v12 3/5] clocksource/timer-econet-en751221: Disable IRQ until cevt registered Caleb James DeLisle
2026-11-17 10:01   ` sashiko-bot [this message]
2026-11-17  9:51 ` [PATCH v12 4/5] clocksource/timer-econet-en751221: Support EN751627 without percpu IRQ Caleb James DeLisle
2026-11-17  9:51 ` [PATCH v12 5/5] clocksource/timer-econet-en751221: Do not use NR_CPUS for resource array size Caleb James DeLisle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218560@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=cjd@cjdns.fr \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.