From: sashiko-bot@kernel.org
To: "Emfox Zhou" <emfox@debian.org>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v6 2/2] HID: intel-thc-hid: quickspi, quicki2c: skip an empty read
Date: Tue, 17 Nov 2026 10:36:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-218628@kernel.org> (raw)
In-Reply-To: <20261117102726.271503-3-emfox@debian.org>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] HID: intel-thc-hid: missing Fixes trailers for empty RxDMA read
fix
--
commit 43159f2f56e537320c5a32041e1e942435685267
Author: Emfox Zhou <emfox@debian.org>
> HID: intel-thc-hid: quickspi, quicki2c: skip an empty read
>
> A drain ends when the ring holds no frame, and thc_rxdma_read() reports
> that as a successful read of zero bytes. Both handlers go by the buffer
> instead of the length: quickspi hands the zero on and its own length check
> then rejects the frame still left in the buffer, while quicki2c reads
> pkt->len from the previous frame and sends that report again.
>
> Tell the two cases apart by the length. A frame with an empty payload is
> still a frame, and quicki2c needs that one for its reset ack.
>
> Signed-off-by: Emfox Zhou <emfox@debian.org>
[Severity: Low]
This fixes a bug where handle_input_report() and
quickspi_irq_thread_handler() process stale buffer contents when
thc_rxdma_read() returns zero bytes on an empty ring. Should this include:
Fixes: 4138f21115ae ("HID: intel-thc-hid: intel-quickspi: Complete THC QuickSPI driver")
Fixes: 66b59bfce6d9 ("HID: intel-thc-hid: intel-quicki2c: Complete THC QuickI2C driver")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117102726.271503-1-emfox@debian.org?part=2
prev parent reply other threads:[~2026-11-17 10:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 10:27 [PATCH v6 0/2] HID: intel-thc-hid: PRD tables under a drain Emfox Zhou
2026-11-17 10:27 ` [PATCH v6 1/2] HID: intel-thc-hid: intel-thc: restore PRD table capacity Emfox Zhou
2026-11-17 10:27 ` [PATCH v6 2/2] HID: intel-thc-hid: quickspi, quicki2c: skip an empty read Emfox Zhou
2026-11-17 10:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218628@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=emfox@debian.org \
--cc=linux-input@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.