From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next V2 05/10] net/mlx5: LAG, decouple iteration end-of-walk from MLX5_MAX_PORTS
Date: Tue, 17 Nov 2026 10:36:43 +0000 [thread overview]
Message-ID: <sashiko-outbox-218633@kernel.org> (raw)
In-Reply-To: <20261116103010.1129666-6-tariqt@nvidia.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net/mlx5: LAG, max_funcs sentinel mismatch in changeupper and
alloc
--
commit 78f2f8069167c6a38a6b670a3fc665eb9f73b7c1
Author: Shay Drory <shayd@nvidia.com>
net/mlx5: LAG, decouple iteration end-of-walk from MLX5_MAX_PORTS
This commit replaces MLX5_MAX_PORTS with a dynamic ldev->max_funcs ceiling
as the end-of-walk sentinel for LAG xarray iterators and removes the
MLX5_MAX_PORTS upper bound on xa_alloc().
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> index 669b2167a82d2..cbef6ab1e38a8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/lag/lag.c
> @@ -395,6 +395,7 @@ static struct mlx5_lag *mlx5_lag_dev_alloc(struct mlx5_core_dev *dev)
> mlx5_core_err(dev, "Failed to init multipath lag err=%d\n",
> err);
>
> + ldev->max_funcs = ldev->ports;
> return ldev;
>
> err_wq:
[ ... ]
> @@ -2094,7 +2095,7 @@ static int mlx5_handle_changeupper_event(struct mlx5_lag *ldev,
> break;
> }
> }
> - if (i < MLX5_MAX_PORTS) {
> + if (i < ldev->ports) {
> if (netif_is_bond_master(upper)) {
> slave = bond_slave_get_rcu(ndev_tmp);
> if (slave)
[Severity: Medium]
Should mlx5_handle_changeupper_event() check i < ldev->max_funcs instead of
i < ldev->ports, and should ldev->max_funcs be initialized before
registering the notifiers in mlx5_lag_dev_alloc()?
mlx5_ldev_for_each() terminates with i == ldev->max_funcs when no matching
netdev is found. In mlx5_lag_dev_alloc(), register_netdevice_notifier_net()
and mlx5_lag_mp_init() run while ldev->max_funcs is still 0 and ldev->ports
is at least 2:
CPU0 CPU1
mlx5_lag_dev_alloc()
ldev->ports = ...;
register_netdevice_notifier_net()
mlx5_lag_netdev_event()
mlx5_handle_changeupper_event()
mlx5_ldev_for_each(i, 0, ldev)
/* ends with i = 0, idx = -1 */
if (i < ldev->ports)
bond_status |= (1 << idx);
<-- shift by -1
mlx5_lag_mp_init()
ldev->max_funcs = ldev->ports;
Conversely, once xa_alloc() assigns a port an xarray index >= ldev->ports
and grows ldev->max_funcs, a matching slave increments idx and breaks out of
mlx5_ldev_for_each() with i >= ldev->ports, so if (i < ldev->ports) skips
updating bond_status and has_inactive for that slave.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116103010.1129666-1-tariqt@nvidia.com?part=5
next prev parent reply other threads:[~2026-11-17 10:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 10:30 [PATCH net-next V2 00/10] net/mlx5: LAG, preparations for LAG over VFs/SFs Tariq Toukan
2026-11-16 10:30 ` [PATCH net-next V2 01/10] net/mlx5: Distinguish VFs/SFs in the SW system image GUID for LAG grouping Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 02/10] net/mlx5: LAG, select the MPESW master from the live member snapshot Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 03/10] net/mlx5: LAG, skip phys LAG prerequisites for a virt LAG Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 04/10] net/mlx5: LAG, treat virt LAG as a software managed LAG Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 05/10] net/mlx5: LAG, decouple iteration end-of-walk from MLX5_MAX_PORTS Tariq Toukan
2026-11-17 10:36 ` sashiko-bot [this message]
2026-11-16 10:30 ` [PATCH net-next V2 06/10] net/mlx5: LAG, rename PF naming to fn Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 07/10] net/mlx5: LAG, resolve affinity indices only in queue-affinity mode Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 08/10] net/mlx5: LAG: replace fixed MLX5_MAX_PORTS arrays with dynamic allocation Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 09/10] net/mlx5: LAG, drop MLX5_MAX_PORTS scratch array from device rescan Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
2026-11-16 10:30 ` [PATCH net-next V2 10/10] net/mlx5: LAG, do not add a device to an already-active virt LAG Tariq Toukan
2026-11-17 10:36 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218633@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.