From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794917964; b=dQNOCWOTTmUgGwCkDzlk33pcMq41wA+jAlAaTB4t554ojQRiP7GveU0phZ7DPOAeBtZ9 JJT6gzunZHeCnJycr32Hfx+9NztPFwCaOwXaY/0PItAcDsQ7XCNdsTsJn+yFelPQbxSoz Mj6OfEtoEGvoiOjD/fNWetefKCZMpJ8E5tlOtqLqMt7Q9VbKRIAEeW6bim3CjDqi85Iyo MsKJY8pt1nIb7cL5HZjigauhSB5pSg8fEOx0O7gYIFlbiIFvlMShk64mEzOjs3RW0a98g Nvct4kDaPU6D7gG5ZnOZA1NlIEVC+tQFxyE6Cove/wS5T1Do09joU7L/MUmNWWysEvA== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794917964; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=n4usXxho+0YSlUHhlo9YvGu77QGGm3+v9Q+5ElnUTrg=; b=UgUNx8ZECl5iiBxGA699vo6CuLAbaPzcMzB/xuzlT+ryANa6J7GUXkMoJLFE44lLYDbs nNmESaKE7+Izl3BdD8unZHYcL02ank5emUiAhIrY8Ce/ig1c3ACGaCbgppoZVxvloZpit c/QLHFfGGPYZvDm1n3DuD1XkBpQz4nAQnhbiKIPHr664qp1tXKjl2RXL62XoLCJBC5k8s rrptG6vvy17/YyeyRqubUAXOYpGazNtlJtygbH/HiKB3o1wNBwnFWMCfAtFW7X51kRJfn Bpfo8i4FVt/Vu1aIk9zhpd9mTzHN+yj4iBZW8eb341PsBgsT7HwBRATC16Oc5CguEhA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IDZA63TX; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3A6B9606A88D for ; Tue, 17 Nov 2026 12:19:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IDZA63TX Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94D851F000C7; Tue, 17 Nov 2026 12:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794917963; bh=n4usXxho+0YSlUHhlo9YvGu77QGGm3+v9Q+5ElnUTrg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IDZA63TX5IHkBK76DI4pPcZ42VU6/mIySKOQEqxuD9AufzUTqIuaWiXwojBxYy+Pz xEJ591gcQLn+Aw3GzeFXIO+yVTgwYT3nu+aLLcSammxCU4BScHa7YUrGc76R7btHsP Ea0nhdqqWJqJjE23uU5j27T97Wvo+80N7/y+pn4KfwudgqCN5rYeF6JOPtfpjSU/jn U+wi8T7EUIFpe62MHSG5HwVOdKqEtDcVFL0Jl4H6piPhv8RtZ7VWAmRZXSggVUgCLx saQGTSeuufmkFRhu3uRArF4a1S5WEeDlWLb5Ds9o2TwGosJVXtOQMOB6+iU9qNofi1 +F9ZuWY2VnOtQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261117-a9-i2c-v10-2-33ea9aefce20@amlogic.com> References: <20261117-a9-i2c-v10-0-33ea9aefce20@amlogic.com> <20261117-a9-i2c-v10-2-33ea9aefce20@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 17 Nov 2026 12:19:23 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] i2c: amlogic-a9: transfer started before IRQ setup in aml_i2c_do_start() - [Medium] i2c: amlogic-a9: stale irq_state and edge IRQ miss in aml_i2c_irq() -- commit daa2538f35c86990807d57e4002f2ef5ba34903b Author: Junyi Zhao i2c: amlogic: Add Amlogic A9 I2C controller driver This commit adds a driver for the I2C controller on Amlogic A9 SoCs, along with its Kconfig, Makefile, and MAINTAINERS entries. > diff --git a/drivers/i2c/busses/i2c-amlogic-a9.c b/drivers/i2c/busses/i2c= -amlogic-a9.c > new file mode 100644 > index 0000000000000..8ec199eb414ae > --- /dev/null > +++ b/drivers/i2c/busses/i2c-amlogic-a9.c [ ... ] > +static irqreturn_t aml_i2c_irq(int irqno, void *dev_id) > +{ > + struct aml_i2c *i2c =3D dev_id; > + u8 *buf =3D NULL; > + u32 rd_len, i; > + u32 rd_val; > + u32 irq_state; > + > + guard(spinlock)(&i2c->lock); > + irq_state =3D readl(i2c->regs + REG_CFG_IRQ_STATE); > + if (i2c->state =3D=3D A9_STATE_IDLE) { > + dev_warn(i2c->dev, "i2c irq triggered abnormally, irq_state:0x%x,irq_e= n:0x%x\n", > + irq_state, readl(i2c->regs + REG_CFG_IRQ_ENABLE)); > + goto irq_trans_out; > + } > + > + if (irq_state & A9_TRANS_ERROR) { > + i2c->error =3D -ENXIO; > + goto complete_irq_out; > + } > + > + switch (i2c->state) { > + case A9_STATE_READ: > + buf =3D i2c->msg->buf; > + rd_len =3D min(i2c->msg->len - i2c->pos, A9_I2C_FIFO_DEPTH); > + for (i =3D 0; i < rd_len; i++) { > + rd_val =3D readl(i2c->regs + REG_CFG_RX); > + buf[i2c->pos++] =3D rd_val & TX_RX_DATA; > + } > + /* Rx must clear thresh after read fifo */ > + clear_irq_status(i2c, A9_RX_THRESH_READ); > + break; > + case A9_STATE_WRITE: > + aml_i2c_prepare_xfer(i2c, A9_FIFO_FILL_HALF); > + if (i2c->pos =3D=3D i2c->msg->len) > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_TX_THRESH_WRITE, 0); > + /* Tx must clear thresh after write fifo */ > + clear_irq_status(i2c, A9_TX_THRESH_WRITE); > + break; > + default: > + break; > + } > + > + if (!(irq_state & A9_TRANS_DONE) || > + (i2c->state =3D=3D A9_STATE_READ && i2c->pos < i2c->msg->len)) > + return IRQ_HANDLED; [Severity: Medium] Can aml_i2c_irq() miss the completion interrupt on multi-chunk transfers and time out in aml_i2c_xfer_msg()? The devicetree binding specifies a rising-edge interrupt: Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml: interrupts =3D <0 164 1>; In aml_i2c_irq(), irq_state is sampled once before draining REG_CFG_RX or filling REG_CFG_TX. On a 64-byte read, the 32nd byte of the second chunk triggers A9_RX_THRESH_READ before the NACK and STOP finish on the bus. If A9_PHY_DONE asserts in REG_CFG_IRQ_STATE while the handler is reading the 32 bytes from REG_CFG_RX, clearing A9_RX_THRESH_READ leaves the interrupt line continuously high (since A9_PHY_DONE is already asserted and enabled) without generating a new rising edge, while the check against the stale irq_state sees A9_TRANS_DONE =3D=3D 0 and returns early without completing i2c->done. Similarly, if both A9_RX_THRESH_READ and A9_PHY_DONE are already set in irq_state when more than 32 bytes remain to be read, aml_i2c_irq() reads only 32 bytes, clears only A9_RX_THRESH_READ, and returns because i2c->pos < i2c->msg->len. With fewer than 32 tail bytes left in the RX FIFO and A9_PHY_DONE left asserted, no rising edge will fire to drain the remaining bytes or complete the transfer. > + > +complete_irq_out: > + i2c->state =3D A9_STATE_IDLE; > + reset_fifo_pos(i2c); > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_RX_THRESH_READ | A9_TX_THR= ESH_WRITE, 0); > + complete(&i2c->done); > +irq_trans_out: > + clear_irq_status(i2c, IRQ_ALL_MASK); > + > + return IRQ_HANDLED; > +} > + > +static void aml_i2c_do_start(struct aml_i2c *i2c, struct i2c_msg *msg) > +{ > + unsigned int reg_val; > + unsigned int trans_len; > + > + trans_len =3D msg->len; > + reg_val =3D (unsigned int)(((msg->addr & 0x7f) << START_SADDR_SHIFT) | > + ((msg->flags & I2C_M_RD) ? START_READ : 0) | > + ((trans_len & 0xfff) << START_LEN_SHIFT) | START_START); > + aml_i2c_set_mask(i2c, REG_CFG_START, > + START_START | START_SLAVE_ADDR | START_READ | START_LEN, reg_val); > + clear_irq_status(i2c, IRQ_ALL_MASK); > + /* enable thresh mode */ > + if (trans_len > A9_I2C_FIFO_DEPTH) { > + reg_val =3D (msg->flags & I2C_M_RD) ? A9_RX_THRESH_READ : A9_TX_THRESH= _WRITE; > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, > + A9_RX_THRESH_READ | A9_TX_THRESH_WRITE, reg_val); > + } > +} [Severity: Medium] Should aml_i2c_do_start() clear REG_CFG_IRQ_STATE and enable threshold interrupts before setting START_START? Writing START_START starts the hardware transfer immediately while A9_NCK_ERROR and A9_PHY_DONE are already enabled in REG_CFG_IRQ_ENABLE. If execution is delayed between writing REG_CFG_START and calling clear_irq_status(i2c, IRQ_ALL_MASK) (for example under vCPU preemption or PREEMPT_RT), an address NACK or short fast transfer can assert A9_NCK_ERROR or A9_PHY_DONE before clear_irq_status() wipes it out. When aml_i2c_irq() then runs and reads irq_state =3D=3D 0, it misses A9_TRANS_DO= NE and returns without completing i2c->done, causing aml_i2c_xfer_msg() to time out. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261117-a9-i2c-v10= -0-33ea9aefce20@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E9DC8606A8AC for ; Tue, 17 Nov 2026 12:19:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=aqJdXNS5; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=IDZA63TX DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=/NjbgnBRNsQRXW4VO6uXJGSnNq2ddcjZRey97TP09Sk=; b=aqJdXNS5G/ecu5SJU3iAMzziou T5g+SU4MTC/I7Q71ildl5y3byKcDCaflqxgn9fsLp7MZsjcswBNSV9Mc/QmNIif/4oBszbzyeub8w V/XuKuuCjaLscKIzU6aGPyjcX4Ss48n034P0FizkDpsuEwSWcFq4aJbo2aEJccRpeNYvpMN3RwkL7 +jgD/A/Yt0KrS+m2B/FbxBrnr7sJFLfw9Rb5FEnXVyT+U1F+/k3YZFCv3kjU99wQn0LaC/Xg8ho63 QBpHfwcTsjKctM4EG4wS989ICO936CLG7BKkS7mma66Qyl7NV0PydfpPjeMZG/VdZtf+34lNBgqQZ nnn1UZjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTI9l-00000005bXN-3gMx; Tue, 17 Nov 2026 12:19:25 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTI9l-00000005bXH-0Xno for linux-amlogic@lists.infradead.org; Tue, 17 Nov 2026 12:19:25 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 3AED461D92; Tue, 17 Nov 2026 12:19:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94D851F000C7; Tue, 17 Nov 2026 12:19:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794917963; bh=n4usXxho+0YSlUHhlo9YvGu77QGGm3+v9Q+5ElnUTrg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=IDZA63TX5IHkBK76DI4pPcZ42VU6/mIySKOQEqxuD9AufzUTqIuaWiXwojBxYy+Pz xEJ591gcQLn+Aw3GzeFXIO+yVTgwYT3nu+aLLcSammxCU4BScHa7YUrGc76R7btHsP Ea0nhdqqWJqJjE23uU5j27T97Wvo+80N7/y+pn4KfwudgqCN5rYeF6JOPtfpjSU/jn U+wi8T7EUIFpe62MHSG5HwVOdKqEtDcVFL0Jl4H6piPhv8RtZ7VWAmRZXSggVUgCLx saQGTSeuufmkFRhu3uRArF4a1S5WEeDlWLb5Ds9o2TwGosJVXtOQMOB6+iU9qNofi1 +F9ZuWY2VnOtQ== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v10 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261117-a9-i2c-v10-2-33ea9aefce20@amlogic.com> References: <20261117-a9-i2c-v10-0-33ea9aefce20@amlogic.com> <20261117-a9-i2c-v10-2-33ea9aefce20@amlogic.com> Date: Tue, 17 Nov 2026 12:19:23 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkyYzogYW1sb2dpYy1h OTogdHJhbnNmZXIgc3RhcnRlZCBiZWZvcmUgSVJRIHNldHVwIGluCiAgYW1sX2kyY19kb19zdGFy dCgpCi0gW01lZGl1bV0gaTJjOiBhbWxvZ2ljLWE5OiBzdGFsZSBpcnFfc3RhdGUgYW5kIGVkZ2Ug SVJRIG1pc3MgaW4KICBhbWxfaTJjX2lycSgpCi0tCgpjb21taXQgZGFhMjUzOGYzNWM4Njk5MDgw N2Q1N2U0MDAyZjJlZjViYTM0OTAzYgpBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1s b2dpYy5jb20+CgppMmM6IGFtbG9naWM6IEFkZCBBbWxvZ2ljIEE5IEkyQyBjb250cm9sbGVyIGRy aXZlcgoKVGhpcyBjb21taXQgYWRkcyBhIGRyaXZlciBmb3IgdGhlIEkyQyBjb250cm9sbGVyIG9u IEFtbG9naWMgQTkgU29DcywKYWxvbmcgd2l0aCBpdHMgS2NvbmZpZywgTWFrZWZpbGUsIGFuZCBN QUlOVEFJTkVSUyBlbnRyaWVzLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pMmMvYnVzc2VzL2ky Yy1hbWxvZ2ljLWE5LmMgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFtbG9naWMtYTkuYwo+IG5l dyBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uOGVjMTk5ZWI0MTRhZQo+ IC0tLSAvZGV2L251bGwKPiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFtbG9naWMtYTku YwpbIC4uLiBdCj4gK3N0YXRpYyBpcnFyZXR1cm5fdCBhbWxfaTJjX2lycShpbnQgaXJxbm8sIHZv aWQgKmRldl9pZCkKPiArewo+ICsJc3RydWN0IGFtbF9pMmMgKmkyYyA9IGRldl9pZDsKPiArCXU4 ICpidWYgPSBOVUxMOwo+ICsJdTMyIHJkX2xlbiwgaTsKPiArCXUzMiByZF92YWw7Cj4gKwl1MzIg aXJxX3N0YXRlOwo+ICsKPiArCWd1YXJkKHNwaW5sb2NrKSgmaTJjLT5sb2NrKTsKPiArCWlycV9z dGF0ZSA9IHJlYWRsKGkyYy0+cmVncyArIFJFR19DRkdfSVJRX1NUQVRFKTsKPiArCWlmIChpMmMt PnN0YXRlID09IEE5X1NUQVRFX0lETEUpIHsKPiArCQlkZXZfd2FybihpMmMtPmRldiwgImkyYyBp cnEgdHJpZ2dlcmVkIGFibm9ybWFsbHksIGlycV9zdGF0ZToweCV4LGlycV9lbjoweCV4XG4iLAo+ ICsJCQkgaXJxX3N0YXRlLCByZWFkbChpMmMtPnJlZ3MgKyBSRUdfQ0ZHX0lSUV9FTkFCTEUpKTsK PiArCQlnb3RvIGlycV90cmFuc19vdXQ7Cj4gKwl9Cj4gKwo+ICsJaWYgKGlycV9zdGF0ZSAmIEE5 X1RSQU5TX0VSUk9SKSB7Cj4gKwkJaTJjLT5lcnJvciA9IC1FTlhJTzsKPiArCQlnb3RvIGNvbXBs ZXRlX2lycV9vdXQ7Cj4gKwl9Cj4gKwo+ICsJc3dpdGNoIChpMmMtPnN0YXRlKSB7Cj4gKwljYXNl IEE5X1NUQVRFX1JFQUQ6Cj4gKwkJYnVmID0gaTJjLT5tc2ctPmJ1ZjsKPiArCQlyZF9sZW4gPSBt aW4oaTJjLT5tc2ctPmxlbiAtIGkyYy0+cG9zLCBBOV9JMkNfRklGT19ERVBUSCk7Cj4gKwkJZm9y IChpID0gMDsgaSA8IHJkX2xlbjsgaSsrKSB7Cj4gKwkJCXJkX3ZhbCA9IHJlYWRsKGkyYy0+cmVn cyArIFJFR19DRkdfUlgpOwo+ICsJCQlidWZbaTJjLT5wb3MrK10gPSByZF92YWwgJiBUWF9SWF9E QVRBOwo+ICsJCX0KPiArCQkvKiBSeCBtdXN0IGNsZWFyIHRocmVzaCBhZnRlciByZWFkIGZpZm8g Ki8KPiArCQljbGVhcl9pcnFfc3RhdHVzKGkyYywgQTlfUlhfVEhSRVNIX1JFQUQpOwo+ICsJCWJy ZWFrOwo+ICsJY2FzZSBBOV9TVEFURV9XUklURToKPiArCQlhbWxfaTJjX3ByZXBhcmVfeGZlcihp MmMsIEE5X0ZJRk9fRklMTF9IQUxGKTsKPiArCQlpZiAoaTJjLT5wb3MgPT0gaTJjLT5tc2ctPmxl bikKPiArCQkJYW1sX2kyY19zZXRfbWFzayhpMmMsIFJFR19DRkdfSVJRX0VOQUJMRSwgQTlfVFhf VEhSRVNIX1dSSVRFLCAwKTsKPiArCQkvKiBUeCBtdXN0IGNsZWFyIHRocmVzaCBhZnRlciB3cml0 ZSBmaWZvICovCj4gKwkJY2xlYXJfaXJxX3N0YXR1cyhpMmMsIEE5X1RYX1RIUkVTSF9XUklURSk7 Cj4gKwkJYnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCWJyZWFrOwo+ICsJfQo+ICsKPiArCWlmICgh KGlycV9zdGF0ZSAmIEE5X1RSQU5TX0RPTkUpIHx8Cj4gKwkgICAgKGkyYy0+c3RhdGUgPT0gQTlf U1RBVEVfUkVBRCAmJiBpMmMtPnBvcyA8IGkyYy0+bXNnLT5sZW4pKQo+ICsJCXJldHVybiBJUlFf SEFORExFRDsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gYW1sX2kyY19pcnEoKSBtaXNzIHRoZSBj b21wbGV0aW9uIGludGVycnVwdCBvbiBtdWx0aS1jaHVuayB0cmFuc2ZlcnMKYW5kIHRpbWUgb3V0 IGluIGFtbF9pMmNfeGZlcl9tc2coKT8KClRoZSBkZXZpY2V0cmVlIGJpbmRpbmcgc3BlY2lmaWVz IGEgcmlzaW5nLWVkZ2UgaW50ZXJydXB0OgoKRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL2kyYy9hbWxvZ2ljLGE5LWkyYy55YW1sOgogICAgICAgIGludGVycnVwdHMgPSA8MCAxNjQg MT47CgpJbiBhbWxfaTJjX2lycSgpLCBpcnFfc3RhdGUgaXMgc2FtcGxlZCBvbmNlIGJlZm9yZSBk cmFpbmluZyBSRUdfQ0ZHX1JYIG9yCmZpbGxpbmcgUkVHX0NGR19UWC4gIE9uIGEgNjQtYnl0ZSBy ZWFkLCB0aGUgMzJuZCBieXRlIG9mIHRoZSBzZWNvbmQgY2h1bmsKdHJpZ2dlcnMgQTlfUlhfVEhS RVNIX1JFQUQgYmVmb3JlIHRoZSBOQUNLIGFuZCBTVE9QIGZpbmlzaCBvbiB0aGUgYnVzLiAgSWYK QTlfUEhZX0RPTkUgYXNzZXJ0cyBpbiBSRUdfQ0ZHX0lSUV9TVEFURSB3aGlsZSB0aGUgaGFuZGxl ciBpcyByZWFkaW5nIHRoZQozMiBieXRlcyBmcm9tIFJFR19DRkdfUlgsIGNsZWFyaW5nIEE5X1JY X1RIUkVTSF9SRUFEIGxlYXZlcyB0aGUgaW50ZXJydXB0CmxpbmUgY29udGludW91c2x5IGhpZ2gg KHNpbmNlIEE5X1BIWV9ET05FIGlzIGFscmVhZHkgYXNzZXJ0ZWQgYW5kIGVuYWJsZWQpCndpdGhv dXQgZ2VuZXJhdGluZyBhIG5ldyByaXNpbmcgZWRnZSwgd2hpbGUgdGhlIGNoZWNrIGFnYWluc3Qg dGhlIHN0YWxlCmlycV9zdGF0ZSBzZWVzIEE5X1RSQU5TX0RPTkUgPT0gMCBhbmQgcmV0dXJucyBl YXJseSB3aXRob3V0IGNvbXBsZXRpbmcKaTJjLT5kb25lLgoKU2ltaWxhcmx5LCBpZiBib3RoIEE5 X1JYX1RIUkVTSF9SRUFEIGFuZCBBOV9QSFlfRE9ORSBhcmUgYWxyZWFkeSBzZXQgaW4KaXJxX3N0 YXRlIHdoZW4gbW9yZSB0aGFuIDMyIGJ5dGVzIHJlbWFpbiB0byBiZSByZWFkLCBhbWxfaTJjX2ly cSgpIHJlYWRzCm9ubHkgMzIgYnl0ZXMsIGNsZWFycyBvbmx5IEE5X1JYX1RIUkVTSF9SRUFELCBh bmQgcmV0dXJucyBiZWNhdXNlCmkyYy0+cG9zIDwgaTJjLT5tc2ctPmxlbi4gIFdpdGggZmV3ZXIg dGhhbiAzMiB0YWlsIGJ5dGVzIGxlZnQgaW4gdGhlIFJYCkZJRk8gYW5kIEE5X1BIWV9ET05FIGxl ZnQgYXNzZXJ0ZWQsIG5vIHJpc2luZyBlZGdlIHdpbGwgZmlyZSB0byBkcmFpbiB0aGUKcmVtYWlu aW5nIGJ5dGVzIG9yIGNvbXBsZXRlIHRoZSB0cmFuc2Zlci4KCj4gKwo+ICtjb21wbGV0ZV9pcnFf b3V0Ogo+ICsJaTJjLT5zdGF0ZSA9IEE5X1NUQVRFX0lETEU7Cj4gKwlyZXNldF9maWZvX3Bvcyhp MmMpOwo+ICsJYW1sX2kyY19zZXRfbWFzayhpMmMsIFJFR19DRkdfSVJRX0VOQUJMRSwgQTlfUlhf VEhSRVNIX1JFQUQgfCBBOV9UWF9USFJFU0hfV1JJVEUsIDApOwo+ICsJY29tcGxldGUoJmkyYy0+ ZG9uZSk7Cj4gK2lycV90cmFuc19vdXQ6Cj4gKwljbGVhcl9pcnFfc3RhdHVzKGkyYywgSVJRX0FM TF9NQVNLKTsKPiArCj4gKwlyZXR1cm4gSVJRX0hBTkRMRUQ7Cj4gK30KPiArCj4gK3N0YXRpYyB2 b2lkIGFtbF9pMmNfZG9fc3RhcnQoc3RydWN0IGFtbF9pMmMgKmkyYywgc3RydWN0IGkyY19tc2cg Km1zZykKPiArewo+ICsJdW5zaWduZWQgaW50IHJlZ192YWw7Cj4gKwl1bnNpZ25lZCBpbnQgdHJh bnNfbGVuOwo+ICsKPiArCXRyYW5zX2xlbiA9IG1zZy0+bGVuOwo+ICsJcmVnX3ZhbCA9ICh1bnNp Z25lZCBpbnQpKCgobXNnLT5hZGRyICYgMHg3ZikgPDwgU1RBUlRfU0FERFJfU0hJRlQpIHwKPiAr CQkJCSgobXNnLT5mbGFncyAmIEkyQ19NX1JEKSA/IFNUQVJUX1JFQUQgOiAwKSB8Cj4gKwkJCQko KHRyYW5zX2xlbiAmIDB4ZmZmKSA8PCBTVEFSVF9MRU5fU0hJRlQpIHwgU1RBUlRfU1RBUlQpOwo+ ICsJYW1sX2kyY19zZXRfbWFzayhpMmMsIFJFR19DRkdfU1RBUlQsCj4gKwkJCSBTVEFSVF9TVEFS VCB8IFNUQVJUX1NMQVZFX0FERFIgfCBTVEFSVF9SRUFEIHwgU1RBUlRfTEVOLCByZWdfdmFsKTsK PiArCWNsZWFyX2lycV9zdGF0dXMoaTJjLCBJUlFfQUxMX01BU0spOwo+ICsJLyogZW5hYmxlIHRo cmVzaCBtb2RlICovCj4gKwlpZiAodHJhbnNfbGVuID4gQTlfSTJDX0ZJRk9fREVQVEgpIHsKPiAr CQlyZWdfdmFsID0gKG1zZy0+ZmxhZ3MgJiBJMkNfTV9SRCkgPyBBOV9SWF9USFJFU0hfUkVBRCA6 IEE5X1RYX1RIUkVTSF9XUklURTsKPiArCQlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19J UlFfRU5BQkxFLAo+ICsJCQkJIEE5X1JYX1RIUkVTSF9SRUFEIHwgQTlfVFhfVEhSRVNIX1dSSVRF LCByZWdfdmFsKTsKPiArCX0KPiArfQoKW1NldmVyaXR5OiBNZWRpdW1dClNob3VsZCBhbWxfaTJj X2RvX3N0YXJ0KCkgY2xlYXIgUkVHX0NGR19JUlFfU1RBVEUgYW5kIGVuYWJsZSB0aHJlc2hvbGQK aW50ZXJydXB0cyBiZWZvcmUgc2V0dGluZyBTVEFSVF9TVEFSVD8KCldyaXRpbmcgU1RBUlRfU1RB UlQgc3RhcnRzIHRoZSBoYXJkd2FyZSB0cmFuc2ZlciBpbW1lZGlhdGVseSB3aGlsZQpBOV9OQ0tf RVJST1IgYW5kIEE5X1BIWV9ET05FIGFyZSBhbHJlYWR5IGVuYWJsZWQgaW4gUkVHX0NGR19JUlFf RU5BQkxFLgpJZiBleGVjdXRpb24gaXMgZGVsYXllZCBiZXR3ZWVuIHdyaXRpbmcgUkVHX0NGR19T VEFSVCBhbmQgY2FsbGluZwpjbGVhcl9pcnFfc3RhdHVzKGkyYywgSVJRX0FMTF9NQVNLKSAoZm9y IGV4YW1wbGUgdW5kZXIgdkNQVSBwcmVlbXB0aW9uIG9yClBSRUVNUFRfUlQpLCBhbiBhZGRyZXNz IE5BQ0sgb3Igc2hvcnQgZmFzdCB0cmFuc2ZlciBjYW4gYXNzZXJ0CkE5X05DS19FUlJPUiBvciBB OV9QSFlfRE9ORSBiZWZvcmUgY2xlYXJfaXJxX3N0YXR1cygpIHdpcGVzIGl0IG91dC4gIFdoZW4K YW1sX2kyY19pcnEoKSB0aGVuIHJ1bnMgYW5kIHJlYWRzIGlycV9zdGF0ZSA9PSAwLCBpdCBtaXNz ZXMgQTlfVFJBTlNfRE9ORQphbmQgcmV0dXJucyB3aXRob3V0IGNvbXBsZXRpbmcgaTJjLT5kb25l LCBjYXVzaW5nIGFtbF9pMmNfeGZlcl9tc2coKSB0bwp0aW1lIG91dC4KCi0tIApTYXNoaWtvIEFJ IHJldmlldyDCtyBodHRwczovL3Nhc2hpa28uZGV2LyMvcGF0Y2hzZXQvMjAyNjExMTctYTktaTJj LXYxMC0wLTMzZWE5YWVmY2UyMEBhbWxvZ2ljLmNvbT9wYXJ0PTIKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFtbG9naWMgbWFpbGluZyBsaXN0 CmxpbnV4LWFtbG9naWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFk Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFtbG9naWMK