All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Arnd Bergmann" <arnd@kernel.org>, linux-mm@kvack.org
Cc: "Arnd Bergmann" <arnd@arndb.de>,
	"Andreas Larsson" <andreas@gaisler.com>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	"Christophe Leroy (CS GROUP)" <chleroy@kernel.org>,
	"Dave Hansen" <dave.hansen@linux.intel.com>,
	"David Hildenbrand (Arm)" <david@kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	"Ingo Molnar" <mingo@redhat.com>,
	"Jason Gunthorpe" <jgg@nvidia.com>,
	"Linus Walleij" <linusw@kernel.org>,
	"Lorenzo Stoakes (ARM)" <ljs@kernel.org>,
	"Lucas Stach" <l.stach@pengutronix.de>,
	"Madhavan Srinivasan" <maddy@linux.ibm.com>,
	"Malin Jonsson" <malin.jonsson@est.tech>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Simek" <monstr@monstr.eu>,
	"Mike Rapoport" <rppt@kernel.org>,
	"Nicholas Piggin" <npiggin@gmail.com>,
	"Nishanth Menon" <nm@ti.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Russell King" <linux@armlinux.org.uk>,
	"Thomas Gleixner" <tglx@linutronix.de>,
	x86@kernel.org, "Borislav Petkov" <bp@alien8.de>,
	"Lorenzo Stoakes" <lorenzo.stoakes@oracle.com>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	"Suren Baghdasaryan" <surenb@google.com>,
	"Michal Hocko" <mhocko@suse.com>
Subject: Re: [PATCH v3 06/10] arch/*: increase lowmem size to avoid highmem use
Date: Tue, 17 Nov 2026 12:49:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-218801@kernel.org> (raw)
In-Reply-To: <20261116124832.662455-7-arnd@kernel.org>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] KVM: PPC: Book3S: LOAD_HOST_SEGMENTS only restores 4 kernel SRs
  on exit
- [Medium] powerpc/85xx: LOWMEM_CAM_NUM defaults exceed 16 TLB1 entries
  on e500v1/v2
--

commit f9466fba88fe066bf9e204a300df08d4c66f1149
Author: Arnd Bergmann <arnd@arndb.de>

arch/*: increase lowmem size to avoid highmem use

This commit increases the default lowmem size across 32-bit architectures
(arm, microblaze, powerpc, and x86) to 1GiB for non-highmem builds and up to
2GiB for highmem builds, and drops CONFIG_HIGHMEM from several board
defconfigs that have at most 1GiB of RAM.

> diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig
> index c3b6cd6556069..1eef831faf3a7 100644
> --- a/arch/powerpc/Kconfig
> +++ b/arch/powerpc/Kconfig

[ ... ]

> @@ -1207,10 +1211,10 @@ config LOWMEM_CAM_NUM_BOOL
>  config LOWMEM_CAM_NUM
>  	depends on PPC_85xx
>  	int "Number of CAMs to use to map low memory" if LOWMEM_CAM_NUM_BOOL
> -	default 3 if !STRICT_KERNEL_RWX
> -	default 9 if DATA_SHIFT >= 24
> -	default 12 if DATA_SHIFT >= 22
> -	default 15
> +	default 8 if !STRICT_KERNEL_RWX
> +	default 14 if DATA_SHIFT >= 24
> +	default 17 if DATA_SHIFT >= 22
> +	default 20

[Severity: Medium]
Can the new default values of 17 and 20 for LOWMEM_CAM_NUM exceed the 16
hardware TLB1 entries on e500v1 and e500v2 cores (CONFIG_PPC_85xx=y with
CONFIG_PPC_E500MC=n)?

During boot in adjust_total_lowmem() and secondary CPU bringup in
__secondary_start, switch_to_as1() uses the last hardware TLB1 slot (entry
15 on 16-entry e500v1/v2) for its temporary AS=1 mapping while
map_mem_in_cams_addr() populates up to CONFIG_LOWMEM_CAM_NUM slots starting
from 0 without clamping against SPRN_TLB1CFG:

arch/powerpc/mm/nohash/e500.c:map_mem_in_cams_addr() {
	...
	for (i = 0; boundary && i < max_cam_idx; i++) {
	...
	}
	for (ram -= amount_mapped; ram && i < max_cam_idx; i++) {
	...
	}
	if (init) {
		loadcam_multi(0, i, max_cam_idx);
		tlbcam_index = i;
	}
	...
}

Because PAGE_OFFSET is now 0xb0000000 or 0x70000000 (an odd multiple of
256MiB), calc_cam_sz() caps each CAM at 256MiB even on e500v2.  When
CONFIG_STRICT_KERNEL_RWX=y and CONFIG_DATA_SHIFT is set below 24, mapping
1GiB or 2GiB of RAM reaches index 15 and overwrites the active AS=1 entry in
TLB1[15] (and wraps the 4-bit MAS0[ESEL] field at index 16 onto TLB1[0]),
crashing during boot.  Also, increasing all defaults by 5 unconditionally
reserves CAMs for 2GiB of lowmem even when CONFIG_HIGHMEM=n caps
LOWMEM_SIZE at 1GiB.

>  config DYNAMIC_MEMSTART
>  	bool "Enable page aligned dynamic load address for kernel"
> @@ -1242,7 +1246,8 @@ config PAGE_OFFSET_BOOL
>  
>  config PAGE_OFFSET
>  	hex "Virtual address of memory base" if PAGE_OFFSET_BOOL
> -	default "0xc0000000"
> +	default "0x70000000" if HIGHMEM && !44x
> +	default "0xb0000000"

[Severity: High]
With PAGE_OFFSET lowered to 0xb0000000 or 0x70000000 on 32-bit Book3S, does
LOAD_HOST_SEGMENTS on KVM guest exit leave the upper host kernel segment
registers holding guest values?

Commit "powerpc: kvm: allow flexible PAGE_OFFSET" updated the starting
segment and address in LOAD_HOST_SEGMENTS, but kept the loop count hardcoded
to 4:

arch/powerpc/kvm/book3s_32_sr.S:LOAD_HOST_SEGMENTS {
	...
        li      r0, 4
        mtctr   r0
	LOAD_REG_IMMEDIATE(r3, 0x20000000 | (0x111 * (PAGE_OFFSET >> 28)))
        lis     r4, (PAGE_OFFSET >> 16)
3:      mtsrin  r3, r4
        addi    r3, r3, 0x111     /* increment VSID */
        addis   r4, r4, 0x1000    /* address of next segment */
        bdnz    3b
	...
}

LOAD_GUEST_SEGMENTS overwrites all 16 segment registers on guest entry.
When PAGE_OFFSET is 0xb0000000, the 4-iteration loop only restores SRs
11..14, leaving SR15 (0xf0000000..0xffffffff, used for vmalloc, ioremap and
fixmap) with the guest's SR15 value; when PAGE_OFFSET is 0x70000000, SRs
11..15 (0xb0000000..0xffffffff) remain unrestored.  In addition, when
CONFIG_EXECMEM=y places MODULES_BASE in the 256MiB segment below
PAGE_OFFSET, NUM_USER_SEGMENTS is (PAGE_OFFSET >> 28) - 1, so starting the
restore loop at PAGE_OFFSET >> 28 instead of NUM_USER_SEGMENTS (for
16 - NUM_USER_SEGMENTS iterations, as load_segment_registers does at boot)
also leaves the module segment register unrestored.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261116124832.662455-1-arnd@kernel.org?part=6


  reply	other threads:[~2026-11-17 12:50 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 12:48 [PATCH v3 00/10] mm: highmem cleanups Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 01/10] ARM: remove support for highmem on VIVT Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot
2026-11-16 12:48 ` [PATCH v3 02/10] ARM: drop CONFIG_HIGHPTE support Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 03/10] ARM: pxa: support arbitrary PAGE_OFFSET Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 04/10] powerpc: kvm: allow flexible PAGE_OFFSET Arnd Bergmann
2026-11-16 13:38   ` Christophe Leroy (CS GROUP)
2026-11-16 22:54     ` Arnd Bergmann
2026-11-17 15:11       ` Christophe Leroy (CS GROUP)
2026-11-17 15:41         ` Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot
2026-11-16 12:48 ` [PATCH v3 05/10] ARM: add CONFIG_VMSPLIT_2G_OPT option Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 06/10] arch/*: increase lowmem size to avoid highmem use Arnd Bergmann
2026-11-17 12:49   ` sashiko-bot [this message]
2026-11-16 12:48 ` [PATCH v3 07/10] ARM: defconfig: turn off highmem in favor of CONFIG_VMSPLIT_2G_OPT Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 08/10] mm: remove ARCH_NEEDS_KMAP_HIGH_GET Arnd Bergmann
2026-11-17 10:05   ` David Hildenbrand (Arm)
2026-11-16 12:48 ` [PATCH v3 09/10] mm: drop HIGHPTE support altogether Arnd Bergmann
2026-11-16 12:48 ` [PATCH v3 10/10] mm: print pte in __print_bad_page_map_pgtable() Arnd Bergmann
2026-11-16 13:00   ` Mike Rapoport
2026-11-17 12:50   ` sashiko-bot
2026-11-18  7:32     ` Arnd Bergmann
2026-11-17 10:07 ` [PATCH v3 00/10] mm: highmem cleanups David Hildenbrand (Arm)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218801@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Liam.Howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreas@gaisler.com \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=bp@alien8.de \
    --cc=chleroy@kernel.org \
    --cc=dave.hansen@linux.intel.com \
    --cc=david@kernel.org \
    --cc=hpa@zytor.com \
    --cc=jgg@nvidia.com \
    --cc=l.stach@pengutronix.de \
    --cc=linusw@kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux@armlinux.org.uk \
    --cc=ljs@kernel.org \
    --cc=lorenzo.stoakes@oracle.com \
    --cc=maddy@linux.ibm.com \
    --cc=malin.jonsson@est.tech \
    --cc=mhocko@suse.com \
    --cc=mingo@redhat.com \
    --cc=monstr@monstr.eu \
    --cc=mpe@ellerman.id.au \
    --cc=nm@ti.com \
    --cc=npiggin@gmail.com \
    --cc=richard@nod.at \
    --cc=rppt@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=surenb@google.com \
    --cc=tglx@linutronix.de \
    --cc=vbabka@suse.cz \
    --cc=willy@infradead.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.