From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-input@vger.kernel.org, robh@kernel.org,
conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C
Date: Tue, 17 Nov 2026 13:12:13 +0000 [thread overview]
Message-ID: <sashiko-outbox-218843@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-11-rofikcoga@gmail.com>
Thank you for your contribution! Sashiko AI review found 4 potential
issues to consider:
- [High] arm64: dts: qcom: username handle used in Signed-off-by trailer
- [High] arm64: dts: qcom: sm8250-lge-timelm: missing OF graph ports in
usb-c-connector
- [High] arm64: dts: qcom: sm8250-lge-timelm: PDO_BATT in sink-pdos
breaks 9V PD current
- [Medium] arm64: dts: qcom: sm8250-lge-timelm: swapped supplies in
usb_1_qmpphy
--
commit 81ec31057ff34acf5ea3063aab5a376e5f194531
Author: rofikkerneldev <rofikcoga@gmail.com>
> arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C
>
> Enable the PM8150B Type-C controller as a sink-only port. Keep the
> primary DWC3 controller in peripheral mode for now; host mode and VBUS
> sourcing can be enabled after OTG power delivery is validated.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>
[Severity: High]
Under Documentation/process/submitting-patches.rst, the Developer's
Certificate of Origin requires a real human name rather than an account
handle in the Author header and Signed-off-by trailer.
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> index a094aa81ad225..6b57c658cf918 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8250-lge-timelm.dts
> @@ -535,6 +535,24 @@ &sdhc_2 {
> no-mmc;
> };
>
> +&pm8150b_typec {
> + status = "okay";
> +
> + vdd-pdphy-supply = <&vreg_l2a_3p1>;
> +
> + connector {
> + compatible = "usb-c-connector";
> +
> + power-role = "sink";
> + data-role = "device";
> + self-powered;
> +
> + op-sink-microwatt = <15000000>;
> + sink-pdos = <PDO_FIXED(5000, 3000, PDO_FIXED_USB_COMM)
> + PDO_BATT(5000, 9000, 15000)>;
[Severity: High]
Should the second entry in sink-pdos use PDO_VAR() or PDO_FIXED() instead
of PDO_BATT()?
PDO_BATT(5000, 9000, 15000) encodes 15000 mW in bits [9:0] in 250 mW units
(value 60). When connected to a standard USB-PD adapter advertising a 9V
PDO_TYPE_FIXED source PDO, tcpm_pd_select_pdo() matches that 9V source PDO
against this sink PDO by voltage range, and tcpm_pd_build_request() then
checks the source PDO type:
drivers/usb/typec/tcpm/tcpm.c:tcpm_pd_build_request() {
...
type = pdo_type(pdo);
...
if (type == PDO_TYPE_BATT) {
mw = min_power(pdo, matching_snk_pdo);
ma = 1000 * mw / mv;
} else {
ma = min_current(pdo, matching_snk_pdo);
mw = ma * mv / 1000;
}
}
Because the source PDO is PDO_TYPE_FIXED, min_current() calls
pdo_max_current(matching_snk_pdo), which interprets bits [9:0] in 10 mA
units. That clamps the requested current at 9V to 600 mA (5.4 W instead
of 15 W) and sets RDO_CAP_MISMATCH.
> + };
> +};
[Severity: High]
Is the connector node missing its ports subnode linking port@0 to
usb_1_dwc3_hs_out and port@1 to usb_1_qmpphy_out (along with the matching
remote-endpoint properties on those nodes)?
In qcom_pmic_typec_port_set_polarity(), the PM8150B TCPC driver does not
program SuperSpeed lane polarity itself and leaves orientation switching to
usb_1_qmpphy, which registers a Type-C orientation switch and mux in
qmp_combo_probe(). Without the OF graph endpoints under connector,
fwnode_typec_switch_get(), fwnode_typec_mux_get() and
fwnode_usb_role_switch_get() find no matches and return NULL. When a
Type-C cable is plugged in with reversed (CC2) orientation,
typec_set_orientation() is a no-op and usb_1_qmpphy stays stuck in
TYPEC_ORIENTATION_NORMAL, breaking SuperSpeed USB. Omitting port@0 also
violates Documentation/devicetree/bindings/connector/usb-connector.yaml.
> +
> &usb_1 {
> status = "okay";
> };
[Severity: Medium]
Just below &usb_1, are vdda-phy-supply and vdda-pll-supply swapped in
&usb_1_qmpphy (introduced earlier in this series in commit "arm64: dts:
qcom: add LG V60 ThinQ 5G (timelm) support")?
&usb_1_qmpphy currently sets:
vdda-phy-supply = <&vreg_l9a_1p2>;
vdda-pll-supply = <&vreg_l18a_0p9>;
On SM8250 QMP PHYs, vdda-phy-supply is the 0.9V core rail (vreg_l18a_0p9)
and vdda-pll-supply is the 1.2V PLL rail (vreg_l9a_1p2). Because
qmp_phy_vreg_l in drivers/phy/qualcomm/phy-qcom-qmp-combo.c requests
21800 uA on vdda-phy and 36000 uA on vdda-pll, swapping the supplies
programs inverted load votes on the two LDOs when &usb_1 brings the PHY up.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=10
next prev parent reply other threads:[~2026-11-17 13:12 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 13:06 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 13:04 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 13:12 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56 ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 13:12 ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev
2026-11-17 13:09 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218843@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-input@vger.kernel.org \
--cc=robh@kernel.org \
--cc=rofikcoga@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.