From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH] arm64: dts: apple: Remove undocumented, unapproved aliases
Date: Tue, 17 Nov 2026 13:24:58 +0000 [thread overview]
Message-ID: <sashiko-outbox-218871@kernel.org> (raw)
In-Reply-To: <20261117130616.234953-2-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: apple: removing aliases breaks atcphy_probe() and
Z2 calibration
--
commit aa4c33e989489cbc224f3300ed3e06e23d8eea9a
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
arm64: dts: apple: Remove undocumented, unapproved aliases
This commit removes the atcphy0..atcphy7 and touchbar0 aliases from the
Apple M1 and M2 devicetrees.
[ ... ]
> diff --git a/arch/arm64/boot/dts/apple/t8103-j293.dts b/arch/arm64/boot/dts/apple/t8103-j293.dts
> index 1d074b9e60183..779da65a66e31 100644
> --- a/arch/arm64/boot/dts/apple/t8103-j293.dts
> +++ b/arch/arm64/boot/dts/apple/t8103-j293.dts
> @@ -18,14 +18,6 @@ / {
> model = "Apple MacBook Pro (13-inch, M1, 2020)";
> chassis-type = "laptop";
>
> - /*
> - * All of those are used by the bootloader to pass calibration
> - * blobs and other device-specific properties
> - */
> - aliases {
> - touchbar0 = &touchbar0;
> - };
> -
> led-controller {
> compatible = "pwm-leds";
> led-0 {
> diff --git a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> index 686fb1dd215d2..5304a5591984d 100644
> --- a/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8103-jxxx.dtsi
> @@ -15,8 +15,6 @@ aliases {
> serial0 = &serial0;
> serial2 = &serial2;
> wifi0 = &wifi0;
> - atcphy0 = &atcphy0;
> - atcphy1 = &atcphy1;
> };
>
> chosen {
[Severity: High]
Does removing the atcphy and touchbar aliases across these devicetrees cause a
regression in atcphy_probe() and Touch Bar digitizer calibration when booting
with the m1n1 bootloader?
As described in Documentation/devicetree/bindings/phy/apple,atcphy.yaml and
Documentation/devicetree/bindings/input/touchscreen/apple,z2-multitouch.yaml,
m1n1 resolves /aliases/atcphy0..atcphy7 and /aliases/touchbar0 to copy
per-device factory calibration data from Apple's ADT into the FDT at boot
(and on Ultra SoCs in t6002-j375d.dts, t6022-j475d.dts, and t6022-j180d.dts,
atcphy4..atcphy7 map flat ADT port indices onto the second die's
atcphy0_die1..atcphy3_die1 nodes).
Without the atcphy aliases, m1n1 does not populate the required
apple,tunable-* properties on the PHY nodes, so atcphy_probe() ->
atcphy_load_tunables() -> devm_apple_tunable_parse() fails with -ENOENT:
drivers/phy/apple/atc.c:atcphy_load_tunables() {
...
*tunables[i].tunable = devm_apple_tunable_parse(
atcphy->dev, atcphy->np, tunables[i].dt_name, tunables[i].res);
if (IS_ERR(*tunables[i].tunable)) {
dev_err(atcphy->dev, "Failed to read tunable %s: %ld\n",
tunables[i].dt_name, PTR_ERR(*tunables[i].tunable));
return PTR_ERR(*tunables[i].tunable);
}
}
Aborting atcphy_probe() before atcphy_probe_finalize() prevents registration
of the ATCPHY reset controller, Type-C mux, and USB/DP PHYs, which keeps all
integrated dwc3 USB Type-C controllers on M1 and M2 systems from probing.
Similarly, without touchbar0 in t8103-j293.dts and t8112-j493.dts, m1n1
cannot inject apple,z2-cal-blob, so apple_z2_build_cal_blob() returns NULL and
apple_z2_upload_firmware() boots the Touch Bar digitizer without its
factory calibration data.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117130616.234953-2-krzysztof.kozlowski@oss.qualcomm.com?part=1
next prev parent reply other threads:[~2026-11-17 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:06 [PATCH] arm64: dts: apple: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:24 ` sashiko-bot [this message]
2026-11-17 13:41 ` Krzysztof Kozlowski
2026-11-17 17:31 ` Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218871@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.