From: sashiko-bot@kernel.org
To: "Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
devicetree@vger.kernel.org
Cc: robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases
Date: Tue, 17 Nov 2026 13:54:37 +0000 [thread overview]
Message-ID: <sashiko-outbox-218907@kernel.org> (raw)
In-Reply-To: <20261117133825.245191-4-krzysztof.kozlowski@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] arm64: dts: qcom: missing serial1 alias for uart3 when
removing hsuart0
--
commit 89fde105212b474add4ece5c8204ee69246c787d
Author: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
arm64: dts: qcom: Remove deprecated hsuart aliases
This commit removes the deprecated hsuart0 aliases from four SC7180 device
tree files, replacing hsuart0 with serial0 in sc7180-ecs-liva-qc710.dts.
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> index d9c70897b6f1c..fccd0931a9693 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-acer-aspire1.dts
> @@ -21,7 +21,6 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> index 3100fab18787a..58b93c49ccf18 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-ecs-liva-qc710.dts
> @@ -21,7 +21,7 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> + serial0 = &uart3;
> wifi0 = &wifi;
> };
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> index acfb9937651d6..7d830b25d8c66 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
> @@ -21,7 +21,6 @@ / {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> index 0e0bc8543f714..560a650b09662 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180-trogdor.dtsi
> @@ -90,7 +90,6 @@ mdata_mem: mpss-metadata {
>
> aliases {
> bluetooth0 = &bluetooth;
> - hsuart0 = &uart3;
> serial0 = &uart8;
> wifi0 = &wifi;
> };
[Severity: Medium]
Should sc7180-acer-aspire1.dts, sc7180-idp.dts and sc7180-trogdor.dtsi
replace hsuart0 = &uart3 with serial1 = &uart3 instead of dropping the
alias for &uart3?
In all three files &uart3 is enabled for the Bluetooth serdev, while
serial0 points to &uart8. Commit 08b0adb1ae54 ("serial: qcom_geni_serial:
use DT aliases according to DT bindings") switched to looking up "serial"
aliases, but qcom_geni_serial_probe() still required an alias and failed
with -ENXIO for unaliased non-console UARTs until commit a53be6945f51
("serial: qcom-geni: Remove alias dependency from qcom serial driver").
Leaving &uart3 without a serial1 alias breaks Bluetooth on kernels and
projects implementing the 2021 serial alias ABI, and shifts &uart3 from
ttyHS0 to ttyHS1 via dynamic IDA allocation on newer kernels.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117133825.245191-3-krzysztof.kozlowski@oss.qualcomm.com?part=2
prev parent reply other threads:[~2026-11-17 13:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 13:38 [PATCH 1/2] arm64: dts: qcom: Remove undocumented, unapproved aliases Krzysztof Kozlowski
2026-11-17 13:38 ` [PATCH 2/2] arm64: dts: qcom: Remove deprecated hsuart aliases Krzysztof Kozlowski
2026-11-17 13:54 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218907@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.