From: sashiko-bot@kernel.org
To: "Suyuan Wang" <shyckless@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/iwcm: Require CAP_NET_ADMIN for iWARP port mapper netlink messages
Date: Tue, 17 Nov 2026 14:27:20 +0000 [thread overview]
Message-ID: <sashiko-outbox-218963@kernel.org> (raw)
In-Reply-To: <20261117-iwpm-perm-v1-1-11f1b87d6fb3@gmail.com>
> From: Suyuan Wang <stevewong@hust.edu.cn>
>
> The RDMA_NL_IWCM callbacks process replies and notifications from the
> port mapper daemon, iwpmd, but none of them sets RDMA_NL_ADMIN_PERM:
>
> [RDMA_NL_IWPM_REG_PID] = {.dump = iwpm_register_pid_cb},
> [RDMA_NL_IWPM_ADD_MAPPING] = {.dump = iwpm_add_mapping_cb},
> ...
>
> so rdma_nl_rcv_msg() accepts them from any process in init_net.
>
> iwpm_hello_cb() and iwpm_mapping_info_cb() set iwpm_user_pid to the
> sender's port ID and mark the client IWPM_REG_INCOMPL, without matching
> any pending kernel request. An unprivileged process can thus make
> itself the daemon that the kernel sends port mapper requests to. The
> [ ... ]
> Fixes: b493d91d333e ("iwcm: common code for port mapper")
> Cc: stable@vger.kernel.org
> Co-developed-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Kaixuan Li <kaixuan.li@ntu.edu.sg>
> Signed-off-by: Suyuan Wang <stevewong@hust.edu.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-iwpm-perm-v1-1-11f1b87d6fb3@gmail.com?part=1
prev parent reply other threads:[~2026-11-17 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 14:11 [PATCH] RDMA/iwcm: Require CAP_NET_ADMIN for iWARP port mapper netlink messages Suyuan Wang
2026-11-17 14:11 ` Suyuan Wang via B4 Relay
2026-11-17 14:27 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-218963@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=shyckless@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.