All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Bramuel Barack" <bramwelbarack89@gmail.com>
Cc: linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] serial: mvebu-uart: drop of_match_ptr for ID table
Date: Tue, 17 Nov 2026 14:35:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-218970@kernel.org> (raw)
In-Reply-To: <20261117142115.18402-1-bramwelbarack89@gmail.com>

> mvebu_uart_of_match[] is always compiled in and already referenced
> directly in mvebu_uart_probe(). Wrapping it in of_match_ptr() in
> mvebu_uart_platform_driver is redundant and prevents ACPI PRP0001
> matching when CONFIG_OF is disabled.
> 
> Switch mvebu_uart_probe() from of_match_device() to
> device_get_match_data() and check for NULL so both Device Tree and
> ACPI PRP0001 bindings resolve match data safely. Also drop the
> now-unused forward declaration and <linux/of_device.h> include.
> 
> Signed-off-by: Bramuel Barack <bramwelbarack89@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117142115.18402-1-bramwelbarack89@gmail.com?part=1


      reply	other threads:[~2026-11-17 14:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:21 [PATCH v2] serial: mvebu-uart: drop of_match_ptr for ID table Bramuel Barack
2026-11-17 14:35 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218970@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bramwelbarack89@gmail.com \
    --cc=linux-serial@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.