All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Maarten Lankhorst" <dev@lankhorst.se>, intel-xe@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v6 4/5] HACK: Always fallback
Date: Tue, 17 Nov 2026 15:09:18 +0000	[thread overview]
Message-ID: <sashiko-outbox-219022@kernel.org> (raw)
In-Reply-To: <20261117143038.479557-11-dev@lankhorst.se>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/xe/display: debug return false in
  xe_display_bo_fbdev_prefer_stolen()
--

commit 8d3266f209006e137bb998d9c4625324bf01b453
Author: Maarten Lankhorst <dev@lankhorst.se>

HACK: Always fallback

This commit adds an unconditional false return in
xe_display_bo_fbdev_prefer_stolen().

> diff --git a/drivers/gpu/drm/xe/display/xe_display_bo.c b/drivers/gpu/drm/xe/display/xe_display_bo.c
> index 9385026a80b97..d78d893210c4f 100644
> --- a/drivers/gpu/drm/xe/display/xe_display_bo.c
> +++ b/drivers/gpu/drm/xe/display/xe_display_bo.c
> @@ -142,6 +142,8 @@ bool xe_display_bo_fbdev_prefer_stolen(struct xe_device *xe, unsigned int size)
>  	if (XE_DEVICE_WA(xe, 22019338487_display))
>  		return false;
>  
> +	return false;

[Severity: Medium]
Was this temporary debugging patch meant to be dropped before submission?

Returning false unconditionally leaves the stolen->size check below as
unreachable code and causes initial_plane_bo() to always discard the BIOS
initial framebuffer in stolen memory on integrated platforms when
CONFIG_FRAMEBUFFER_CONSOLE and CONFIG_DRM_FBDEV_EMULATION are enabled.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117143038.479557-7-dev@lankhorst.se?part=4

  reply	other threads:[~2026-11-17 15:09 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 14:30 [PATCH v6 0/5] drm/xe/display: Transparant fallback from stolen to sysmem Maarten Lankhorst
2026-11-17 14:30 ` [PATCH v6 1/5] drm/xe/display: Avoid using stolen memory for framebuffer when media gt exists Maarten Lankhorst
2026-11-17 14:30 ` [PATCH v6 2/5] drm/xe/migrate: Support copying between sysmem and stolen Maarten Lankhorst
2026-11-17 14:30 ` [PATCH v6 3/5] drm/xe: Raise gt frequency slightly earlier Maarten Lankhorst
2026-11-17 14:30 ` [PATCH v6 4/5] HACK: Always fallback Maarten Lankhorst
2026-11-17 15:09   ` sashiko-bot [this message]
2026-11-17 14:30 ` [PATCH v6 5/5] drm/i915: Introduce intel_bo_fbdev_bios_fb_takeover() Maarten Lankhorst
2026-11-17 15:45   ` sashiko-bot
2026-11-17 19:31     ` Maarten Lankhorst
2026-11-17 14:37 ` ✗ CI.checkpatch: warning for drm/xe/display: Transparant fallback from stolen to sysmem. (rev7) Patchwork
2026-11-17 14:39 ` ✓ CI.KUnit: success " Patchwork
2026-11-17 15:16 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17 17:07 ` ✓ i915.CI.BAT: success for drm/xe/display: Transparant fallback from stolen to sysmem. (rev6) Patchwork
2026-11-17 19:17 ` ✗ i915.CI.Full: failure " Patchwork
2026-11-18  5:15 ` ✓ Xe.CI.FULL: success for drm/xe/display: Transparant fallback from stolen to sysmem. (rev7) Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219022@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dev@lankhorst.se \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.