From: sashiko-bot@kernel.org
To: "Mukesh Ojha" <mukesh.ojha@oss.qualcomm.com>
Cc: dri-devel@lists.freedesktop.org, media-ci@linuxtv.org
Subject: Re: [PATCH v3 6/9] net: ipa: migrate firmware loading to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset()
Date: Tue, 17 Nov 2026 16:24:12 +0000 [thread overview]
Message-ID: <sashiko-outbox-219165@kernel.org> (raw)
In-Reply-To: <20261116162148.2864501-7-mukesh.ojha@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] net: ipa: leak of PAS metadata buffer in ipa_firmware_load()
--
commit e29d8ec88fcd553654746e0eff27a3767cbabafc
Author: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
net: ipa: migrate firmware loading to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset()
This commit replaces the open-coded memremap(), qcom_mdt_load(), and
qcom_pas_auth_and_reset() sequence in ipa_firmware_load() with
qcom_pas_context_init(), qcom_mdt_pas_load(), and
qcom_pas_prepare_and_auth_reset().
> diff --git a/drivers/net/ipa/ipa_main.c b/drivers/net/ipa/ipa_main.c
> index 14ac2d2faf7c2..0a37741c22858 100644
> --- a/drivers/net/ipa/ipa_main.c
> +++ b/drivers/net/ipa/ipa_main.c
> @@ -585,12 +585,11 @@ static void ipa_deconfig(struct ipa *ipa)
>
> static int ipa_firmware_load(struct device *dev)
> {
> + struct qcom_pas_context ctx;
> const struct firmware *fw;
> struct resource res;
> phys_addr_t phys;
> const char *path;
> - ssize_t size;
> - void *virt;
> int ret;
>
> ret = of_reserved_mem_region_to_resource(dev->of_node, 0, &res);
> @@ -615,24 +614,18 @@ static int ipa_firmware_load(struct device *dev)
> }
>
> phys = res.start;
> - size = (size_t)resource_size(&res);
> - virt = memremap(phys, size, MEMREMAP_WC);
> - if (!virt) {
> - dev_err(dev, "unable to remap firmware memory\n");
> - ret = -ENOMEM;
> - goto out_release_firmware;
> - }
> + qcom_pas_context_init(&ctx, dev, IPA_PAS_ID, phys, resource_size(&res));
>
> - ret = qcom_mdt_load(dev, fw, path, IPA_PAS_ID, virt, phys, size, NULL);
> + ret = qcom_mdt_pas_load(&ctx, fw, path, NULL);
> if (ret) {
> dev_err(dev, "error %d loading \"%s\"\n", ret, path);
> - } else {
> - ret = qcom_pas_auth_and_reset(IPA_PAS_ID);
> - if (ret)
> - dev_err(dev, "error %d authenticating \"%s\"\n", ret, path);
> + goto out_release_firmware;
> }
>
> - memunmap(virt);
> + ret = qcom_pas_prepare_and_auth_reset(&ctx);
> + if (ret)
> + dev_err(dev, "error %d authenticating \"%s\"\n", ret, path);
> +
> out_release_firmware:
> release_firmware(fw);
[Severity: Medium]
Does this leak the metadata buffer stored in ctx.ptr when
ipa_firmware_load() returns?
Previously, qcom_mdt_load() passed a NULL context to
__qcom_mdt_pas_init(), so qcom_pas_init_image() freed the metadata buffer
immediately. qcom_mdt_pas_load() instead passes &ctx to
__qcom_mdt_pas_init() -> qcom_pas_init_image(), which retains the coherent
DMA or TEE shared-memory allocation in ctx.ptr until
qcom_pas_metadata_release(&ctx) is called. Because ipa_firmware_load()
never calls qcom_pas_metadata_release(&ctx), the metadata buffer is leaked
on both the normal path and if qcom_mdt_pas_load() fails after
qcom_pas_init_image() succeeds.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116162148.2864501-1-mukesh.ojha@oss.qualcomm.com?part=6
next prev parent reply other threads:[~2026-11-17 16:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-16 16:21 [PATCH v3 0/9] Migrate PAS clients to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() Mukesh Ojha
2026-11-16 16:21 ` [PATCH v3 1/9] firmware: qcom: pas: add qcom_pas_context_init() for pre-allocated context Mukesh Ojha
2026-11-16 16:21 ` [PATCH v3 2/9] remoteproc: qcom_wcnss: migrate to qcom_mdt_pas_load() and qcom_pas_prepare_and_auth_reset() Mukesh Ojha
2026-11-16 16:21 ` [PATCH v3 3/9] drm/msm/adreno: migrate zap shader loading " Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot
2026-11-16 16:21 ` [PATCH v3 4/9] media: iris: migrate firmware " Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot
2026-11-16 16:21 ` [PATCH v3 5/9] media: venus: " Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot
2026-11-16 16:21 ` [PATCH v3 6/9] net: ipa: " Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot [this message]
2026-11-16 16:21 ` [PATCH v3 7/9] wifi: ath12k: " Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot
2026-11-16 16:21 ` [PATCH v3 8/9] soc: qcom: mdt_loader: remove qcom_mdt_load() Mukesh Ojha
2026-11-17 16:24 ` sashiko-bot
2026-11-16 16:21 ` [PATCH v3 9/9] firmware: qcom: pas: remove qcom_pas_auth_and_reset() Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219165@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=media-ci@linuxtv.org \
--cc=mukesh.ojha@oss.qualcomm.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.