From: sashiko-bot@kernel.org
To: "Lizhi Hou" <lizhi.hou@amd.com>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH V1] accel/amdxdna: Destroy the context when hwctx restart fails
Date: Tue, 17 Nov 2026 17:10:26 +0000 [thread overview]
Message-ID: <sashiko-outbox-219209@kernel.org> (raw)
In-Reply-To: <20261117165731.132261-1-lizhi.hou@amd.com>
Thank you for your contribution! Sashiko AI review found no new issues
in this patch, but noticed 1 related pre-existing issue it does not
introduce:
- [Critical] accel/amdxdna: hardware use-after-free in aie2_hwctx_fini()
[1]
--
commit 3c1fe55acb7bc743b1d9dd435d5bd52e64f6bdb4
Author: Lizhi Hou <lizhi.hou@amd.com>
accel/amdxdna: Destroy the context when hwctx restart fails
This commit updates aie2_hwctx_restart() to stop and destroy the hardware
context when mapping host buffers, adding heaps, or configuring CUs fails.
> diff --git a/drivers/accel/amdxdna/aie2_ctx.c b/drivers/accel/amdxdna/aie2_ctx.c
> index 74d7019268cb6..11f5421e497aa 100644
> --- a/drivers/accel/amdxdna/aie2_ctx.c
> +++ b/drivers/accel/amdxdna/aie2_ctx.c
> @@ -122,7 +122,7 @@ static int aie2_hwctx_restart(struct amdxdna_dev *xdna, struct amdxdna_hwctx *hw
> heap->mem.size);
> if (ret) {
> XDNA_ERR(xdna, "Map host buf failed, ret %d", ret);
> - goto out;
> + goto destroy;
> }
>
> xa_for_each_range(&hwctx->client->dev_heap_xa, heap_id, heap, 1,
> @@ -132,16 +132,20 @@ static int aie2_hwctx_restart(struct amdxdna_dev *xdna, struct amdxdna_hwctx *hw
> heap->mem.size);
> if (ret) {
> XDNA_ERR(xdna, "Add heap %ld failed ret %d", heap_id, ret);
> - goto out;
> + goto destroy;
> }
> }
>
> ret = aie2_config_cu(hwctx, NULL);
> if (ret) {
> XDNA_ERR(xdna, "Config cu failed, ret %d", ret);
> - goto out;
> + goto destroy;
> }
>
> + return 0;
> +
> +destroy:
> + aie2_hwctx_stop(xdna, hwctx, NULL);
> out:
> XDNA_DBG(xdna, "%s restarted, ret %d", hwctx->name, ret);
> return ret;
[Severity: Critical]
This problem wasn't introduced by this patch, but can restarting the
scheduler in aie2_hwctx_fini() before destroying the entity issue pending
jobs to a destroyed hardware context [1]?
drivers/accel/amdxdna/aie2_ctx.c:aie2_hwctx_fini() {
...
drm_sched_stop(hwctx->priv->sched, NULL);
aie2_release_resource(hwctx);
drm_sched_start(hwctx->priv->sched, 0);
mutex_unlock(&xdna->dev_lock);
drm_sched_entity_destroy(&hwctx->priv->entity);
...
}
drivers/accel/amdxdna/aie2_ctx.c:aie2_sched_job_run() {
...
if (!hwctx->priv->mbox_chann)
return NULL;
...
}
Because drm_sched_start() runs before drm_sched_entity_destroy(), the
scheduler thread pulls remaining pending jobs and passes them to
aie2_sched_job_run() after aie2_release_resource() has freed the hardware
context. Since aie2_release_resource() clears hwctx->priv->mbox_chann,
aie2_sched_job_run() returns NULL instead of an error pointer such as
ERR_PTR(-ECANCELED), which the DRM scheduler treats as successful job
completion and silently drops the jobs while signaling success to
userspace.
[1] https://sashiko.dev/#/bug/linux-97541525-e808-4942-a13a-978ecaacc230
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117165731.132261-1-lizhi.hou@amd.com?part=1
next prev parent reply other threads:[~2026-11-17 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 16:57 [PATCH V1] accel/amdxdna: Destroy the context when hwctx restart fails Lizhi Hou
2026-11-17 17:10 ` sashiko-bot [this message]
2026-11-17 20:54 ` Max Zhen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219209@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=lizhi.hou@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.