From: sashiko-bot@kernel.org
To: Frank.Li@oss.nxp.com
Cc: linux-usb@vger.kernel.org, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH v3 1/2] PM: runtime: fix stub pm_runtime_get_if_active() for !CONFIG_PM
Date: Tue, 17 Nov 2026 17:46:41 +0000 [thread overview]
Message-ID: <sashiko-outbox-219260@kernel.org> (raw)
In-Reply-To: <20261117173738.1073856-1-Frank.Li@oss.nxp.com>
> From: Frank Li <Frank.Li@nxp.com>
>
> When CONFIG_PM is not enabled, should be treated as if runtime PM were
> enabled for the device and the runtime status is active.
>
> It's a subtle distinction but the previous behavior returned -EINVAL, which
> means "runtime PM is disabled for the device"
>
> __pm_runtime_resume() returns 1 (called by pm_runtime_get()).
> pm_runtime_get_if_active() is the try-and-get version of pm_runtime_get().
> stub pm_runtime_active() also returns true. So pm_runtime_get_if_active()
> should return the same value as the stub pm_runtime_get(), which is 1.
>
> Analysis of all callers and their behavior with old (-EINVAL) vs new (1):
>
> [ ... ]
> Fixes: a71aeff3dd0a7 ("net: ipa: kill IPA clock reference count")
> Fixes: 70892277ca2db ("iommu/arm-smmu-qcom: Make set_stall work when the device is on")
> Fixes: 9ad65684b9285 ("media: staging/ipu7: Ignore interrupts when device is suspended")
> Acked-by: Alex Elder <elder@riscstar.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117173738.1073856-1-Frank.Li@oss.nxp.com?part=1
next prev parent reply other threads:[~2026-11-17 17:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:37 [PATCH v3 1/2] PM: runtime: fix stub pm_runtime_get_if_active() for !CONFIG_PM Frank.Li
2026-11-17 17:37 ` [PATCH v3 2/2] PM: runtime: fix stub pm_runtime_get_if_in_use() " Frank.Li
2026-11-17 17:37 ` Frank.Li
2026-11-17 17:39 ` ✗ LGCI.VerificationFailed: failure for series starting with [v3,1/2] PM: runtime: fix stub pm_runtime_get_if_active() " Patchwork
2026-11-17 17:46 ` sashiko-bot [this message]
2026-11-17 17:56 ` Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219260@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=Frank.Li@oss.nxp.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.