From: sashiko-bot@kernel.org
To: "David Howells" <dhowells@redhat.com>
Cc: v9fs@lists.linux.dev, "Chuck Lever" <cel@kernel.org>,
"Jeff Layton" <jlayton@kernel.org>,
"Anna Schumaker" <anna@kernel.org>
Subject: Re: [PATCH v18 08/17] netfs: Explicitly pass tail padding to netfs_writeback_single()
Date: Tue, 17 Nov 2026 17:58:42 +0000 [thread overview]
Message-ID: <sashiko-outbox-219298@kernel.org> (raw)
In-Reply-To: <20261117171958.2982801-9-dhowells@redhat.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] afs: uninitialized cache write or WARN in
afs_symlink_writepages()
--
commit 9928f42420a3a1a108161f6c7830b8d72274c828
Author: David Howells <dhowells@redhat.com>
netfs: Explicitly pass tail padding to netfs_writeback_single()
This commit updates netfs_writeback_single() to accept an explicit content
length separate from the full buffer size in the iterator, and updates AFS
directory and symlink callers to zero tail padding beyond the content length.
> diff --git a/fs/afs/symlink.c b/fs/afs/symlink.c
> index a1dbd552ddff0..c18e4f8064234 100644
> --- a/fs/afs/symlink.c
> +++ b/fs/afs/symlink.c
> @@ -228,6 +228,10 @@ int afs_readlink(struct dentry *dentry, char __user *buffer, int buflen)
> /*
> * Write the symlink contents to the cache as a single blob. We then throw
> * away the page we used to receive it.
> + *
> + * Note that the buffer tail is cleared under a shared lock on ->validate_lock
> + * - though hopefully there won't be racing writers since the only
> + * 'modification' is to be either read from the server or locally created.
> */
> int afs_symlink_writepages(struct address_space *mapping,
> struct writeback_control *wbc)
> @@ -247,9 +251,17 @@ int afs_symlink_writepages(struct address_space *mapping,
>
> if (vnode->directory &&
> atomic64_read(&vnode->cb_expires_at) != AFS_NO_CB_PROMISE) {
> + size_t i_size = i_size_read(&vnode->netfs.inode);
> +
> + if (i_size < vnode->directory_size) {
> + iov_iter_folio_queue(&iter, ITER_DEST, vnode->directory, 0, 0,
> + vnode->directory_size);
> + iov_iter_advance(&iter, i_size);
> + iov_iter_zero(vnode->directory_size - i_size, &iter);
> + }
> iov_iter_folio_queue(&iter, ITER_SOURCE, vnode->directory, 0, 0,
> - i_size_read(&vnode->netfs.inode));
> - ret = netfs_writeback_single(mapping, wbc, &iter);
> + vnode->directory_size);
> + ret = netfs_writeback_single(mapping, wbc, &iter, i_size);
> }
>
> if (ret == 0) {
[Severity: Medium]
Can afs_symlink_writepages() write uninitialized memory to fscache or
trigger the WARN_ON_ONCE(iov_iter_count(iter) < len) check in
netfs_writeback_single() if the symlink's status is updated on the server
before writeback runs?
Both afs_init_new_symlink() and afs_do_read_symlink() allocate the
PAGE_SIZE buffer in vnode->directory without __GFP_ZERO and populate only
the initial symlink length. If a third party modifies the symlink and a
status fetch runs before writeback, afs_apply_status() updates
inode->i_size to the new size while afs_apply_callback() renews
vnode->cb_expires_at, without freeing or invalidating vnode->directory.
When afs_symlink_writepages() then reads the larger i_size, it advances
past the uninitialized gap between the old and new sizes and writes those
uninitialized bytes into fscache, or passes i_size > vnode->directory_size
to netfs_writeback_single(). The directory counterpart is fixed later in
the series by commit "afs: Use a bvecq to hold dir content rather than
folioq", which checks AFS_VNODE_DIR_VALID under dvnode->cb_lock, but
symlinks remain affected.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117171958.2982801-1-dhowells@redhat.com?part=8
next prev parent reply other threads:[~2026-11-17 17:58 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 17:18 [PATCH v18 00/17] netfs, iov_iter: Use a chain of bio_vec arrays instead of folio_queue David Howells
2026-11-17 17:18 ` [PATCH v18 01/17] iov_iter: Fix kunit test to remove __init and __refdata marks David Howells
2026-11-17 17:34 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 02/17] Add a function to kmap one page of a multipage bio_vec David Howells
2026-11-17 17:28 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 03/17] iov_iter: Add a segmented queue of bio_vec[] David Howells
2026-11-17 17:56 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 04/17] netfs: Add some tools for managing bvecq chains David Howells
2026-11-17 17:51 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 05/17] iov_iter: Add an API document for the bvecq structure David Howells
2026-11-17 17:32 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 06/17] iov_iter: Add a bvecq kunit test David Howells
2026-11-17 17:30 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 07/17] afs: Fix an inconsistency in the symlink code David Howells
2026-11-17 17:38 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 08/17] netfs: Explicitly pass tail padding to netfs_writeback_single() David Howells
2026-11-17 17:58 ` sashiko-bot [this message]
2026-11-17 17:19 ` [PATCH v18 09/17] netfs: Change netfs_writeback_single() to not look inside the iterator David Howells
2026-11-17 17:53 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 10/17] netfs: Pass the write length to request creation where appropriate David Howells
2026-11-17 17:28 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 11/17] afs: Use a bvecq to hold dir content rather than folioq David Howells
2026-11-17 18:05 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 12/17] cifs: Use a bvecq for buffering instead of a folioq David Howells
2026-11-17 17:45 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 13/17] smbdirect: Support ITER_BVECQ in smbdirect_map_sges_from_iter() David Howells
2026-11-17 17:36 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 14/17] netfs: Switch folioq to bvecq David Howells
2026-11-17 18:19 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 15/17] smbdirect: Remove support for ITER_FOLIOQ from smbdirect_map_sges_from_iter() David Howells
2026-11-17 17:35 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 16/17] iov_iter: Remove ITER_FOLIOQ David Howells
2026-11-17 17:41 ` sashiko-bot
2026-11-17 17:19 ` [PATCH v18 17/17] netfs: Remove folio_queue David Howells
2026-11-17 17:37 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219298@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=anna@kernel.org \
--cc=cel@kernel.org \
--cc=dhowells@redhat.com \
--cc=jlayton@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=v9fs@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.