All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jamal Hadi Salim" <jhs@mojatatu.com>
Cc: bpf@vger.kernel.org
Subject: Re: [PATCH net-next v4 4/4] bpf: drop the stale dst when redirecting to an explicit nexthop
Date: Tue, 17 Nov 2026 19:02:31 +0000	[thread overview]
Message-ID: <sashiko-outbox-219425@kernel.org> (raw)
In-Reply-To: <CORE-9NOG.v4.r0.20261116135311-4@mojatatu.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] bpf: missing Fixes trailer for commit ba452c9e996d in commit
  message
--

commit 1e3c3c3419fd5f480aa33958ee629429b62a0379
Author: Jamal Hadi Salim <jhs@mojatatu.com>

> bpf: drop the stale dst when redirecting to an explicit nexthop
>
> This is a followup of the review of the teql arp-queue fix as reported
> by Sashiko.
>
> The issue:
> __bpf_redirect_neigh_v4() and __bpf_redirect_neigh_v6() install a dst for
> the redirect target only when the program lets the helper do the FIB
> lookup. With BPF_F_NEXTHOP the program supplies the nexthop, the lookup is
> skipped, and whatever dst the packet arrived with stays attached while
> bpf_out_neigh_v{4,6}() switch skb->dev to the target device. If that
> device's neighbour is incomplete the packet is parked on its arp_queue with
> the original route's dst; draining the queue re-looks the neighbour up from
> that dst and builds the frame with the original device's link-layer header,
> then transmits it on the target device.
>
> The Fix:
> Release the dst when the nexthop is supplied, so the queue drain keeps the
> target device's parking neighbour and the frame carries that device's
> addresses.
>
> The release goes through skb_dst_drop_keep_metadata(), so encapsulation
> parameters a route carries are handed over to a metadata dst instead of
> being lost, and a metadata dst already on the packet is left in place. Both
> wrappers take their existing drop path when that copy cannot be allocated,
> so a packet is never sent with the stale route.
>
> What the target device's transmit path still sees:
> The released dst is the route of the device the packet arrived on, and the
> packet leaves through the redirect target, so consumers of that route on
> the way out lose it:
>
>   - a tunnel with no configured remote takes its outer endpoint from the
>     route, as it does for the netfilter producer: ip_tunnel_xmit() reads
>     the route's next hop, and ip6_tnl_xmit() and sit derive it from the
>     route as well. A redirected packet whose route carried no encapsulation
>     parameters is left with no dst, so it is counted as a transmit error
>     and dropped instead of being encapsulated towards an endpoint that
>     belongs to another device's path.
>   - the route realm goes with it, so nft meta rtclassid, nft rt classid
>     and bpf_get_route_realm() stop matching on that packet.
>   - encapsulation parameters are not lost: they moved onto the metadata
>     dst, so a tunnel or an xfrm interface downstream still builds its outer
>     header.
>
> Taking the outer endpoint or the realm from another device's route is the
> same cross-device reuse this patch removes at the neighbour lookup.
>
> One consumer is older than this series. When a tunnel cannot take an
> endpoint from the skb, ip_tunnel_xmit() and ip6_tnl_xmit() fall back to
> skb_rtable(), a container_of() over whatever dst the skb carries, and a
> metadata dst is not an rtable. That fallback is reachable without this
> series: a tc-bpf program that calls bpf_skb_set_tunnel_key() with no
> remote already hands an NBMA tunnel such a dst. The release here can leave
> one behind as well, when the parameters a route carries are not usable for
> the payload. The cast is repaired separately.
>
> Conditions to recreate the bug:
> Two network namespaces, A (10.10.0.1/24) and B (10.1.0.1/24) in one, their
> veth peers in the other with only A's peer addressed (10.10.0.2/24) so B's
> nexthop cannot be resolved by ARP. Resolve A's neighbour for 10.10.0.2 as
> permanent and attach a cls_bpf egress program to A, with vb the index of B:
>
>     struct bpf_redir_neigh nh = { .nh_family = AF_INET,
>                                   .ipv4_nh = htonl(0x0a010002) };
>
>     return bpf_redirect_neigh(vb, &nh, sizeof(nh), 0);
>
> Send one packet to 10.10.0.2. It is parked on B's incomplete neighbour
> for 10.1.0.2; once that neighbour becomes valid the frame leaves B
> carrying A's source address and A's neighbour as the destination.
>
> Reported-by: Sashiko (nipa) <sashiko-bot@kernel.org>
> Closes: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/QDISC-6HS9.v3.r0.20261103062649-2@mojatatu.com
> Link: https://lore.kernel.org/netdev/QDISC-6HS9.v3.r0.20261103062649-2@mojatatu.com/
> Link: https://lore.kernel.org/netdev/avTfQjFQYR2NNdRg@chamomile/
> Reviewed-by: Victor Nogueira <victor@mojatatu.com>
> Signed-off-by: Jamal Hadi Salim <jhs@mojatatu.com>

[Severity: Low]
Since this fixes the explicit nexthop path in __bpf_redirect_neigh_v4()
and __bpf_redirect_neigh_v6(), should the commit message include a Fixes
tag?

  Fixes: ba452c9e996d ("bpf: Fix bpf_redirect_neigh helper api to support supplying nexthop")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/CORE-9NOG.v4.r0.20261116135311@mojatatu.com?part=4

      parent reply	other threads:[~2026-11-17 19:02 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-16 19:01 [PATCH net-next v4 0/4] net: drop the stale dst when steering to another device Jamal Hadi Salim
2026-11-16 19:01 ` [PATCH net-next v4 1/4] net: xfrm: interface: restore dst_orig on every xfrm interface Jamal Hadi Salim
2026-11-17 19:02   ` sashiko-bot
2026-11-16 19:01 ` [PATCH net-next v4 2/4] net: dst: keep the LWT metadata of a dropped route Jamal Hadi Salim
2026-11-16 19:01 ` [PATCH net-next v4 3/4] netfilter: nft_fwd_netdev: drop the stale dst when steering to a device Jamal Hadi Salim
2026-11-17 19:02   ` sashiko-bot
2026-11-16 19:01 ` [PATCH net-next v4 4/4] bpf: drop the stale dst when redirecting to an explicit nexthop Jamal Hadi Salim
2026-11-16 20:46   ` Alexei Starovoitov
2026-11-16 22:06     ` Jamal Hadi Salim
2026-11-17  4:50       ` Alexei Starovoitov
2026-11-17 13:15         ` Jamal Hadi Salim
2026-11-17 14:00           ` Jamal Hadi Salim
2026-11-17 19:02   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219425@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=jhs@mojatatu.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.