From: sashiko-bot@kernel.org
To: "Ville Syrjala" <ville.syrjala@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 4/6] drm/atomic: Store the device in drm_crtc_commit
Date: Tue, 17 Nov 2026 20:14:36 +0000 [thread overview]
Message-ID: <sashiko-outbox-219583@kernel.org> (raw)
In-Reply-To: <20261117200253.27078-5-ville.syrjala@linux.intel.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/atomic: missing Fixes trailer for drm_crtc_commit_wait()
NULL deref fix
--
commit 433f54d3266af0158d7292f32d2620e6b84e2e85
Author: Ville Syrjälä <ville.syrjala@linux.intel.com>
> drm/atomic: Store the device in drm_crtc_commit
>
> drm_crtc_commit_wait() gets the device for its timeout messages from
> commit->crtc, which is NULL for the fake commit that tracks unbound
> planes and connectors. If waiting for the fake commit's hw_done ever
> times out we oops instead of printing the message.
>
> Store the device in the commit and use it for the messages instead,
> and also print the CRTC when there is one so the messages say which
> commit timed out. Document that drm_crtc_commit.crtc is NULL for the
> fake commit.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
[Severity: Low]
This fixes a NULL pointer dereference introduced when
drm_crtc_commit_wait() was converted from DRM_ERROR() to
drm_err(commit->crtc->dev, ...). Should this include a Fixes: tag?
Fixes: 6e22dc358377 ("drm: get rid of DRM_DEBUG_* log calls in drm core, files drm_a*.c")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117200253.27078-1-ville.syrjala@linux.intel.com?part=4
next prev parent reply other threads:[~2026-11-17 20:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 20:02 [PATCH 0/6] drm/atomic-helper: Eliminate the fake_commit spurious -EBUSYs Ville Syrjala
2026-11-17 20:02 ` [PATCH 1/6] drm/atomic-helper: Limit run-ahead of fake commit only commits Ville Syrjala
2026-11-17 20:02 ` [PATCH 2/6] drm/atomic-helper: Complete fake_commit->flip_done in setup_commit Ville Syrjala
2026-11-17 20:02 ` [PATCH 3/6] drm/tests: Test fake_commit->flip_done completion Ville Syrjala
2026-11-17 20:02 ` [PATCH 4/6] drm/atomic: Store the device in drm_crtc_commit Ville Syrjala
2026-11-17 20:14 ` sashiko-bot [this message]
2026-11-17 20:02 ` [PATCH 5/6] drm/tests: Test the device stored " Ville Syrjala
2026-11-17 20:02 ` [PATCH 6/6] drm/tests: Test limiting the run-ahead of fake commit only commits Ville Syrjala
2026-11-17 20:23 ` sashiko-bot
2026-11-17 20:16 ` ✗ CI.checkpatch: warning for drm/atomic-helper: Eliminate the fake_commit spurious -EBUSYs Patchwork
2026-11-17 20:18 ` ✓ CI.KUnit: success " Patchwork
2026-11-17 20:57 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17 21:04 ` ✓ i915.CI.BAT: " Patchwork
2026-11-18 0:36 ` ✗ i915.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219583@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.