All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Orgad Shaneh" <orgads@gmail.com>,
	miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com,
	tsbogend@alpha.franken.de
Cc: linux-mtd@lists.infradead.org, linusw@kernel.org,
	kaloz@kernel.org, ulli.kroll@googlemail.com, john@phrozen.org,
	nico@fluxnic.net, dwmw2@infradead.org, corbet@lwn.net
Subject: Re: [PATCH v4 3/4] MIPS: Octeon: flash: allocate the map per device
Date: Tue, 17 Nov 2026 21:50:06 +0000	[thread overview]
Message-ID: <sashiko-outbox-219714@kernel.org> (raw)
In-Reply-To: <20261117214141.3826637-4-orgads@gmail.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] MIPS: Octeon: missing Fixes trailer for octeon_flash_probe()
  static map bug
--

commit be5173a34aecc571a39f6355a5088e09f2d61146
Author: Orgad Shaneh <orgads@gmail.com>

> MIPS: Octeon: flash: allocate the map per device
>
> octeon_flash_probe() fills in one static map_info for every "cfi-flash"
> node it binds to, so a second chip select overwrites the phys, virt,
> size and bank width of the first while that MTD device still uses the
> map. A probe whose do_map_probe() finds no chip also keeps its
> ioremap() mapping and still returns success.
>
> Allocate the map with devm_kzalloc(), map it with devm_ioremap() and
> fail the probe when no chip is found or the partitions cannot be
> registered, so the mapping goes away with the device. mymtd was never
> read; drop it.
>
> The driver has no remove(), and the mapping is now device-managed: a
> sysfs unbind would unmap the flash while its MTD device stays
> registered. Set suppress_bind_attrs to rule that out.
>
> Signed-off-by: Orgad Shaneh <orgads@gmail.com>

[Severity: Low]
This fixes the static flash_map overwrite and probe error handling in
octeon_flash_probe().  Should it include:

  Fixes: 7f481716bc90 ("MIPS: OCTEON: Use device tree to probe for flash chips.")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117214141.3826637-1-orgads@gmail.com?part=3

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  reply	other threads:[~2026-11-17 21:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 21:41 [PATCH v4 0/4] mtd: point() for cfi_cmdset_0002, on simple maps only Orgad Shaneh
2026-11-17 21:41 ` Orgad Shaneh
2026-11-17 21:41 ` [PATCH v4 1/4] mtd: maps: only point() maps read through the simple accessors Orgad Shaneh
2026-11-17 21:41   ` Orgad Shaneh
2026-11-17 21:41 ` [PATCH v4 2/4] mtd: cfi_cmdset_0002: implement point() for simple linear maps Orgad Shaneh
2026-11-17 21:41   ` Orgad Shaneh
2026-11-17 21:57   ` sashiko-bot
2026-11-17 22:06     ` Orgad Shaneh
2026-11-17 21:41 ` [PATCH v4 3/4] MIPS: Octeon: flash: allocate the map per device Orgad Shaneh
2026-11-17 21:41   ` Orgad Shaneh
2026-11-17 21:50   ` sashiko-bot [this message]
2026-11-17 22:06     ` Orgad Shaneh
2026-11-17 21:41 ` [PATCH v4 4/4] MIPS: Octeon: flash: use the simple map accessors without a shared eMMC Orgad Shaneh
2026-11-17 21:41   ` Orgad Shaneh
2026-11-17 22:06   ` sashiko-bot
2026-11-18  6:35     ` Orgad Shaneh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219714@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=corbet@lwn.net \
    --cc=dwmw2@infradead.org \
    --cc=john@phrozen.org \
    --cc=kaloz@kernel.org \
    --cc=linusw@kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=nico@fluxnic.net \
    --cc=orgads@gmail.com \
    --cc=richard@nod.at \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=tsbogend@alpha.franken.de \
    --cc=ulli.kroll@googlemail.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.