All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Tim Douglas" <me@timdoug.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] fbdev: macmodes: compare the pixel clock of each candidate mode
Date: Wed, 18 Nov 2026 01:31:30 +0000	[thread overview]
Message-ID: <sashiko-outbox-219903@kernel.org> (raw)
In-Reply-To: <20261118012557.79419-1-me@timdoug.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] fbdev: macmodes: missing Fixes trailer for mac_var_to_vmode()
  bug fix
--

commit a5693e36289da1dfee41e154db2fb9b39fdc0554
Author: Tim Douglas <me@timdoug.com>

> fbdev: macmodes: compare the pixel clock of each candidate mode
>
> In the second pass through the mode table in mac_var_to_vmode(),
> the requested pixel clock period was compared with the first mode's
> period at every step. The last mode at that resolution was therefore
> returned even when its period was too short. Compare against the
> current candidate's period.
>
> Tested on a Performa 6200CD using a kernel with local platform
> support. With video=valkyriefb:vmode:10 (800x600 at 60 Hz), the
> measured refresh rate was about 72 Hz before the fix and 60 Hz
> afterward. At 640x480, 67 Hz was also selected for a 60 Hz request
> before the fix.
>
> AI assistance was used to investigate the mode-table walk and draft
> the fix.
>
> Signed-off-by: Tim Douglas <me@timdoug.com>

[Severity: Low]
Since this fixes the second-pass pixel clock check in mac_var_to_vmode(),
should this include:

  Fixes: d876c11a0fd4 ("fbdev: mac_var_to_mode() fix")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118012557.79419-1-me@timdoug.com?part=1

      reply	other threads:[~2026-11-18  1:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  1:25 [PATCH] fbdev: macmodes: compare the pixel clock of each candidate mode Tim Douglas
2026-11-18  1:31 ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-219903@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=me@timdoug.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.