From: sashiko-bot@kernel.org
To: "Faruque Ansari" <faruque.ansari@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board
Date: Wed, 18 Nov 2026 02:48:40 +0000 [thread overview]
Message-ID: <sashiko-outbox-219984@kernel.org> (raw)
In-Reply-To: <20261117-monaco-draco-v1-3-e42d1673148d@oss.qualcomm.com>
Thank you for your contribution! Sashiko AI review found 6 potential
issues to consider:
- [High] arm64: dts: qcom: non-routable hostname email in Signed-off-by
trailer
- [High] arm64: dts: qcom: missing enable-active-high on vreg_dp0_pwr
regulator
- [High] arm64: dts: qcom: misplaced PCIe PERST#/WAKE# GPIOs and wrong
WAKE# polarity
- [High] arm64: dts: qcom: missing pciclass,0604 compatible on TC9563
port pcie@1,0
- [Medium] arm64: dts: qcom: TC9563 Ethernet endpoints modeled as PCI
bridges
- [Low] arm64: dts: qcom: commit message mismatch for uart2 and pcie1
topology
--
commit 6997fa812fd3a9900d7e8a3fd80ef7fb41e46e05
Author: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
> arm64: dts: qcom: add Monaco Draco EVK board
>
> The Monaco Draco EVK pairs the Monaco Draco AC SoM with the Draco
> carrier board. Add its device tree, describing the board-specific
> peripherals layered on top of the SoM:
>
> - I2C GPIO expanders: 4x KTS1622 on i2c14 and 2x TCA9538 on i2c15
> - EEPROM with a MAC-address nvmem layout on i2c15
> - Native DisplayPort output (DP0)
> - Gigabit Ethernet (ethernet0, 2500base-x) over an HSGMII PHY, with
> the MAC address sourced from the EEPROM
> - Dual PCIe (pcie0/pcie1) behind an on-board TC9563 PCIe switch
> - ST33HTPM TPM over spi10
> - AMC6821 fan controller on i2c13
> - M.2 E-key slot connector and carrier debug UART (uart2)
>
> Also hook the board dtb into the Makefile, together with an EL2
> overlay variant that boots the kernel at EL2 for KVM.
>
> Co-developed-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Signed-off-by: Vishnu Saini <vishnu.saini@oss.qualcomm.com>
> Co-developed-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Signed-off-by: Khalid Faisal Ansari <khalid.ansari@oss.qualcomm.com>
> Co-developed-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
> Signed-off-by: Dipa Mantre <dipa.mantre@oss.qualcomm.com>
> Co-developed-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
> Signed-off-by: Sravani Tella <tella@hu-tella-hyd.qualcomm.com>
> Co-developed-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> Signed-off-by: Monish Chunara <monish.chunara@oss.qualcomm.com>
> Co-developed-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
> Signed-off-by: Ajinkya Inchure <ainchure@qti.qualcomm.com>
> Signed-off-by: Faruque Ansari <faruque.ansari@oss.qualcomm.com>
[Severity: High]
The Co-developed-by and Signed-off-by trailers for Sravani Tella use an
internal workstation hostname (tella@hu-tella-hyd.qualcomm.com) rather than
a routable email address.
> diff --git a/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
> new file mode 100644
> index 0000000000000..ad416f586514f
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/monaco-draco-evk.dts
> @@ -0,0 +1,546 @@
[ ... ]
> + vreg_dp0_pwr: regulator-dp0-pwr {
> + compatible = "regulator-fixed";
> + regulator-name = "VREG_DP0_PWR_3P3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + gpio = <&expander1 7 GPIO_ACTIVE_HIGH>;
> + };
[Severity: High]
Is vreg_dp0_pwr missing enable-active-high?
For regulator-fixed nodes, of_gpio_quirk_polarity() ignores the phandle
flags in gpio and forces OF_GPIO_ACTIVE_LOW unless enable-active-high is
present, which will invert the DisplayPort 3.3V power enable line.
[ ... ]
> +&pcie0 {
> + perst-gpios = <&tlmm 2 GPIO_ACTIVE_LOW>;
> + wake-gpios = <&tlmm 0 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&pcie0_default_state>;
> + pinctrl-names = "default";
> +
> + iommu-map = <0x0 &pcie_smmu 0x0 0x0 0x1>,
> + <0x100 &pcie_smmu 0x1 0x0 0x1>,
> + <0x208 &pcie_smmu 0x2 0x0 0x1>,
> + <0x210 &pcie_smmu 0x3 0x0 0x1>,
> + <0x218 &pcie_smmu 0x4 0x0 0x1>,
> + <0x300 &pcie_smmu 0x5 0x0 0x1>,
> + <0x400 &pcie_smmu 0x6 0x0 0x1>,
> + <0x500 &pcie_smmu 0x7 0x0 0x1>,
> + <0x501 &pcie_smmu 0x8 0x0 0x1>;
> +
> + status = "okay";
> +};
> +
> +&pcie1 {
> + perst-gpios = <&tlmm 23 GPIO_ACTIVE_LOW>;
> + wake-gpios = <&tlmm 21 GPIO_ACTIVE_HIGH>;
> + pinctrl-0 = <&pcie1_default_state>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
[Severity: High]
Should reset-gpios and wake-gpios be placed on &pcieport0 and &pcieport1
with GPIO_ACTIVE_LOW for wake-gpios instead of on &pcie0 and &pcie1?
pci_configure_of_wake_gpio() looks up wake-gpios on the Root Port PCI
device node rather than the host bridge node, so wake-gpios on &pcie0 and
&pcie1 is never read; in addition, the pulled-up PCIe WAKE# line is
active-low (see 04bc4263d8b7 ("arm64: dts: qcom: monaco: Fix PCIe WAKE#
GPIO polarity")), so GPIO_ACTIVE_HIGH would configure a level-high
interrupt on a line that idles high. Placing perst-gpios on the host
bridge node when Root Port child nodes exist also triggers a warning in
qcom_pcie_parse_perst() and registers duplicate PERST# descriptors for
each child PCI bridge node.
> +
> +&pcieport0 {
> + #address-cells = <3>;
> + #size-cells = <2>;
> +
> + pcie@0,0 {
[ ... ]
> + pcie@1,0 {
> + reg = <0x20800 0x0 0x0 0x0 0x0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges;
> + bus-range = <0x3 0xff>;
> +
> + port {
> + tc9563_pcie1_ep: endpoint {
> + remote-endpoint = <&m2_e_pcie_ep>;
> + };
> + };
> + };
[Severity: High]
Does pcie@1,0 need compatible = "pciclass,0604"?
pci_pwrctrl_is_required() returns false for any bridge node without a
compatible string starting with "pci", and slot_pwrctrl_driver matches
"pciclass,0604". Without it, no pwrctrl device is created for pcie@1,0 and
the M.2 Key E connector's PCIe power sequence (enabling vpcie3v3-supply) is
never run before PCIe enumeration.
> +
> + pcie@2,0 {
> + reg = <0x21000 0x0 0x0 0x0 0x0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges;
> + bus-range = <0x4 0xff>;
> + };
> +
> + pcie@3,0 {
> + reg = <0x21800 0x0 0x0 0x0 0x0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges;
> + bus-range = <0x5 0xff>;
> +
> + pcie@0,0 {
> + reg = <0x50000 0x0 0x0 0x0 0x0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges;
> + };
> +
> + pcie@0,1 {
> + reg = <0x50100 0x0 0x0 0x0 0x0>;
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges;
> + };
> + };
[Severity: Medium]
Should the two child nodes under pcie@3,0 be ethernet@0,0 and ethernet@0,1
endpoint nodes rather than PCI bridges?
Under toshiba,tc9563.yaml, pcie@3,0 only permits ^ethernet@0,[0-1]$ child
nodes for the switch's integrated Ethernet MAC endpoints. Defining them
as pcie@0,0 and pcie@0,1 with device_type = "pci", #address-cells,
#size-cells, and ranges fails dtbs_check and causes PCI bridge walkers
such as qcom_pcie_parse_perst() to treat the endpoints as PCI-to-PCI
bridges.
[ ... ]
> +&uart2 {
> + status = "okay";
> +
> + port {
> + uart2_ep: endpoint {
> + remote-endpoint = <&m2_e_uart_ep>;
> + };
> + };
> +};
[Severity: Low]
The commit message describes uart2 as the "carrier debug UART (uart2)",
whereas here uart2 is wired to the Bluetooth UART port (port@3) of
wifi-bt-connector (and debug console is uart7 in monaco-draco-ac-som.dtsi).
Similarly, the commit message says "Dual PCIe (pcie0/pcie1) behind an
on-board TC9563 PCIe switch", while only pcie0 is connected to the TC9563
switch.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-monaco-draco-v1-0-e42d1673148d@oss.qualcomm.com?part=3
prev parent reply other threads:[~2026-11-18 2:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 2:42 [PATCH 0/3] arm64: dts: qcom: add Monaco Draco EVK board support Faruque Ansari
2026-11-17 2:42 ` [PATCH 1/3] dt-bindings: arm: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-17 2:42 ` [PATCH 2/3] arm64: dts: qcom: add Monaco Draco AC SoM Faruque Ansari
2026-11-18 2:48 ` sashiko-bot
2026-11-17 2:42 ` [PATCH 3/3] arm64: dts: qcom: add Monaco Draco EVK board Faruque Ansari
2026-11-18 2:48 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-219984@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=faruque.ansari@oss.qualcomm.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.