All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Yijie Yang" <yijie.yang@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support
Date: Wed, 18 Nov 2026 03:53:05 +0000	[thread overview]
Message-ID: <sashiko-outbox-220055@kernel.org> (raw)
In-Reply-To: <20261118-wlan-bt-v1-1-18bb1b059a17@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: dts: qcom: maili-mtp: wrong vddrfa supplies in
  wcn7850-pmu
--

commit 0117df6375848f6603dc465badcac7a530d4ecbc
Author: Yijie Yang <yijie.yang@oss.qualcomm.com>

arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support

This commit adds the WCN7850 PMU node, PCIe Wi-Fi node, and associated
pinctrl configuration to enable WLAN on the Maili MTP board.

> diff --git a/arch/arm64/boot/dts/qcom/maili-mtp.dts b/arch/arm64/boot/dts/qcom/maili-mtp.dts
> index 5409d0a7ec2e0..a3c2016eb9053 100644
> --- a/arch/arm64/boot/dts/qcom/maili-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/maili-mtp.dts
> @@ -142,6 +142,63 @@ sdcard_vdd_3p0: sdcard-vdd-3p0 {
>  
>  		vin-supply = <&vreg_bob1>;
>  	};
> +
> +	wcn7850-pmu {
> +		compatible = "qcom,wcn7850-pmu";
> +
> +		pinctrl-0 = <&wlan_en>, <&sw_ctrl_default>;
> +		pinctrl-names = "default";
> +
> +		wlan-enable-gpios = <&pmh0104_c_e0_gpios 7 GPIO_ACTIVE_HIGH>;
> +
> +		vdd-supply = <&vreg_s1j_0p8>;
> +		vddio-supply = <&vreg_l2d_1p8>;
> +		vddio1p2-supply = <&vreg_l4g_1p2>;
> +		vddaon-supply = <&vreg_s9d_1p0>;
> +		vdddig-supply = <&vreg_s3c_1p2>;
> +		vddrfa1p2-supply = <&vreg_s9d_1p0>;
> +		vddrfa1p8-supply = <&vreg_s7g_1p2>;

[Severity: High]
Are vddrfa1p2-supply and vddrfa1p8-supply shifted off by one rail here?

vddrfa1p2-supply is wired to the 1.0V vreg_s9d_1p0 rail (duplicating
vddaon-supply) instead of the 1.2V vreg_s7g_1p2 rail, while vddrfa1p8-supply
is wired to the 1.2V vreg_s7g_1p2 rail instead of the 1.8V vreg_s4c_1p8 rail
defined on pmh0104_c_e0:

arch/arm64/boot/dts/qcom/maili-mtp.dts:
		vreg_s4c_1p8: smps4 {
			regulator-name = "vreg_s4c_1p8";
			regulator-min-microvolt = <1808000>;
			regulator-max-microvolt = <2040000>;
			regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
		};

Because pwrseq_qcom_wcn_vregs_enable() only calls regulator_bulk_enable()
without setting voltages, the mismatch is not caught at probe time; instead,
vreg_s4c_1p8 is never enabled when powering on WCN7850 and can be disabled
as an unused rail by regulator_late_cleanup(), breaking WCN7850 bring-up.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-wlan-bt-v1-0-18bb1b059a17@oss.qualcomm.com?part=1

  reply	other threads:[~2026-11-18  3:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  3:33 [PATCH 0/2] arm64: dts: qcom: Enable WCN7850 on Maili MTP Yijie Yang
2026-11-18  3:33 ` [PATCH 1/2] arm64: dts: qcom: maili-mtp: Add WCN7850 WLAN support Yijie Yang
2026-11-18  3:53   ` sashiko-bot [this message]
2026-11-18  7:47     ` Yijie Yang
2026-11-18  3:33 ` [PATCH 2/2] arm64: dts: qcom: maili-mtp: Add WCN7850 Bluetooth support Yijie Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220055@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=yijie.yang@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.