From: sashiko-bot@kernel.org
To: "Dylan Hatch" <dylanbhatch@google.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>
Cc: "Herbert Xu" <herbert@gondor.apana.org.au>,
"David S . Miller" <davem@davemloft.net>,
"Nathan Chancellor" <nathan@kernel.org>,
"Nicolas Schier" <nsc@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
"Bill Wendling" <morbo@google.com>,
"Justin Stitt" <justinstitt@google.com>,
"Weinan Liu" <wnliu@google.com>,
"Jens Remus" <jremus@linux.ibm.com>,
linux-kbuild@vger.kernel.org, linux-crypto@vger.kernel.org,
"Josh Poimboeuf" <jpoimboe@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Indu Bhagat" <ibhagatgnu@gmail.com>,
"Prasanna Kumar T S M" <ptsm@linux.microsoft.com>,
live-patching@vger.kernel.org
Subject: Re: [RFC PATCH 12/12] unwind: arm64: use .lr_unwind to unwind interrupt frames
Date: Wed, 18 Nov 2026 04:36:14 +0000 [thread overview]
Message-ID: <sashiko-outbox-220115@kernel.org> (raw)
In-Reply-To: <20261117043504.1021063-13-dylanbhatch@google.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] arm64: stacktrace: broken unwind of synthetic pt_regs in
kunwind_next()
--
commit 68ea7139e10984e52da92dcf88b763bce8dfdff8
Author: Dylan Hatch <dylanbhatch@google.com>
unwind: arm64: use .lr_unwind to unwind interrupt frames
This commit adds kunwind_next_regs_lr_unwind() to unwind across pt_regs
exception boundaries using .lr_unwind metadata, falling back to
frame-pointer unwinding and marking the stacktrace unreliable on failure.
> diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c
> index 3ebcf8c53fb04..842555a4a3fe2 100644
> --- a/arch/arm64/kernel/stacktrace.c
> +++ b/arch/arm64/kernel/stacktrace.c
[ ... ]
> @@ -244,6 +249,65 @@ kunwind_next_frame_record(struct kunwind_state *state)
> return 0;
> }
>
> +#ifdef CONFIG_ARM64_LR_UNWIND
> +
> +/*
> + * Unwind from a pt_regs according to .lr_unwind info.
> + */
> +static __always_inline int
> +kunwind_next_regs_lr_unwind(struct kunwind_state *state)
> +{
> + struct pt_regs *regs = state->regs;
> + enum lr_unwind_mode mode;
> + unsigned int sp_off;
> + unsigned long fp;
> + int err;
> +
> + if (WARN_ON_ONCE(state->source != KUNWIND_SOURCE_REGS_PC))
> + return -EINVAL;
> + if (WARN_ON_ONCE(!regs))
> + return -EINVAL;
> +
> + state->regs = NULL;
> +
> + err = lr_unwind_find(state->common.pc, &mode, &sp_off);
> + if (err) {
> + /* Fallback to FP based unwinder */
> + state->unreliable = true;
> + return kunwind_next_frame_record(state);
> + }
> +
> + switch (mode) {
> + case LR_UNWIND_LIVE:
> + if (state->common.fp & 0x7)
> + return -EINVAL;
> + state->common.pc = regs->regs[30];
> + state->source = KUNWIND_SOURCE_REGS_LR;
> + return 0;
> + case LR_UNWIND_FP:
> + return kunwind_next_frame_record(state);\n> + case LR_UNWIND_SP:
> + if (check_add_overflow(regs->sp, (unsigned long)sp_off, &fp))
> + return -EINVAL;
> + state->common.fp = fp;
> + return kunwind_next_frame_record(state);
[Severity: High]
Does kunwind_next_regs_lr_unwind() mis-unwind synthetic pt_regs passed via
arch_stack_walk() -> kunwind_init_from_regs()?
kunwind_init_from_regs() sets state->source = KUNWIND_SOURCE_REGS_PC for
any caller-supplied pt_regs, not just on-stack exception frames. Software
perf events, tracepoints, and BPF stack helpers pass a pt_regs filled by
perf_arch_fetch_caller_regs():
arch/arm64/include/asm/perf_event.h:perf_arch_fetch_caller_regs() {
(regs)->pc = (__ip); \
(regs)->regs[29] = (unsigned long) __builtin_frame_address(0); \
(regs)->sp = current_stack_pointer; \
(regs)->pstate = PSR_MODE_EL1h; \
}
Here regs->pc is CALLER_ADDR0 (in the caller frame), while regs->sp and
regs->regs[29] belong to the inner frame and regs->regs[30] is unset.
When lr_unwind_find(regs->pc) returns LR_UNWIND_SP, adding the caller's
sp_off to the inner frame's regs->sp points state->common.fp into the
middle of the stack frame, causing kunwind_next_frame_record() to treat
arbitrary stack words as {fp, lr} (leaking stack contents into perf or BPF
callchains or hitting WARN_ON_ONCE(tsk == current) in
kunwind_next_frame_record_meta() if both words are zero).
Similarly, arch_ftrace_fill_perf_regs() leaves regs->regs[30] unset (so
LR_UNWIND_LIVE at fentry sets pc to 0 and drops the caller frame) and at
fexit copies an uninitialized fregs->sp from return_to_handler into
regs->sp.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261117043504.1021063-1-dylanbhatch@google.com?part=12
prev parent reply other threads:[~2026-11-18 4:36 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-17 4:34 [RFC PATCH 00/12] arm64, unwind: add .lr_unwind unwinder for reliable stacktrace Dylan Hatch
2026-11-17 4:34 ` [RFC PATCH 01/12] arm64, unwind: build with .eh_frame and add gen_lr_unwind skeleton Dylan Hatch
2026-11-18 4:36 ` sashiko-bot
2026-11-17 4:34 ` [RFC PATCH 02/12] arm64: factor .eh_frame parser out of patch-scs.c into <asm/eh_frame.h> Dylan Hatch
2026-11-18 4:36 ` sashiko-bot
2026-11-17 4:34 ` [RFC PATCH 03/12] arm64: eh_frame: track CFA and x29/x30 register state in CFI parser Dylan Hatch
2026-11-17 4:34 ` [RFC PATCH 04/12] arm64, unwind: parse .eh_frame into .lr_unwind entries in gen_lr_unwind Dylan Hatch
2026-11-17 4:34 ` [RFC PATCH 05/12] scripts/gen_lr_unwind: emit .lr_unwind_fde and .lr_unwind_ranges Dylan Hatch
2026-11-17 4:34 ` [RFC PATCH 06/12] scripts/gen_lr_unwind: add --dump option to inspect .lr_unwind tables Dylan Hatch
2026-11-18 4:36 ` sashiko-bot
2026-11-17 4:34 ` [RFC PATCH 07/12] scripts/sorttable: sort .lr_unwind_fde by start_offset Dylan Hatch
2026-11-17 4:35 ` [RFC PATCH 08/12] arm64, unwind: add in-kernel .lr_unwind lookup and validation Dylan Hatch
2026-11-17 4:35 ` [RFC PATCH 09/12] arm64/module, unwind: add .lr_unwind support for modules Dylan Hatch
2026-11-17 4:35 ` [RFC PATCH 10/12] arm64: entry: add unwind info for call_on_irq_stack() Dylan Hatch
2026-11-17 4:35 ` [RFC PATCH 11/12] arm64, crypto/lib: annotate leaf functions with CFI info Dylan Hatch
2026-11-18 5:07 ` Eric Biggers
2026-11-17 4:35 ` [RFC PATCH 12/12] unwind: arm64: use .lr_unwind to unwind interrupt frames Dylan Hatch
2026-11-18 4:36 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220115@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dylanbhatch@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=ibhagatgnu@gmail.com \
--cc=jpoimboe@kernel.org \
--cc=jremus@linux.ibm.com \
--cc=justinstitt@google.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nsc@kernel.org \
--cc=ptsm@linux.microsoft.com \
--cc=rostedt@goodmis.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=will@kernel.org \
--cc=wnliu@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.