From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794981725; b=M9plYsVJN0j7SJt1EPm0iQ+UsU/larQTYNSgkuP7cbDtT74OrKgf71FEdE6Iej/kqZZc 5nOjNAVD67nOmYL5wBUoGBJESLSz3cVuHy7Su7pcixFPd/jJ+gxC0+ABCdVBAtb2aXWu4 WLRGrtb+TR8Wg0PS95Q+j20HCXhyEr6iup+FaVFqedDg3oWkWPlZOvBADq0dfqcn0+eXE oBxkCxqjOH8v3OhFVmqJJRBd2jTfMISgRp9Me4XuLjNBlGbNHpANNFNvpuJsS9Mntaa6I ZyeUMtqubwr5ubLRWWEYyF1EY0yyzkeegtQdZzfblHTU4BqHAhQw68VtF80EZBvInQw== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794981725; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=7YzBbUvh+YmQiLurxmFfCk1GR6xhELDIM2Yj32PmuSM=; b=2xHwKiNXQp88tVJsUMGlsmIxvOkA/pF0RXvJPWNAsCGh/r/2MNuHPdCLoVG30GkScK17 c2P6T9ue4kxpsn4/ez5+4XffDwSh3ZHPU82Rr0Ra5/UHoM1nLfti7DHUTy8cbOAfJl9ab U53bvMxrdYE5orRLtI3w3lRifvCNpU0022aegIqcQjs6o0sl0GjyijOTIxJyqeNzaOeCV /OViAAXYngXsnVtMg+h5ZTzeypYBafI3dVzz0AsBOmV7MBNC0YN5TXAwA4FahkF9PQTn6 rNzaE5OGEJSUFT9psumqcPS7pTHV6PbohG7ecmMRjQJ6CuxE+U0gHu9J71yI8oaSTSg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HoIYbTIS; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AE54606A32A for ; Wed, 18 Nov 2026 06:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HoIYbTIS Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6BFA1F000C5; Wed, 18 Nov 2026 06:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794981725; bh=7YzBbUvh+YmQiLurxmFfCk1GR6xhELDIM2Yj32PmuSM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HoIYbTISgyXS13am253L6tzK45in91AC9P3BEGG+OKaGCCoN9o5IORjK/HmkEmqdZ yCH3dpdbuyTGMzluebQc5EbGtYLO67dTXwc1uqrdNtuAKl9Qgkt0uYWy1pTzxhKFSp OL1g06Fomg/jDANHPVa5XL20A2cnBGWtK9aDFtxt4CLL8e1ZSsKUx3dde/PjbZvqX4 JNVrXM2JNKm2HitYP89tF/ZHGBkM1m9g6DsMD/4tAxwy7hEeZIGDrpiuLoedpoUiZ0 RkOUcgEIj+zZe++T6Zn6OzZKA/tWdbymmtOIONbdGFjHC8LNozP5Q2Qa9FfS/e8kHb 4ty4KbLSIYxVA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure Reply-To: sashiko-reviews@lists.linux.dev To: "Jason Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com> References: <20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com> <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 06:02:04 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [Low] phy: rockchip-samsung-dcphy: missing Fixes trailer for PLL lock unwind -- commit 6c4b17f61ef61ed9fbe1eb97449b228aaba3f155 Author: Jason Yang > phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure > > samsung_mipi_dphy_power_on() returns on a PLL lock timeout with PLL_EN > set and m_phy_rst still asserted, and the PHY core does not call > power_off after a failed power_on. > > Today the APB reset at the start of the next power_on cleans this up. > > A later change moves that reset to runtime resume, so the leftover > PLL_EN would stay set, and regmap_update_bits() would not even write > it again. > > Unwind the power-on before returning the error. > > Reported-by: Sashiko > Closes: https://lore.kernel.org/linux-phy/sashiko-outbox-174059@kernel.or= g/ > Signed-off-by: Jason Yang > Reviewed-by: Michael Riesch > Tested-by: Quentin Schulz # RK3588 Tiger CSI1 = 2-lane IMX219, CSI0 2-lane OV5675+DSI [Severity: Low] This fixes the incomplete error path in samsung_mipi_dphy_power_on(). Should this include: Fixes: b2a1a2ae7818 ("phy: rockchip: Add Samsung MIPI D-/C-PHY driver") --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118-dcphy-rx-v= 1-v7-0-8de1adac3a74@gmail.com?part=3D3 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD340606A31C for ; Wed, 18 Nov 2026 06:02:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=Abyup2EI; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=HoIYbTIS DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=hwurI8f754lfk24f4PbTcobeIYPiMXZ9KqeQ6rcCLV0=; b=Abyup2EIvBjcwkij5hypRf+kTd x1h1mUogKU+E8GIsPCIBnjodRyq3ZERiaaQ/ebNUoRg+/RjfZ9tEtIJlxOFePuPnjoNM9w8vDhTJv lPACR2taLOjFY4Xr6yhJZIkqoev1guNQ4e6KuaN7fXNbUt1DnrpknOmOl9GiAqa5dTcp9BRlZKXJ8 FRenO0X5sULDdRaGzbwmNH9nRXQWfd04rcPVwK8l1fYnirhTBRAPYxmcyZorKoBTaYrflWWRsyHjl lqdVtHzuKbbSqYGoAhvskIMxraWrimvvFKEjli0Z08LtjdlypZhWxs+WaaZOtG/ZA9W1BhwBHN6el L9wYAOrQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYkC-00000007pQ2-2T04; Wed, 18 Nov 2026 06:02:08 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYkA-00000007pPp-3QiR for linux-phy@lists.infradead.org; Wed, 18 Nov 2026 06:02:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 6D10761878; Wed, 18 Nov 2026 06:02:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B6BFA1F000C5; Wed, 18 Nov 2026 06:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794981725; bh=7YzBbUvh+YmQiLurxmFfCk1GR6xhELDIM2Yj32PmuSM=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=HoIYbTISgyXS13am253L6tzK45in91AC9P3BEGG+OKaGCCoN9o5IORjK/HmkEmqdZ yCH3dpdbuyTGMzluebQc5EbGtYLO67dTXwc1uqrdNtuAKl9Qgkt0uYWy1pTzxhKFSp OL1g06Fomg/jDANHPVa5XL20A2cnBGWtK9aDFtxt4CLL8e1ZSsKUx3dde/PjbZvqX4 JNVrXM2JNKm2HitYP89tF/ZHGBkM1m9g6DsMD/4tAxwy7hEeZIGDrpiuLoedpoUiZ0 RkOUcgEIj+zZe++T6Zn6OzZKA/tWdbymmtOIONbdGFjHC8LNozP5Q2Qa9FfS/e8kHb 4ty4KbLSIYxVA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v7 3/9] phy: rockchip-samsung-dcphy: Unwind power-on on PLL lock failure To: "Jason Yang" Cc: linux-phy@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, vkoul@kernel.org, neil.armstrong@linaro.org, olteanv@gmail.com In-Reply-To: <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com> References: <20261118-dcphy-rx-v1-v7-0-8de1adac3a74@gmail.com> <20261118-dcphy-rx-v1-v7-3-8de1adac3a74@gmail.com> Date: Wed, 18 Nov 2026 06:02:04 +0000 X-BeenThere: linux-phy@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux Phy Mailing list List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-phy" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MSBwb3RlbnRpYWwKaXNzdWUgdG8gY29uc2lkZXI6Ci0gW0xvd10gcGh5OiByb2NrY2hpcC1zYW1z dW5nLWRjcGh5OiBtaXNzaW5nIEZpeGVzIHRyYWlsZXIgZm9yIFBMTCBsb2NrCiAgdW53aW5kCi0t Cgpjb21taXQgNmM0YjE3ZjYxZWY2MWVkOWZiZTFlYjk3NDQ5YjIyOGFhYmEzZjE1NQpBdXRob3I6 IEphc29uIFlhbmcgPGphc29uOTgxNjZAZ21haWwuY29tPgoKPiBwaHk6IHJvY2tjaGlwLXNhbXN1 bmctZGNwaHk6IFVud2luZCBwb3dlci1vbiBvbiBQTEwgbG9jayBmYWlsdXJlCj4KPiBzYW1zdW5n X21pcGlfZHBoeV9wb3dlcl9vbigpIHJldHVybnMgb24gYSBQTEwgbG9jayB0aW1lb3V0IHdpdGgg UExMX0VOCj4gc2V0IGFuZCBtX3BoeV9yc3Qgc3RpbGwgYXNzZXJ0ZWQsIGFuZCB0aGUgUEhZIGNv cmUgZG9lcyBub3QgY2FsbAo+IHBvd2VyX29mZiBhZnRlciBhIGZhaWxlZCBwb3dlcl9vbi4KPgo+ IFRvZGF5IHRoZSBBUEIgcmVzZXQgYXQgdGhlIHN0YXJ0IG9mIHRoZSBuZXh0IHBvd2VyX29uIGNs ZWFucyB0aGlzIHVwLgo+Cj4gQSBsYXRlciBjaGFuZ2UgbW92ZXMgdGhhdCByZXNldCB0byBydW50 aW1lIHJlc3VtZSwgc28gdGhlIGxlZnRvdmVyCj4gUExMX0VOIHdvdWxkIHN0YXkgc2V0LCBhbmQg cmVnbWFwX3VwZGF0ZV9iaXRzKCkgd291bGQgbm90IGV2ZW4gd3JpdGUKPiBpdCBhZ2Fpbi4KPgo+ IFVud2luZCB0aGUgcG93ZXItb24gYmVmb3JlIHJldHVybmluZyB0aGUgZXJyb3IuCj4KPiBSZXBv cnRlZC1ieTogU2FzaGlrbyA8c2FzaGlrby1ib3RAa2VybmVsLm9yZz4KPiBDbG9zZXM6IGh0dHBz Oi8vbG9yZS5rZXJuZWwub3JnL2xpbnV4LXBoeS9zYXNoaWtvLW91dGJveC0xNzQwNTlAa2VybmVs Lm9yZy8KPiBTaWduZWQtb2ZmLWJ5OiBKYXNvbiBZYW5nIDxqYXNvbjk4MTY2QGdtYWlsLmNvbT4K PiBSZXZpZXdlZC1ieTogTWljaGFlbCBSaWVzY2ggPG1pY2hhZWwucmllc2NoQGNvbGxhYm9yYS5j b20+Cj4gVGVzdGVkLWJ5OiBRdWVudGluIFNjaHVseiA8cXVlbnRpbi5zY2h1bHpAY2hlcnJ5LmRl PiAjIFJLMzU4OCBUaWdlciBDU0kxIDItbGFuZSBJTVgyMTksIENTSTAgMi1sYW5lIE9WNTY3NStE U0kKCltTZXZlcml0eTogTG93XQpUaGlzIGZpeGVzIHRoZSBpbmNvbXBsZXRlIGVycm9yIHBhdGgg aW4gc2Ftc3VuZ19taXBpX2RwaHlfcG93ZXJfb24oKS4KU2hvdWxkIHRoaXMgaW5jbHVkZToKCiAg Rml4ZXM6IGIyYTFhMmFlNzgxOCAoInBoeTogcm9ja2NoaXA6IEFkZCBTYW1zdW5nIE1JUEkgRC0v Qy1QSFkgZHJpdmVyIikKCi0tIApTYXNoaWtvIEFJIHJldmlldyDCtyBodHRwczovL3Nhc2hpa28u ZGV2LyMvcGF0Y2hzZXQvMjAyNjExMTgtZGNwaHktcngtdjEtdjctMC04ZGUxYWRhYzNhNzRAZ21h aWwuY29tP3BhcnQ9MwoKLS0gCmxpbnV4LXBoeSBtYWlsaW5nIGxpc3QKbGludXgtcGh5QGxpc3Rz LmluZnJhZGVhZC5vcmcKaHR0cHM6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGlu Zm8vbGludXgtcGh5Cg==