From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4CC12606A325 for ; Wed, 18 Nov 2026 06:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=0Kvgnb1b; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XGQ8aJ16 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Cc:Reply-To: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date :Content-Transfer-Encoding:Content-Type:References:In-Reply-To:To:Subject: From:Message-ID:MIME-Version:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=7pawrZRlYVDLwnVc36mchILpwWtc+qvWtadmaH7lhXg=; b=0Kvgnb1bj9EFj+lV6LozUd0h83 Vrnot279GzUshFw8IhVtplf+ek7Zz0R8nG160z/YUw3tUHm9GNAsgBUUjwqqJyJsv6Nsl2ZaiLDLz +vxuSvLMQhu31LAHz17kH/3xJCUgV8uwLkhwDRxLnWl/0Zq5ZK4xxNrTcAD4yxJyFUnC9e6b1EPsf /z7WzBf/TOVuaY99+Rm9eovcyClHorVIa8NzGxneLnf+uza1RzU34H25htZc0w+SRJ3z/Sx9cFRkv JxsE5cx83DuMU9Lw8I5u9yYFYrDWm8k00lBX09jFbbEmwak6gw7uhBrwM3ktOtQEu53quAi10WYvs Y7lusfzQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYuc-00000007qVf-34S9; Wed, 18 Nov 2026 06:12:54 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTYua-00000007qVV-3evK for kexec@lists.infradead.org; Wed, 18 Nov 2026 06:12:53 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 425E461878; Wed, 18 Nov 2026 06:12:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C6D1F000C5; Wed, 18 Nov 2026 06:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794982371; bh=7pawrZRlYVDLwnVc36mchILpwWtc+qvWtadmaH7lhXg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XGQ8aJ167ql8RT2XJgaOf0Eq6Q/gT8pXbnfVX5Ukky44PZgq4eSgl2nZ6ybWVCrJU tddgUSUIbF0RlDcndQPmxC3KPAY1AX+dcSVxpdYzs1tsFLBf0m/NvQ45mJzKYnBhG9 bwKJiomH6Y6qavZ0/fN5fVOv6mkT3BnWeOBMwV/nMffn+XgN5gNpk6jvxcJ5Ox72Um Y1D8Qr3ZgnA/NX8tg+1IJ2rddYnGAMOdpFvGh0teUlhMfhHlOudDj/UF1SkaGd76fT KccOZv+SBIUrBDygTeqJV8qKJ1jyhx6hy8gIXFAuW4SGRVUwQtsikEySaxeheTu5l5 1RWVfoLjmwLBw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers To: "Zack Rusin" , "Andrew Morton" , "Petr Mladek" , "Baoquan He" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Dave Young" In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 06:12:48 +0000 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Cc: "Michael S. Tsirkin" , Kees Cook , Dave Hansen , Stephen Brennan , Bo Gan , "H. Peter Anvin" , Jonathan Corbet , Brennan Lamoreaux , x86@kernel.org, Joel Granados , Alexey Makhalov , Eugenio Perez , Ingo Molnar , bcm-kernel-feedback-list@broadcom.com, Ajay Kaher , Bradley Morgan , John Ogness , virtualization@lists.linux.dev, Steven Rostedt , Maaz Mombasawala , Borislav Petkov , Shuah Khan , Michael Kelley , Randy Dunlap , kexec@lists.infradead.org, Ian Forbes , Sergey Senozhatsky , Thomas Gleixner Sender: "kexec" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > VMware accepts a structured guest-crash event, but a host configured with > backdoor.coredumpOnCrash may terminate the VM before the hypercall > returns. Keep this event separate from the log sender, which runs > earlier in panic. >=20 > Register a panic-only kmsg dumper with late_initcall_sync(), after built-= in > dumpers registered by then. Skip the event while a crash kernel is loaded > so the host cannot terminate the guest before kdump saves its vmcore. >=20 > Issue the event at most once. With CONFIG_PRINTK=3Dn, use a late INT_MIN > panic notifier. An unexpected dumper registration failure with printk > enabled leaves reporting disabled rather than overtaking working dumpers. >=20 > Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@= broadcom.com > Co-developed-by: Brennan Lamoreaux > Signed-off-by: Brennan Lamoreaux > Co-developed-by: Alexey Makhalov > Signed-off-by: Alexey Makhalov > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1794980455.gi= t.zack.rusin@broadcom.com?part=3D4 From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794982371; b=TMX1ZsGmwuGsDyyOPRrNMmWzKDuTLPFHvVfGxPmccQJdhluLIObXbsnAPrF2hAuuPzAC yxWv8Ser3lDcsxVd16KyQZOjs9cO64RVpNyPQnUztX6z+/RxPX3D2xKS7bEspkiV89GfN AjUIbJdcv3cMCrEuFhdjnwsKYycyuECWMkjGwyoB9YrWZtS/Q/ZzHkOjIaWp48seX4/7X lld5Wxr5wSQhdEDL7vy4H7F/F7ucsqdw188ENdb8+3FtI0MM1YNf36djTPNHMVadtCONl wFo+pPNWOS7cookDOs0mc6IV1PTyomJJDGOdezFaJ9IMRTkpTY20kJItljgnLgL9Log== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794982371; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=7pawrZRlYVDLwnVc36mchILpwWtc+qvWtadmaH7lhXg=; b=ZQIa/gjiN8EtQ4Nmpoeh9wkSEbWhKxWWkMA345hdE8fYCYL0wZxC7kCLjhywlj9eL9hD 8P1W2GKV7bXjJEydogQDRqlfrIDpK2HZrkFggY/T/gcWT5j3w+aBjAGP8olq8ynoXqpI8 xDtjPhQEpVcRbjfQEqQtb3BDurNPSRKDcnvm6st/gl675ir7wr5rX2WAagtvgZKcewhk8 cUVjfWRLEAOAC/sMS12+yLXIvwSuFts1ugnA6SQEqKwBhQBHMwQ/edVDJAZCrrTXOQvht BzOfib5znGuRgJBbFo7NEkokNP2vcWhLAIARdRAe59LusAwLVUvE/wkKGnZd3g37CVw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XGQ8aJ16; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 377D2606A33A for ; Wed, 18 Nov 2026 06:12:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=XGQ8aJ16 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 40C6D1F000C5; Wed, 18 Nov 2026 06:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794982371; bh=7pawrZRlYVDLwnVc36mchILpwWtc+qvWtadmaH7lhXg=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=XGQ8aJ167ql8RT2XJgaOf0Eq6Q/gT8pXbnfVX5Ukky44PZgq4eSgl2nZ6ybWVCrJU tddgUSUIbF0RlDcndQPmxC3KPAY1AX+dcSVxpdYzs1tsFLBf0m/NvQ45mJzKYnBhG9 bwKJiomH6Y6qavZ0/fN5fVOv6mkT3BnWeOBMwV/nMffn+XgN5gNpk6jvxcJ5Ox72Um Y1D8Qr3ZgnA/NX8tg+1IJ2rddYnGAMOdpFvGh0teUlhMfhHlOudDj/UF1SkaGd76fT KccOZv+SBIUrBDygTeqJV8qKJ1jyhx6hy8gIXFAuW4SGRVUwQtsikEySaxeheTu5l5 1RWVfoLjmwLBw== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v4 4/4] x86/vmware: Report guest crashes after kmsg dumpers Reply-To: sashiko-reviews@lists.linux.dev To: "Zack Rusin" , "Andrew Morton" , "Petr Mladek" , "Baoquan He" , "Mike Rapoport" , "Pasha Tatashin" , "Pratyush Yadav" , "Dave Young" Cc: "Borislav Petkov" , "Ajay Kaher" , "Alexey Makhalov" , x86@kernel.org, "Joel Granados" , "Thomas Gleixner" , "Ingo Molnar" , "Dave Hansen" , "H. Peter Anvin" , virtualization@lists.linux.dev, bcm-kernel-feedback-list@broadcom.com, "John Ogness" , "Steven Rostedt" , "Sergey Senozhatsky" , "Kees Cook" , "Jonathan Corbet" , "Bo Gan" , "Brennan Lamoreaux" , kexec@lists.infradead.org, "Guilherme G. Piccoli" , "Maaz Mombasawala" , "Shuah Khan" , "Randy Dunlap" , "Stephen Brennan" , "Michael Kelley" , "Ian Forbes" , "Bradley Morgan" , "Michael S. Tsirkin" , "Eugenio Perez" In-Reply-To: References: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 06:12:48 +0000 X-Mailing-List: virtualization@lists.linux.dev List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list > VMware accepts a structured guest-crash event, but a host configured with > backdoor.coredumpOnCrash may terminate the VM before the hypercall > returns. Keep this event separate from the log sender, which runs > earlier in panic. >=20 > Register a panic-only kmsg dumper with late_initcall_sync(), after built-= in > dumpers registered by then. Skip the event while a crash kernel is loaded > so the host cannot terminate the guest before kdump saves its vmcore. >=20 > Issue the event at most once. With CONFIG_PRINTK=3Dn, use a late INT_MIN > panic notifier. An unexpected dumper registration failure with printk > enabled leaves reporting disabled rather than overtaking working dumpers. >=20 > Link: https://lore.kernel.org/r/20260309235250.2611115-4-alexey.makhalov@= broadcom.com > Co-developed-by: Brennan Lamoreaux > Signed-off-by: Brennan Lamoreaux > Co-developed-by: Alexey Makhalov > Signed-off-by: Alexey Makhalov > Signed-off-by: Zack Rusin Sashiko has reviewed this patch and found no issues. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/cover.1794980455.gi= t.zack.rusin@broadcom.com?part=3D4