From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794987645; b=WsmgZCIG7TQ9TOkGR3dU9kw7SHdrrl8RGIbcjDwaiNyVprNIZDL2Vjcxghp6f3gWL8mh +6mxhb7RX2Y1T0QcJhV/3af/FI3HG4ZTtSdrwP2TyG337eTX4OMAbghROKdqNwkel2QRH 5j7nJko0vWZY4jsudDdF8lcA0irXjQ7SWDmcKL/sH85sHpxcOvIlBwqp9cRPp1OqqKVDC USLUAh8YCgRjDLtlFZipGlFg9yMoCOaElJ6F271yfECDAMbIOMOJnvwx9daHXzVqUZxZv OXX2LkmUlGePckTNOR8TXbIhqd/cjny3gDEpLcw711fl+prwaV5/Z45sPMwgtQce+gg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794987645; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=fwcTKS4wj4k6U6GuJD2rx7VTQUh26juZW+bkpxx6fFc=; b=ocJkpSgsOpDEJyLEZhKI62BoB9cuKeKfz27kZvu3bKCA9VTPvEoo3a2Q7o91/xH8Bgre YGhnotmrsFbQnAsaMWlUoRnz9XiPi9dUpCC6G8Z1Ov/a9xRYj4+u+VgdUCmLxCKVCewjk A3ihwh6NWTnlgvIuaOSR2qDcPliuJg/te9J7+D4HbLCSKlXbuuBe979/jIxKuTRARkLl3 YqrblA6vALV8WiA6WFwN2kTQxpIEYx3SPciAeWcKSpjsQT8Udcl751Lq3Ha6GazDFYfX8 tmykUBU5Bu5qTyEtSKyqEGgSeJhXzU9qm05MyNaTC5AOAd0oh/fShIorXBLPVR/rWkg== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KGk1klND; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E1FC606A31C for ; Wed, 18 Nov 2026 07:40:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KGk1klND Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749F61F000C4; Wed, 18 Nov 2026 07:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794987644; bh=fwcTKS4wj4k6U6GuJD2rx7VTQUh26juZW+bkpxx6fFc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KGk1klNDRPdTEvZetYbAqPP9OvCM8p7hO+NiZwDYQqPSa2yFejbupZwhp5N+O9cL8 AqGJJCXwCxX7U4AYNTZb/zT0MEaqFRAMMkbozOGVQ9030AbwUGTUH+ZOIl9RI0EDgA bt0Krb4hHXGSVuEr9XI6OMAkdZJJICeSm0mk+dfYo3jLXjYBrGZ9AR12TLJOGHaqb+ BSvJHSJ1x2z7QfruiWazNJjBX9346Nih4xs9s9RUvYDe0j0TQLhfxudmmwRaut/7mn SoPKuVnJZcQlFNeNcGXSuVuok95IRFCtbA0G4l4LrVPt+vNQFbRsjRGUdWaWjsb1vL n7a8sgb+oK+aA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261118-a9-i2c-v11-2-68a3e79ff43a@amlogic.com> References: <20261118-a9-i2c-v11-0-68a3e79ff43a@amlogic.com> <20261118-a9-i2c-v11-2-68a3e79ff43a@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 07:40:43 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] i2c: amlogic-a9: transfer started before IRQ setup in aml_i2c_do_start() - [Medium] i2c: amlogic-a9: stale irq_state and edge IRQ miss in aml_i2c_irq() -- commit f0387049df50978b17672f0e9a9fea887c6cbc34 Author: Junyi Zhao i2c: amlogic: Add Amlogic A9 I2C controller driver This commit adds a driver for the I2C controller on Amlogic A9 SoCs along with Kconfig, Makefile, and MAINTAINERS entries. > diff --git a/drivers/i2c/busses/i2c-amlogic-a9.c b/drivers/i2c/busses/i2c= -amlogic-a9.c > new file mode 100644 > index 0000000000000..db1a081b2a148 > --- /dev/null > +++ b/drivers/i2c/busses/i2c-amlogic-a9.c > @@ -0,0 +1,428 @@ [ ... ] > +static irqreturn_t aml_i2c_irq(int irqno, void *dev_id) > +{ > + struct aml_i2c *i2c =3D dev_id; > + u8 *buf =3D NULL; > + u32 rd_len, i; > + u32 rd_val; > + u32 irq_state; > + > + guard(spinlock)(&i2c->lock); > + irq_state =3D readl(i2c->regs + REG_CFG_IRQ_STATE); > + if (i2c->state =3D=3D A9_STATE_IDLE) { > + dev_warn(i2c->dev, "i2c irq triggered abnormally, irq_state:0x%x,irq_e= n:0x%x\n", > + irq_state, readl(i2c->regs + REG_CFG_IRQ_ENABLE)); > + goto irq_trans_out; > + } > + > + if (irq_state & A9_TRANS_ERROR) { > + i2c->error =3D -ENXIO; > + goto complete_irq_out; > + } > + > + switch (i2c->state) { > + case A9_STATE_READ: > + buf =3D i2c->msg->buf; > + rd_len =3D min(i2c->msg->len - i2c->pos, A9_I2C_FIFO_DEPTH); > + for (i =3D 0; i < rd_len; i++) { > + rd_val =3D readl(i2c->regs + REG_CFG_RX); > + buf[i2c->pos++] =3D rd_val & TX_RX_DATA; > + } > + /* Rx must clear thresh after read fifo */ > + clear_irq_status(i2c, A9_RX_THRESH_READ); > + break; > + case A9_STATE_WRITE: > + aml_i2c_prepare_xfer(i2c, A9_FIFO_FILL_HALF); > + if (i2c->pos =3D=3D i2c->msg->len) > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_TX_THRESH_WRITE, 0); > + /* Tx must clear thresh after write fifo */ > + clear_irq_status(i2c, A9_TX_THRESH_WRITE); > + break; > + default: > + break; > + } > + > + if (!(irq_state & A9_TRANS_DONE) || > + (i2c->state =3D=3D A9_STATE_READ && i2c->pos < i2c->msg->len)) > + return IRQ_HANDLED; [Severity: Medium] Can multi-chunk transfers miss the completion interrupt and time out when A9_PHY_DONE asserts before clear_irq_status() clears the threshold bit? The devicetree binding specifies a rising-edge interrupt (IRQ_TYPE_EDGE_RISING), which needs the controller's interrupt output to drop to 0 and transition back to 1 to latch a new interrupt in the GIC: Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml: interrupts =3D <0 164 1>; On a 64-byte read, the 32nd byte of the second chunk asserts A9_RX_THRESH_READ as soon as it enters the RX FIFO, before the NACK and STOP condition finish on the bus. If A9_PHY_DONE asserts in REG_CFG_IRQ_STATE while the loop is reading the 32 bytes from REG_CFG_RX, clearing A9_RX_THRESH_READ afterward leaves the interrupt line continuously high without generating a new rising edge. Because irq_state was sampled only once at entry, the check against A9_TRANS_DONE sees the stale value without A9_PHY_DONE and returns IRQ_HANDLED without completing i2c->done, hanging wait_for_completion_timeout() for 500 ms. Similarly, if both A9_RX_THRESH_READ and A9_PHY_DONE are already set at entry when more than 32 bytes remain to be read, aml_i2c_irq() reads only 32 bytes, clears only A9_RX_THRESH_READ, and returns early because i2c->pos < i2c->msg->len. With A9_PHY_DONE still asserted and fewer than 32 tail bytes left in the FIFO, the interrupt output stays high and no further edge interrupt fires to drain the rest of the message. > +complete_irq_out: > + i2c->state =3D A9_STATE_IDLE; > + reset_fifo_pos(i2c); > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_RX_THRESH_READ | A9_TX_THR= ESH_WRITE, 0); > + complete(&i2c->done); > +irq_trans_out: > + clear_irq_status(i2c, IRQ_ALL_MASK); > + > + return IRQ_HANDLED; > +} > + > +static void aml_i2c_do_start(struct aml_i2c *i2c, struct i2c_msg *msg) > +{ > + unsigned int reg_val; > + unsigned int trans_len; > + > + trans_len =3D msg->len; > + reg_val =3D (unsigned int)(((msg->addr & 0x7f) << START_SADDR_SHIFT) | > + ((msg->flags & I2C_M_RD) ? START_READ : 0) | > + ((trans_len & 0xfff) << START_LEN_SHIFT) | START_START); > + aml_i2c_set_mask(i2c, REG_CFG_START, > + START_START | START_SLAVE_ADDR | START_READ | START_LEN, reg_val); > + clear_irq_status(i2c, IRQ_ALL_MASK); > + /* enable thresh mode */ > + if (trans_len > A9_I2C_FIFO_DEPTH) { > + reg_val =3D (msg->flags & I2C_M_RD) ? A9_RX_THRESH_READ : A9_TX_THRESH= _WRITE; > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, > + A9_RX_THRESH_READ | A9_TX_THRESH_WRITE, reg_val); > + } > +} [Severity: Medium] Can clear_irq_status(i2c, IRQ_ALL_MASK) wipe out status bits for the transfer that START_START just launched? aml_i2c_do_start() writes START_START to REG_CFG_START while A9_ENABLE_IRQ_BIT (A9_NCK_ERROR | A9_PHY_DONE) is already enabled in REG_CFG_IRQ_ENABLE, and only then clears IRQ_ALL_MASK and enables the threshold interrupts. If the CPU is delayed between those MMIO writes (for example under CONFIG_PREEMPT_RT or vCPU preemption) and an address NACK or short transfer completes in the meantime: aml_i2c_xfer_msg() aml_i2c_do_start() aml_i2c_set_mask(..., REG_CFG_START, ..., START_START) /* hardware finishes or NACKs, asserting A9_NCK_ERROR / A9_PHY_DONE */ clear_irq_status(i2c, IRQ_ALL_MASK) <-- clears new status bits unlock(&i2c->lock) aml_i2c_irq() irq_state =3D readl(... + REG_CFG_IRQ_STATE) /* reads 0 */ /* misses A9_TRANS_ERROR, reads garbage from REG_CFG_RX */ if (!(irq_state & A9_TRANS_DONE) || ...) return IRQ_HANDLED; <-- never completes i2c->done wait_for_completion_timeout() then stalls for 500 ms and fails with -ETIMEDOUT. Clearing REG_CFG_IRQ_STATE and enabling the threshold interrupts before setting START_START avoids this race. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118-a9-i2c-v11= -0-68a3e79ff43a@amlogic.com?part=3D2 From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EF062606A31C for ; Wed, 18 Nov 2026 07:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=yQGdOUFG; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=KGk1klND DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=bDKSreFFMI6a89UEcl5zbTXGg8jyPdn2vE1ABNGvPU4=; b=yQGdOUFGA9cFTm8Ejg8MCwpgtg 5HbAZxFlXR9LFnBLtliP+SKmGlTghxPzAsEMRI0mEkTGEIOO16KznRYSd/Ux8h8yLCH7oAhzsWe72 vxSQ29mijA+/l/Z9G8wW1G5ZydvMTkIDpQUEqUCGcQbXz3agWdmru+U8F4s/EMXUVgEOQiQCW/w4J 0wp0VQPVwr0BqAfs93MdllB+POqcbagHWVeitARxN32BNOTsiGMPnYfAr15n/MYRHzBpoNhPVTw8U ATR551JtJ8oyYjBgp4Dna6g8BCPb5u+/neBW8fi0zPy/5wPJO0E9UDLjno42lXYHUY8vsU4bDDAfz 9vwy9izA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTaHf-0000000837s-39gd; Wed, 18 Nov 2026 07:40:47 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTaHe-00000008372-14m7 for linux-amlogic@lists.infradead.org; Wed, 18 Nov 2026 07:40:46 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 0FC7360DE7; Wed, 18 Nov 2026 07:40:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 749F61F000C4; Wed, 18 Nov 2026 07:40:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794987644; bh=fwcTKS4wj4k6U6GuJD2rx7VTQUh26juZW+bkpxx6fFc=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=KGk1klNDRPdTEvZetYbAqPP9OvCM8p7hO+NiZwDYQqPSa2yFejbupZwhp5N+O9cL8 AqGJJCXwCxX7U4AYNTZb/zT0MEaqFRAMMkbozOGVQ9030AbwUGTUH+ZOIl9RI0EDgA bt0Krb4hHXGSVuEr9XI6OMAkdZJJICeSm0mk+dfYo3jLXjYBrGZ9AR12TLJOGHaqb+ BSvJHSJ1x2z7QfruiWazNJjBX9346Nih4xs9s9RUvYDe0j0TQLhfxudmmwRaut/7mn SoPKuVnJZcQlFNeNcGXSuVuok95IRFCtbA0G4l4LrVPt+vNQFbRsjRGUdWaWjsb1vL n7a8sgb+oK+aA== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v11 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261118-a9-i2c-v11-2-68a3e79ff43a@amlogic.com> References: <20261118-a9-i2c-v11-0-68a3e79ff43a@amlogic.com> <20261118-a9-i2c-v11-2-68a3e79ff43a@amlogic.com> Date: Wed, 18 Nov 2026 07:40:43 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkyYzogYW1sb2dpYy1h OTogdHJhbnNmZXIgc3RhcnRlZCBiZWZvcmUgSVJRIHNldHVwIGluCiAgYW1sX2kyY19kb19zdGFy dCgpCi0gW01lZGl1bV0gaTJjOiBhbWxvZ2ljLWE5OiBzdGFsZSBpcnFfc3RhdGUgYW5kIGVkZ2Ug SVJRIG1pc3MgaW4KICBhbWxfaTJjX2lycSgpCi0tCgpjb21taXQgZjAzODcwNDlkZjUwOTc4YjE3 NjcyZjBlOWE5ZmVhODg3YzZjYmMzNApBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1s b2dpYy5jb20+CgppMmM6IGFtbG9naWM6IEFkZCBBbWxvZ2ljIEE5IEkyQyBjb250cm9sbGVyIGRy aXZlcgoKVGhpcyBjb21taXQgYWRkcyBhIGRyaXZlciBmb3IgdGhlIEkyQyBjb250cm9sbGVyIG9u IEFtbG9naWMgQTkgU29DcyBhbG9uZwp3aXRoIEtjb25maWcsIE1ha2VmaWxlLCBhbmQgTUFJTlRB SU5FUlMgZW50cmllcy4KCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvaTJjL2J1c3Nlcy9pMmMtYW1s b2dpYy1hOS5jIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1hbWxvZ2ljLWE5LmMKPiBuZXcgZmls ZSBtb2RlIDEwMDY0NAo+IGluZGV4IDAwMDAwMDAwMDAwMDAuLmRiMWEwODFiMmExNDgKPiAtLS0g L2Rldi9udWxsCj4gKysrIGIvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1hbWxvZ2ljLWE5LmMKPiBA QCAtMCwwICsxLDQyOCBAQAoKWyAuLi4gXQoKPiArc3RhdGljIGlycXJldHVybl90IGFtbF9pMmNf aXJxKGludCBpcnFubywgdm9pZCAqZGV2X2lkKQo+ICt7Cj4gKwlzdHJ1Y3QgYW1sX2kyYyAqaTJj ID0gZGV2X2lkOwo+ICsJdTggKmJ1ZiA9IE5VTEw7Cj4gKwl1MzIgcmRfbGVuLCBpOwo+ICsJdTMy IHJkX3ZhbDsKPiArCXUzMiBpcnFfc3RhdGU7Cj4gKwo+ICsJZ3VhcmQoc3BpbmxvY2spKCZpMmMt PmxvY2spOwo+ICsJaXJxX3N0YXRlID0gcmVhZGwoaTJjLT5yZWdzICsgUkVHX0NGR19JUlFfU1RB VEUpOwo+ICsJaWYgKGkyYy0+c3RhdGUgPT0gQTlfU1RBVEVfSURMRSkgewo+ICsJCWRldl93YXJu KGkyYy0+ZGV2LCAiaTJjIGlycSB0cmlnZ2VyZWQgYWJub3JtYWxseSwgaXJxX3N0YXRlOjB4JXgs aXJxX2VuOjB4JXhcbiIsCj4gKwkJCSBpcnFfc3RhdGUsIHJlYWRsKGkyYy0+cmVncyArIFJFR19D RkdfSVJRX0VOQUJMRSkpOwo+ICsJCWdvdG8gaXJxX3RyYW5zX291dDsKPiArCX0KPiArCj4gKwlp ZiAoaXJxX3N0YXRlICYgQTlfVFJBTlNfRVJST1IpIHsKPiArCQlpMmMtPmVycm9yID0gLUVOWElP Owo+ICsJCWdvdG8gY29tcGxldGVfaXJxX291dDsKPiArCX0KPiArCj4gKwlzd2l0Y2ggKGkyYy0+ c3RhdGUpIHsKPiArCWNhc2UgQTlfU1RBVEVfUkVBRDoKPiArCQlidWYgPSBpMmMtPm1zZy0+YnVm Owo+ICsJCXJkX2xlbiA9IG1pbihpMmMtPm1zZy0+bGVuIC0gaTJjLT5wb3MsIEE5X0kyQ19GSUZP X0RFUFRIKTsKPiArCQlmb3IgKGkgPSAwOyBpIDwgcmRfbGVuOyBpKyspIHsKPiArCQkJcmRfdmFs ID0gcmVhZGwoaTJjLT5yZWdzICsgUkVHX0NGR19SWCk7Cj4gKwkJCWJ1ZltpMmMtPnBvcysrXSA9 IHJkX3ZhbCAmIFRYX1JYX0RBVEE7Cj4gKwkJfQo+ICsJCS8qIFJ4IG11c3QgY2xlYXIgdGhyZXNo IGFmdGVyIHJlYWQgZmlmbyAqLwo+ICsJCWNsZWFyX2lycV9zdGF0dXMoaTJjLCBBOV9SWF9USFJF U0hfUkVBRCk7Cj4gKwkJYnJlYWs7Cj4gKwljYXNlIEE5X1NUQVRFX1dSSVRFOgo+ICsJCWFtbF9p MmNfcHJlcGFyZV94ZmVyKGkyYywgQTlfRklGT19GSUxMX0hBTEYpOwo+ICsJCWlmIChpMmMtPnBv cyA9PSBpMmMtPm1zZy0+bGVuKQo+ICsJCQlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19J UlFfRU5BQkxFLCBBOV9UWF9USFJFU0hfV1JJVEUsIDApOwo+ICsJCS8qIFR4IG11c3QgY2xlYXIg dGhyZXNoIGFmdGVyIHdyaXRlIGZpZm8gKi8KPiArCQljbGVhcl9pcnFfc3RhdHVzKGkyYywgQTlf VFhfVEhSRVNIX1dSSVRFKTsKPiArCQlicmVhazsKPiArCWRlZmF1bHQ6Cj4gKwkJYnJlYWs7Cj4g Kwl9Cj4gKwo+ICsJaWYgKCEoaXJxX3N0YXRlICYgQTlfVFJBTlNfRE9ORSkgfHwKPiArCSAgICAo aTJjLT5zdGF0ZSA9PSBBOV9TVEFURV9SRUFEICYmIGkyYy0+cG9zIDwgaTJjLT5tc2ctPmxlbikp Cj4gKwkJcmV0dXJuIElSUV9IQU5ETEVEOwoKW1NldmVyaXR5OiBNZWRpdW1dCkNhbiBtdWx0aS1j aHVuayB0cmFuc2ZlcnMgbWlzcyB0aGUgY29tcGxldGlvbiBpbnRlcnJ1cHQgYW5kIHRpbWUgb3V0 IHdoZW4KQTlfUEhZX0RPTkUgYXNzZXJ0cyBiZWZvcmUgY2xlYXJfaXJxX3N0YXR1cygpIGNsZWFy cyB0aGUgdGhyZXNob2xkIGJpdD8KClRoZSBkZXZpY2V0cmVlIGJpbmRpbmcgc3BlY2lmaWVzIGEg cmlzaW5nLWVkZ2UgaW50ZXJydXB0CihJUlFfVFlQRV9FREdFX1JJU0lORyksIHdoaWNoIG5lZWRz IHRoZSBjb250cm9sbGVyJ3MgaW50ZXJydXB0IG91dHB1dCB0bwpkcm9wIHRvIDAgYW5kIHRyYW5z aXRpb24gYmFjayB0byAxIHRvIGxhdGNoIGEgbmV3IGludGVycnVwdCBpbiB0aGUgR0lDOgoKRG9j dW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2kyYy9hbWxvZ2ljLGE5LWkyYy55YW1sOgog ICAgaW50ZXJydXB0cyA9IDwwIDE2NCAxPjsKCk9uIGEgNjQtYnl0ZSByZWFkLCB0aGUgMzJuZCBi eXRlIG9mIHRoZSBzZWNvbmQgY2h1bmsgYXNzZXJ0cwpBOV9SWF9USFJFU0hfUkVBRCBhcyBzb29u IGFzIGl0IGVudGVycyB0aGUgUlggRklGTywgYmVmb3JlIHRoZSBOQUNLIGFuZApTVE9QIGNvbmRp dGlvbiBmaW5pc2ggb24gdGhlIGJ1cy4gIElmIEE5X1BIWV9ET05FIGFzc2VydHMgaW4KUkVHX0NG R19JUlFfU1RBVEUgd2hpbGUgdGhlIGxvb3AgaXMgcmVhZGluZyB0aGUgMzIgYnl0ZXMgZnJvbSBS RUdfQ0ZHX1JYLApjbGVhcmluZyBBOV9SWF9USFJFU0hfUkVBRCBhZnRlcndhcmQgbGVhdmVzIHRo ZSBpbnRlcnJ1cHQgbGluZQpjb250aW51b3VzbHkgaGlnaCB3aXRob3V0IGdlbmVyYXRpbmcgYSBu ZXcgcmlzaW5nIGVkZ2UuICBCZWNhdXNlCmlycV9zdGF0ZSB3YXMgc2FtcGxlZCBvbmx5IG9uY2Ug YXQgZW50cnksIHRoZSBjaGVjayBhZ2FpbnN0IEE5X1RSQU5TX0RPTkUKc2VlcyB0aGUgc3RhbGUg dmFsdWUgd2l0aG91dCBBOV9QSFlfRE9ORSBhbmQgcmV0dXJucyBJUlFfSEFORExFRCB3aXRob3V0 CmNvbXBsZXRpbmcgaTJjLT5kb25lLCBoYW5naW5nIHdhaXRfZm9yX2NvbXBsZXRpb25fdGltZW91 dCgpIGZvciA1MDAgbXMuCgpTaW1pbGFybHksIGlmIGJvdGggQTlfUlhfVEhSRVNIX1JFQUQgYW5k IEE5X1BIWV9ET05FIGFyZSBhbHJlYWR5IHNldCBhdAplbnRyeSB3aGVuIG1vcmUgdGhhbiAzMiBi eXRlcyByZW1haW4gdG8gYmUgcmVhZCwgYW1sX2kyY19pcnEoKSByZWFkcyBvbmx5CjMyIGJ5dGVz LCBjbGVhcnMgb25seSBBOV9SWF9USFJFU0hfUkVBRCwgYW5kIHJldHVybnMgZWFybHkgYmVjYXVz ZQppMmMtPnBvcyA8IGkyYy0+bXNnLT5sZW4uICBXaXRoIEE5X1BIWV9ET05FIHN0aWxsIGFzc2Vy dGVkIGFuZCBmZXdlciB0aGFuCjMyIHRhaWwgYnl0ZXMgbGVmdCBpbiB0aGUgRklGTywgdGhlIGlu dGVycnVwdCBvdXRwdXQgc3RheXMgaGlnaCBhbmQgbm8KZnVydGhlciBlZGdlIGludGVycnVwdCBm aXJlcyB0byBkcmFpbiB0aGUgcmVzdCBvZiB0aGUgbWVzc2FnZS4KCj4gK2NvbXBsZXRlX2lycV9v dXQ6Cj4gKwlpMmMtPnN0YXRlID0gQTlfU1RBVEVfSURMRTsKPiArCXJlc2V0X2ZpZm9fcG9zKGky Yyk7Cj4gKwlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19JUlFfRU5BQkxFLCBBOV9SWF9U SFJFU0hfUkVBRCB8IEE5X1RYX1RIUkVTSF9XUklURSwgMCk7Cj4gKwljb21wbGV0ZSgmaTJjLT5k b25lKTsKPiAraXJxX3RyYW5zX291dDoKPiArCWNsZWFyX2lycV9zdGF0dXMoaTJjLCBJUlFfQUxM X01BU0spOwo+ICsKPiArCXJldHVybiBJUlFfSEFORExFRDsKPiArfQo+ICsKPiArc3RhdGljIHZv aWQgYW1sX2kyY19kb19zdGFydChzdHJ1Y3QgYW1sX2kyYyAqaTJjLCBzdHJ1Y3QgaTJjX21zZyAq bXNnKQo+ICt7Cj4gKwl1bnNpZ25lZCBpbnQgcmVnX3ZhbDsKPiArCXVuc2lnbmVkIGludCB0cmFu c19sZW47Cj4gKwo+ICsJdHJhbnNfbGVuID0gbXNnLT5sZW47Cj4gKwlyZWdfdmFsID0gKHVuc2ln bmVkIGludCkoKChtc2ctPmFkZHIgJiAweDdmKSA8PCBTVEFSVF9TQUREUl9TSElGVCkgfAo+ICsJ CQkJKChtc2ctPmZsYWdzICYgSTJDX01fUkQpID8gU1RBUlRfUkVBRCA6IDApIHwKPiArCQkJCSgo dHJhbnNfbGVuICYgMHhmZmYpIDw8IFNUQVJUX0xFTl9TSElGVCkgfCBTVEFSVF9TVEFSVCk7Cj4g KwlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVHX0NGR19TVEFSVCwKPiArCQkJIFNUQVJUX1NUQVJU IHwgU1RBUlRfU0xBVkVfQUREUiB8IFNUQVJUX1JFQUQgfCBTVEFSVF9MRU4sIHJlZ192YWwpOwo+ ICsJY2xlYXJfaXJxX3N0YXR1cyhpMmMsIElSUV9BTExfTUFTSyk7Cj4gKwkvKiBlbmFibGUgdGhy ZXNoIG1vZGUgKi8KPiArCWlmICh0cmFuc19sZW4gPiBBOV9JMkNfRklGT19ERVBUSCkgewo+ICsJ CXJlZ192YWwgPSAobXNnLT5mbGFncyAmIEkyQ19NX1JEKSA/IEE5X1JYX1RIUkVTSF9SRUFEIDog QTlfVFhfVEhSRVNIX1dSSVRFOwo+ICsJCWFtbF9pMmNfc2V0X21hc2soaTJjLCBSRUdfQ0ZHX0lS UV9FTkFCTEUsCj4gKwkJCQkgQTlfUlhfVEhSRVNIX1JFQUQgfCBBOV9UWF9USFJFU0hfV1JJVEUs IHJlZ192YWwpOwo+ICsJfQo+ICt9CgpbU2V2ZXJpdHk6IE1lZGl1bV0KQ2FuIGNsZWFyX2lycV9z dGF0dXMoaTJjLCBJUlFfQUxMX01BU0spIHdpcGUgb3V0IHN0YXR1cyBiaXRzIGZvciB0aGUKdHJh bnNmZXIgdGhhdCBTVEFSVF9TVEFSVCBqdXN0IGxhdW5jaGVkPwoKYW1sX2kyY19kb19zdGFydCgp IHdyaXRlcyBTVEFSVF9TVEFSVCB0byBSRUdfQ0ZHX1NUQVJUIHdoaWxlCkE5X0VOQUJMRV9JUlFf QklUIChBOV9OQ0tfRVJST1IgfCBBOV9QSFlfRE9ORSkgaXMgYWxyZWFkeSBlbmFibGVkIGluClJF R19DRkdfSVJRX0VOQUJMRSwgYW5kIG9ubHkgdGhlbiBjbGVhcnMgSVJRX0FMTF9NQVNLIGFuZCBl bmFibGVzIHRoZQp0aHJlc2hvbGQgaW50ZXJydXB0cy4gIElmIHRoZSBDUFUgaXMgZGVsYXllZCBi ZXR3ZWVuIHRob3NlIE1NSU8gd3JpdGVzCihmb3IgZXhhbXBsZSB1bmRlciBDT05GSUdfUFJFRU1Q VF9SVCBvciB2Q1BVIHByZWVtcHRpb24pIGFuZCBhbiBhZGRyZXNzCk5BQ0sgb3Igc2hvcnQgdHJh bnNmZXIgY29tcGxldGVzIGluIHRoZSBtZWFudGltZToKCmFtbF9pMmNfeGZlcl9tc2coKQogIGFt bF9pMmNfZG9fc3RhcnQoKQogICAgYW1sX2kyY19zZXRfbWFzayguLi4sIFJFR19DRkdfU1RBUlQs IC4uLiwgU1RBUlRfU1RBUlQpCiAgICAvKiBoYXJkd2FyZSBmaW5pc2hlcyBvciBOQUNLcywgYXNz ZXJ0aW5nIEE5X05DS19FUlJPUiAvIEE5X1BIWV9ET05FICovCiAgICBjbGVhcl9pcnFfc3RhdHVz KGkyYywgSVJRX0FMTF9NQVNLKSAgPC0tIGNsZWFycyBuZXcgc3RhdHVzIGJpdHMKICB1bmxvY2so JmkyYy0+bG9jaykKICA8aGFyZGlycT4KICAgIGFtbF9pMmNfaXJxKCkKICAgICAgaXJxX3N0YXRl ID0gcmVhZGwoLi4uICsgUkVHX0NGR19JUlFfU1RBVEUpICAvKiByZWFkcyAwICovCiAgICAgIC8q IG1pc3NlcyBBOV9UUkFOU19FUlJPUiwgcmVhZHMgZ2FyYmFnZSBmcm9tIFJFR19DRkdfUlggKi8K ICAgICAgaWYgKCEoaXJxX3N0YXRlICYgQTlfVFJBTlNfRE9ORSkgfHwgLi4uKQogICAgICAgIHJl dHVybiBJUlFfSEFORExFRDsgIDwtLSBuZXZlciBjb21wbGV0ZXMgaTJjLT5kb25lCgp3YWl0X2Zv cl9jb21wbGV0aW9uX3RpbWVvdXQoKSB0aGVuIHN0YWxscyBmb3IgNTAwIG1zIGFuZCBmYWlscyB3 aXRoCi1FVElNRURPVVQuICBDbGVhcmluZyBSRUdfQ0ZHX0lSUV9TVEFURSBhbmQgZW5hYmxpbmcg dGhlIHRocmVzaG9sZAppbnRlcnJ1cHRzIGJlZm9yZSBzZXR0aW5nIFNUQVJUX1NUQVJUIGF2b2lk cyB0aGlzIHJhY2UuCgotLSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRl di8jL3BhdGNoc2V0LzIwMjYxMTE4LWE5LWkyYy12MTEtMC02OGEzZTc5ZmY0M2FAYW1sb2dpYy5j b20/cGFydD0yCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpsaW51eC1hbWxvZ2ljIG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1h bWxvZ2ljCg==