All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Wenmeng Liu" <wenmeng.liu@oss.qualcomm.com>
Cc: linux-clk@vger.kernel.org, devicetree@vger.kernel.org,
	robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 2/4] clk: qcom: camcc-eliza: Declare icc path dependency for TITAN_TOP_GDSC
Date: Wed, 18 Nov 2026 07:53:32 +0000	[thread overview]
Message-ID: <sashiko-outbox-220374@kernel.org> (raw)
In-Reply-To: <20261118-camcc-fix-v1-2-279d269e343b@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] clk: qcom: camcc-eliza: missing Fixes trailer for TITAN_TOP_GDSC
  icc fix
--

commit c65859d436b87a36e0406115c287548cdbaf30c1
Author: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>

> clk: qcom: camcc-eliza: Declare icc path dependency for TITAN_TOP_GDSC
>
> The TITAN_TOP GDSC hosts the camera NoC (camnoc). If MMNOC is left
> without any client vote while TITAN_TOP is still on, MMNOC attempts a
> power collapse while camnoc may still be active (QACTIVE high). The
> power collapse then gets stuck, and so does the MMNOC BCM, so any later
> bandwidth request through it times out in RPMh:
>
>   Error sending AMC RPMH requests (-110)
>
> Declare the interconnect path for TITAN_TOP_GDSC, so that MMNOC is kept
> voted for as long as the GDSC is on.
>
> Signed-off-by: Wenmeng Liu <wenmeng.liu@oss.qualcomm.com>

[Severity: Low]
This fixes an MMNOC power-collapse hang and RPMh timeout when
cam_cc_titan_top_gdsc is enabled. Should it include:

  Fixes: 115631176f8a ("clk: qcom: camcc: Add support for camera clock controller for Eliza")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-camcc-fix-v1-0-279d269e343b@oss.qualcomm.com?part=2

  reply	other threads:[~2026-11-18  7:53 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:45 [PATCH 0/4] camcc-sm8750/eliza: Declare interconnect dependency for TITAN_TOP_GDSC Wenmeng Liu
2026-11-18  7:45 ` [PATCH 1/4] clk: qcom: camcc-sm8750: Declare icc path " Wenmeng Liu
2026-11-18  7:45 ` [PATCH 2/4] clk: qcom: camcc-eliza: " Wenmeng Liu
2026-11-18  7:53   ` sashiko-bot [this message]
2026-11-18  7:45 ` [PATCH 3/4] arm64: dts: qcom: sm8750: Add interconnects to camcc Wenmeng Liu
2026-11-18  7:45 ` [PATCH 4/4] arm64: dts: qcom: eliza: " Wenmeng Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220374@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=wenmeng.liu@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.