All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Long Zhao" <longzhao@ambarella.com>, linux-gpio@vger.kernel.org
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v15 02/14] gpio: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR
Date: Wed, 18 Nov 2026 07:57:59 +0000	[thread overview]
Message-ID: <sashiko-outbox-220388@kernel.org> (raw)
In-Reply-To: <20261118-cv75-gpio-v15-2-e3c563673fe1@ambarella.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] gpio: regmap: unchecked gpio_regmap_set() in
  gpio_regmap_direction_output()
--

commit a28b7f775ac99e04969880f3336f27205468ad0c
Author: Long Zhao <longzhao@ambarella.com>

gpio: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR

This commit adds the GPIO_REGMAP_QUIRK_SET_AFTER_DIR flag to allow
gpio-regmap controllers to write the output value after configuring the
line direction as output.

> diff --git a/drivers/gpio/gpio-regmap.c b/drivers/gpio/gpio-regmap.c
> index 51b4d69b87403..0a44deae3d01e 100644
> --- a/drivers/gpio/gpio-regmap.c
> +++ b/drivers/gpio/gpio-regmap.c

[ ... ]

> @@ -271,9 +272,17 @@ static int gpio_regmap_direction_output(struct gpio_chip *chip,
>  			return ret;
>  	}
>  
> -	gpio_regmap_set(chip, offset, value);
> +	if (!(gpio->quirks & GPIO_REGMAP_QUIRK_SET_AFTER_DIR))
> +		gpio_regmap_set(chip, offset, value);
>  
> -	return gpio_regmap_set_direction(chip, offset, true);
> +	ret = gpio_regmap_set_direction(chip, offset, true);
> +	if (ret)
> +		return ret;
> +
> +	if (gpio->quirks & GPIO_REGMAP_QUIRK_SET_AFTER_DIR)
> +		gpio_regmap_set(chip, offset, value);
> +
> +	return 0;
>  }

[Severity: Medium]
Should gpio_regmap_direction_output() check and return the error code from
gpio_regmap_set()?

gpio_regmap_set() returns a negative errno when gpio->reg_mask_xlate() or
the underlying regmap write fails.  Ignoring it lets the non-quirk path
switch the pin to output while driving a stale hardware value, and lets
the GPIO_REGMAP_QUIRK_SET_AFTER_DIR path return 0 after switching the
direction even though setting the output level failed.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-cv75-gpio-v15-0-e3c563673fe1@ambarella.com?part=2

  reply	other threads:[~2026-11-18  7:57 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:42 [PATCH v15 00/14] gpio: add Ambarella CV75 PL061 support Long Zhao via B4 Relay
2026-11-18  7:42 ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 01/14] dt-bindings: gpio: pl061: add Ambarella CV75 variant Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 02/14] gpio: regmap: add GPIO_REGMAP_QUIRK_SET_AFTER_DIR Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:57   ` sashiko-bot [this message]
2026-11-18  7:42 ` [PATCH v15 03/14] gpio: regmap: remove gpiochip before tearing down irqchip Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 04/14] gpio: pl061: drop redundant pending check in the IRQ handler Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 05/14] gpio: pl061: convert register access to regmap Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 06/14] gpio: pl061: use IRQ_TYPE_LEVEL_MASK and IRQ_TYPE_EDGE_BOTH Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 07/14] gpio: pl061: use cleanup helpers for locks Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 08/14] gpio: pl061: keep the parent device in a local Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 09/14] gpiolib: request ACPI GPIO events for external IRQ domains Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 10/14] gpio: pl061: switch data path to gpio-regmap Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  8:35   ` sashiko-bot
2026-11-18  7:42 ` [PATCH v15 11/14] gpio: pl061: add Ambarella register-layout variant Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 12/14] gpio: pl061: tidy up IRQ trigger logging Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 13/14] lib/string_choices: add str_rising_falling() Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao
2026-11-18  7:42 ` [PATCH v15 14/14] gpio: pl061: use string_choices helpers for IRQ trigger logging Long Zhao via B4 Relay
2026-11-18  7:42   ` Long Zhao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220388@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=longzhao@ambarella.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.