All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Jacky Huang" <jackyhuang@nvidia.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v3 2/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC
Date: Wed, 18 Nov 2026 08:15:52 +0000	[thread overview]
Message-ID: <sashiko-outbox-220421@kernel.org> (raw)
In-Reply-To: <70ecd17b83b36e0010a7eec28006abe12bf26218.1794985308.git.jackyhuang@nvidia.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] ARM: dts: aspeed: vr-c2-bmc mac2 pinctrl conflicts with gpio0
  mux pins
--

commit 4cbfcccc5efc804fc92f381f0fb03cf463f3ecec
Author: Jacky Huang <jackyhuang@nvidia.com>

ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC

This commit adds the device tree for the ASPEED AST2600 BMC on the NVIDIA
MGX Vera C2 server reference platform.

Link: https://www.nvidia.com/en-us/data-center/products/mgx/
Link: https://www.nvidia.com/en-us/data-center/vera-cpu/

> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts
> new file mode 100644
> index 0000000000000..7239ebe99e418
> --- /dev/null
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-vr-c2-bmc.dts

[ ... ]

> +&gpio0 {
> +	gpio-line-names =
> +		/* A0-A7 */
> +		"", "", "", "", "", "", "", "",
> +
> +		/* B0-B7 */
> +		"", "", "", "", "", "", "", "",
> +
> +		/* C0-C7 */
> +		"SGPIO_I2C_MUX_SEL-O",
> +		"", "", "", "", "", "", "",
> +
> +		/* D0-D7 */
> +		"", "", "",
> +		"UART1_MUX_SEL-O",

[ ... ]

> +/* NCSI MAC */
> +&mac2 {
> +	phy-mode = "rmii";
> +	pinctrl-0 = <&pinctrl_rmii3_default>;
> +	pinctrl-names = "default";
> +	use-ncsi;
> +
> +	status = "okay";
> +};

[Severity: Medium]
Does pinctrl_rmii3_default on mac2 conflict with GPIOC0
(SGPIO_I2C_MUX_SEL-O) and GPIOD3 (UART1_MUX_SEL-O) on gpio0?

In drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c, the RMII3 pin group claims
balls H24 (GPIOC0 / RMII3RCLKO) and E26 (GPIOD3 / RMII3RXER):

drivers/pinctrl/aspeed/pinctrl-aspeed-g6.c:
	GROUP_DECL(RMII3, H24, J22, H22, H23, G23, F23, F26, F25, E26);
	GROUP_DECL(NCSI3, J22, H22, H23, G23, F23, F26, F25, E26);

When mac2 probes, pinctrl_rmii3_default muxes H24 as the 50 MHz RMII3RCLKO
clock output and E26 as RMII3RXER, and because aspeed_g6_pinmux_ops sets
.strict = true, any GPIO request for GPIOC0 or GPIOD3 fails with -EINVAL
in pin_request().  Using pinctrl_ncsi3_default avoids claiming H24, though
E26 remains part of the NCSI3 group unless a pin group without RXER is
used.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1794985308.git.jackyhuang@nvidia.com?part=2

      reply	other threads:[~2026-11-18  8:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  7:56 [PATCH v3 0/2] ARM: dts: aspeed: Add NVIDIA MGX Vera C2 BMC support Jacky Huang
2026-11-18  7:56 ` [PATCH v3 1/2] dt-bindings: arm: aspeed: Add NVIDIA MGX Vera C2 BMC Jacky Huang
2026-11-18  7:56 ` [PATCH v3 2/2] ARM: dts: " Jacky Huang
2026-11-18  8:15   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220421@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jackyhuang@nvidia.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.