From: sashiko-bot@kernel.org
To: pjh456 <147148383@qq.com>
Cc: linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
robh@kernel.org, conor+dt@kernel.org,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply
Date: Wed, 18 Nov 2026 08:29:18 +0000 [thread overview]
Message-ID: <sashiko-outbox-220449@kernel.org> (raw)
In-Reply-To: <tencent_B11DE1495C3C54CE186ED508E2CE5CE41106@qq.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] dt-bindings: rtc: haoyu,hym8563: VDD supply documented as
vcc-supply
--
commit b43da37686bbff8c05e2939d152dd97bed1884f1
Author: pjh456 <147148383@qq.com>
dt-bindings: rtc: haoyu,hym8563: document vcc-supply
This commit adds a vcc-supply property to the Haoyu HYM8563 RTC Device
Tree binding schema to describe its optional VDD supply.
> diff --git a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> index 0b9f39ef0edc3..b27b250d3c2e3 100644
> --- a/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> +++ b/Documentation/devicetree/bindings/rtc/haoyu,hym8563.yaml
> @@ -29,6 +29,9 @@ properties:
> wakeup-source:
> description: Enables wake up of host system on alarm.
>
> + vcc-supply:
> + description: Main power supply (VDD).
> +
[Severity: Medium]
Should this property be named vdd-supply instead of vcc-supply?
Both the description and the HYM8563 datasheet identify the IC supply pin
as VDD, and neither hym8563_probe() in drivers/rtc/rtc-hym8563.c nor any
in-tree haoyu,hym8563 Device Tree node currently uses vcc-supply.
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_B11DE1495C3C54CE186ED508E2CE5CE41106@qq.com?part=1
prev parent reply other threads:[~2026-11-18 8:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 8:05 [PATCH] dt-bindings: rtc: haoyu,hym8563: document vcc-supply pjh456
2026-11-18 8:29 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220449@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=147148383@qq.com \
--cc=alexandre.belloni@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.