All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Madhavan Ganesan" <madhavan.ganesan@oss.qualcomm.com>
Cc: devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575
Date: Wed, 18 Nov 2026 08:31:07 +0000	[thread overview]
Message-ID: <sashiko-outbox-220454@kernel.org> (raw)
In-Reply-To: <20261118-wifi8_qcn9575_bringup-v3-15-9875d2a3953f@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] wifi: ath12k: missing arch_init/arch_deinit in
  ath12k_wifi8_pci_driver
--

commit 86cf6f76e704215111a2398f4b1b921425a02b1b
Author: Madhavan Ganesan <madhavan.ganesan@oss.qualcomm.com>

wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding for QCN9575

This commit adds QCN9575 PCI window constants, a probe callback, and PCI
driver registration scaffolding for Wi-Fi 8 devices.

> diff --git a/drivers/net/wireless/ath/ath12k/wifi8/pci.c b/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> index 3975081d167b8..fd0489f8333f4 100644
> --- a/drivers/net/wireless/ath/ath12k/wifi8/pci.c
> +++ b/drivers/net/wireless/ath/ath12k/wifi8/pci.c

[ ... ]

> +static struct ath12k_pci_driver ath12k_wifi8_pci_driver = {
> +	.name = "ath12k_wifi8_pci",
> +	.id_table = ath12k_wifi8_pci_id_table,
> +	.ops.probe = ath12k_wifi8_pci_probe,
> +	.reg_base = &ath12k_wifi8_reg_base,
> +};
> +
>  int ath12k_wifi8_pci_init(void)
>  {
> -	/* Wi-Fi 8 PCI driver registration will be added in follow-up patches. */
> +	int ret;
> +
> +	ret = ath12k_pci_register_driver(ATH12K_DEVICE_FAMILY_WIFI8,
> +					 &ath12k_wifi8_pci_driver);

[Severity: High]
Does ath12k_pci_register_driver() always fail with -EINVAL here because
ath12k_wifi8_pci_driver leaves ops.arch_init and ops.arch_deinit NULL?

drivers/net/wireless/ath/ath12k/pci.c:ath12k_pci_register_driver() {
    ...
	if (!driver || !driver->ops.probe ||
	    !driver->ops.arch_init || !driver->ops.arch_deinit)
		return -EINVAL;
    ...
}

Even though ath12k_wifi8_pci_id_table is empty, ath12k_wifi8_init() calls
ath12k_wifi8_pci_init() at module load time, so loading ath12k_wifi8 fails
unconditionally with -EINVAL.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-wifi8_qcn9575_bringup-v3-0-9875d2a3953f@oss.qualcomm.com?part=15

      reply	other threads:[~2026-11-18  8:31 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  8:15 [PATCH ath-next v3 00/15] wifi: ath12k: add initial Wi-Fi 8 support for QCN9575 Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 01/15] dt-bindings: net: wireless: add ath12k wifi device QCN9575 Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 02/15] wifi: ath12k: refactor PCI window selection to per-device layout Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 03/15] wifi: ath12k: add extended QMI WLAN cfg for CE and service pipes Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 04/15] wifi: ath12k: add QMI support for extended firmware binary download Madhavan Ganesan
2026-11-18  8:35   ` sashiko-bot
2026-11-18  8:15 ` [PATCH ath-next v3 05/15] wifi: ath12k: add Wi-Fi 8 directory and base module scaffolding Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 06/15] wifi: ath12k: add initial Wi-Fi 8 hw params and init helper for QCN9575 Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 07/15] wifi: ath12k: add Wi-Fi 8 HAL register table and hal init hook " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 08/15] wifi: ath12k: add Wi-Fi 8 HAL ops and descriptor definitions " Madhavan Ganesan
2026-11-18  8:33   ` sashiko-bot
2026-11-18  8:15 ` [PATCH ath-next v3 09/15] wifi: ath12k: add unified firmware image support " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 10/15] wifi: ath12k: add Wi-Fi 8 MHI config " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 11/15] wifi: ath12k: add Wi-Fi 8 CE config and service pipe map " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 12/15] wifi: ath12k: add Wi-Fi 8 WMI init " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 13/15] wifi: ath12k: add Wi-Fi 8 hw ops " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 14/15] wifi: ath12k: add and hook Wi-Fi 8 mac80211 ops skeleton " Madhavan Ganesan
2026-11-18  8:15 ` [PATCH ath-next v3 15/15] wifi: ath12k: add Wi-Fi 8 PCI driver scaffolding " Madhavan Ganesan
2026-11-18  8:31   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220454@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=madhavan.ganesan@oss.qualcomm.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.