All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
Cc: linux-security-module@vger.kernel.org, selinux@vger.kernel.org
Subject: Re: [PATCH v5 5/8] lsm: Add memcg_charge_cgroup LSM hook
Date: Wed, 18 Nov 2026 08:41:02 +0000	[thread overview]
Message-ID: <sashiko-outbox-220471@kernel.org> (raw)
In-Reply-To: <20261117-v2_20230123_tjmercier_google_com-v5-5-1ce975f2a9ad@redhat.com>

> Similar to how security_memcg_charge_task adds an access-control
> point for pidfd for the charge_fd of a DMA_HEAP_IOCTL_ALLOC or
> DMA_BUF_IOCTL_XFER_CHARGE ioctl, we need a new access-control point
> for the case where charge_fd represents a cgroupfd.
> 
> Add security_memcg_charge_cgroup(), called in get_obj_cgroup_from_fd()
> when charge_fd refers to a cgroup2. The hook receives the credentials
> of the requesting process (cred) and the open file of the cgroup
> directory to charge (file), giving security modules a controlled
> enforcement point for cross-cgroup memcg attribution policy.
> 
> The file is passed instead of the cgroup so that a module can
> label-check the object the cgroupfd actually names.
> get_obj_cgroup_from_fd() resolves the memory css from that same file
> with css_tryget_online_from_dir(), so the fd cannot be swapped between
> the check and the charge.
> 
> When CONFIG_SECURITY is not set the hook compiles to an inline
> returning 0, adding no overhead to the fast path.
> 
> Signed-off-by: Albert Esteve <aesteve@redhat.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117-v2_20230123_tjmercier_google_com-v5-0-1ce975f2a9ad@redhat.com?part=5


  reply	other threads:[~2026-11-18  8:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17  8:39 [PATCH v5 0/8] memcg: dma-buf cgroup accounting and charge transfer Albert Esteve
2026-11-17  8:39 ` Albert Esteve via OP-TEE
2026-11-17  8:39 ` [PATCH v5 1/8] memcg: Add MEMCG_DMABUF accounting infrastructure Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:40   ` sashiko-bot
2026-11-17  8:39 ` [PATCH v5 2/8] dma-heap: charge dma-buf memory via explicit memcg Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:40   ` sashiko-bot
2026-11-18  8:40     ` sashiko-bot--- via OP-TEE
2026-11-17  8:39 ` [PATCH v5 3/8] dma-buf: transfer objcg charges via DMA_BUF_IOCTL_XFER_CHARGE Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:41   ` sashiko-bot
2026-11-17  8:39 ` [PATCH v5 4/8] lsm: Add memcg_charge_task LSM hook Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-17 22:54   ` Paul Moore
2026-11-18  8:41   ` sashiko-bot
2026-11-17  8:39 ` [PATCH v5 5/8] lsm: Add memcg_charge_cgroup " Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:41   ` sashiko-bot [this message]
2026-11-17  8:39 ` [PATCH v5 6/8] selinux: Restrict cross-cgroup memcg charging Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:41   ` sashiko-bot
2026-11-17  8:39 ` [PATCH v5 7/8] selinux: Restrict memcg charging to a cgroupfd target Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:41   ` sashiko-bot
2026-11-17  8:39 ` [PATCH v5 8/8] selftests/dmabuf-heaps: Add dma-buf memcg accounting tests Albert Esteve
2026-11-17  8:39   ` Albert Esteve via OP-TEE
2026-11-18  8:41   ` sashiko-bot
2026-11-18  8:41     ` sashiko-bot--- via OP-TEE
2026-11-17 22:54 ` [PATCH v5 0/8] memcg: dma-buf cgroup accounting and charge transfer Paul Moore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220471@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=selinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.