All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Petko Manolov" <petko.manolov@konsulko.com>
Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, robh@kernel.org,
	conor+dt@kernel.org, Frank.Li@kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board
Date: Wed, 18 Nov 2026 09:24:42 +0000	[thread overview]
Message-ID: <sashiko-outbox-220552@kernel.org> (raw)
In-Reply-To: <20261118090914.38082-2-petko.manolov@konsulko.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: arm: fsl: undocumented draeger vendor prefix in
  fsl.yaml
--

commit 8e20d52f09f0bb31e6607b78e6cf44266f04fbf1
Author: Petko Manolov <petko.manolov@konsulko.com>

dt-bindings: arm: fsl: add Draeger M48 dual-cpu board

This commit adds the draeger,imx6q-m48 and draeger,imx6dl-m48 board
compatible strings to the Freescale i.MX6 devicetree bindings.

> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index c8290a83205b6..d0126f54b3877 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -261,6 +261,7 @@ properties:
>                - boundary,imx6q-nitrogen6x
>                - compulab,cm-fx6           # CompuLab CM-FX6
>                - dmo,imx6q-edmqmx6         # Data Modul eDM-QMX6 Board
> +              - draeger,imx6q-m48         # Draeger imx6q variant of M48
>                - ds,imx6q-sbc              # Da Sheng COM-9XX Modules
>                - embest,imx6q-marsboard    # Embest MarS Board i.MX6Dual
>                - emtrion,emcon-mx6         # emCON-MX6D or emCON-MX6Q SoM
> @@ -459,6 +460,7 @@ properties:
>                - boundary,imx6dl-nit6xlite     # Boundary Devices Nitrogen6 Lite
>                - boundary,imx6dl-nitrogen6x    # Boundary Devices Nitrogen6x
>                - bticino,imx6dl-mamoj      # BTicino i.MX6DL Mamoj
> +              - draeger,imx6dl-m48        # Draeger imx6dl variant of M48

[Severity: Low]
As reported by Frank Li on v4 [1], should the draeger vendor prefix also
be documented under patternProperties in
Documentation/devicetree/bindings/vendor-prefixes.yaml?  Without a
"^draeger,.*" entry there, scripts/checkpatch.pl and devicetree schema
validation report draeger as an undocumented vendor prefix.

[1] https://lore.kernel.org/r/aton_teIric7IKX8@SMW015318

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118090914.38082-1-petko.manolov@konsulko.com?part=1

  reply	other threads:[~2026-11-18  9:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:09 [PATCH v4 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-11-18  9:09 ` [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-11-18  9:24   ` sashiko-bot [this message]
2026-11-18  9:09 ` [PATCH v4 2/2] arm: dts: nxp: imx: Add devicetree files for M48 Petko Manolov
2026-11-18  9:24   ` sashiko-bot
  -- strict thread matches above, loose matches on Subject: below --
2026-10-22 14:02 [PATCH v4 0/2] arm: dts: nxp: imx: add Draeger M48 CPU board Petko Manolov
2026-10-22 14:02 ` [PATCH v4 1/2] dt-bindings: arm: fsl: add Draeger M48 dual-cpu board Petko Manolov
2026-10-22 14:10   ` sashiko-bot
2026-10-22 15:13     ` Frank Li
2026-10-22 16:40       ` Petko Manolov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220552@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=Frank.Li@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=petko.manolov@konsulko.com \
    --cc=robh@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.