All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Prajwal N" <prajwal.n@oss.qualcomm.com>
Cc: linux-watchdog@vger.kernel.org
Subject: Re: [RFC PATCH v3 1/2] RISC-V: Add defines for the RISC-V SBI watchdog extension
Date: Wed, 18 Nov 2026 09:28:16 +0000	[thread overview]
Message-ID: <sashiko-outbox-220559@kernel.org> (raw)
In-Reply-To: <20261118092147.2017658-2-prajwal.n@oss.qualcomm.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] riscv: sbi: inconsistent WDT vs WATCHDOG naming in asm/sbi.h
--

commit 2382be713df4d02db88ea32a1b310d27210f00eb
Author: Prajwal N <prajwal.n@oss.qualcomm.com>

RISC-V: Add defines for the RISC-V SBI watchdog extension

This commit adds the extension ID, function IDs, and attribute IDs for the
RISC-V SBI watchdog extension.

> diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h
> index fd6266a7b3395..f2b0b0c9f6b13 100644
> --- a/arch/riscv/include/asm/sbi.h
> +++ b/arch/riscv/include/asm/sbi.h
> @@ -40,6 +40,7 @@ enum sbi_ext_id {
>  	SBI_EXT_FWFT = 0x46574654,
>  	SBI_EXT_MPXY = 0x4D505859,
>  	SBI_EXT_DBTR = 0x44425452,
> +	SBI_EXT_WDT = 0x574454,
>  
>  	/* Experimentals extensions must lie within this range */
>  	SBI_EXT_EXPERIMENTAL_START = 0x08000000,
> @@ -536,6 +537,31 @@ union sbi_dbtr_shmem_entry {
>  	struct sbi_dbtr_id_msg id;
>  };
>  
> +/* SBI watchdog function IDs */
> +enum sbi_ext_wdt_fid {
> +	SBI_EXT_WATCHDOG_READ_ATTRIBUTE = 0,
> +	SBI_EXT_WATCHDOG_WRITE_ATTRIBUTE,
> +	SBI_EXT_WATCHDOG_WRITE_NOTIF_MSI_MESSAGE,
> +	SBI_EXT_WATCHDOG_START,
> +	SBI_EXT_WATCHDOG_STOP,
> +	SBI_EXT_WATCHDOG_PAT,
> +};
> +
> +/* SBI watchdog attributes */
> +enum sbi_ext_wdt_attribute_id {
> +	SBI_WATCHDOG_CAPABILITY			= 0x00000000,
> +	SBI_WATCHDOG_STATE			= 0x00000001,
> +	SBI_WATCHDOG_MIN_PERIOD			= 0x00000002,
> +	SBI_WATCHDOG_PERIOD			= 0x00000003,
> +	SBI_WATCHDOG_TIME_LEFT			= 0x00000004,
> +	SBI_WATCHDOG_NOTIF_TIME			= 0x00000005,
> +	SBI_WATCHDOG_NOTIF_MSI_ADDR_LOW		= 0x00000006,
> +	SBI_WATCHDOG_NOTIF_MSI_ADDR_HIGH	= 0x00000007,
> +	SBI_WATCHDOG_NOTIF_MSI_DATA		= 0x00000008,
> +	SBI_WATCHDOG_ATTR_MAX			= 0x00000009,
> +	SBI_WATCHDOG_ATTR_RESERVED_MAX		= 0xFFFFFFFF
> +};

[Severity: Low]
This isn't a bug, but the extension ID (SBI_EXT_WDT) and enum types
(sbi_ext_wdt_fid and sbi_ext_wdt_attribute_id) use WDT while the
enumerators inside those enums use WATCHDOG (SBI_EXT_WATCHDOG_* and
SBI_WATCHDOG_*).  Other extensions in this header use the same acronym
across the extension ID, enum types, and enumerators; should these
enumerators use SBI_EXT_WDT_* and SBI_WDT_* for consistency?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118092147.2017658-1-prajwal.n@oss.qualcomm.com?part=1

  reply	other threads:[~2026-11-18  9:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18  9:21 [RFC PATCH v3 0/2] Add RISC-V SBI watchdog driver Prajwal N
2026-11-18  9:21 ` Prajwal N
2026-11-18  9:21 ` [RFC PATCH v3 1/2] RISC-V: Add defines for the RISC-V SBI watchdog extension Prajwal N
2026-11-18  9:21   ` Prajwal N
2026-11-18  9:28   ` sashiko-bot [this message]
2026-11-18  9:21 ` [RFC PATCH v3 2/2] drivers/watchdog: Add RISC-V SBI watchdog driver Prajwal N
2026-11-18  9:21   ` Prajwal N
2026-11-18  9:51   ` sashiko-bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220559@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=prajwal.n@oss.qualcomm.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.