All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: amit <amittibi123@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/panel: Replace deprecated DCS display-on calls
Date: Wed, 18 Nov 2026 10:01:28 +0000	[thread overview]
Message-ID: <sashiko-outbox-220650@kernel.org> (raw)
In-Reply-To: <20261118094800.54292-1-amittibi123@gmail.com>

Thank you for your contribution! Sashiko AI review found 3 potential
issues to consider:
- [High] drm/panel: missing Signed-off-by trailer in commit message
- [Medium] drm/panel: boe_panel_unprepare() skips sleep mode on
  display-off error
- [Low] drm/panel: incomplete mipi_dsi_multi_context conversion and
  duplicate logs
--

commit 7771574db163ac443f13d706bebea54afbd4c7d9
Author: amit <amittibi123@gmail.com>

> drm/panel: Replace deprecated DCS display-on calls
>
> Replace deprecated mipi_dsi_dcs_set_display_on() calls with their multi-context equivalents across DRM panel drivers.
>
> Use the MIPI DSI multi-context API to handle errors returned by the new helpers.

[Severity: High]
This commit is missing a Signed-off-by trailer.  In addition, the commit
message only mentions replacing mipi_dsi_dcs_set_display_on(), while the
diff also converts mipi_dsi_dcs_write_buffer(),
mipi_dsi_dcs_set_display_off(), mipi_dsi_dcs_enter_sleep_mode(),
mipi_dsi_dcs_exit_sleep_mode(), mipi_dsi_dcs_set_column_address(),
mipi_dsi_dcs_set_page_address(), mipi_dsi_dcs_set_pixel_format() and
mipi_dsi_dcs_set_tear_on() in panel-boe-himax8279d.c, panel-dsi-cm.c and
panel-feixin-k101-im2ba02.c.

> diff --git a/drivers/gpu/drm/panel/panel-boe-himax8279d.c b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> index 4a8560b4b899a..322f6801e52bd 100644
> --- a/drivers/gpu/drm/panel/panel-boe-himax8279d.c
> +++ b/drivers/gpu/drm/panel/panel-boe-himax8279d.c
[ ... ]
> @@ -95,15 +99,17 @@ static int boe_panel_disable(struct drm_panel *panel)
>  static int boe_panel_unprepare(struct drm_panel *panel)
>  {
>  	struct panel_info *pinfo = to_panel_info(panel);
> -	int err;
> +	struct mipi_dsi_multi_context dsi_ctx = {
> +		.dsi = pinfo->link,
> +	};
>  
> -	err = mipi_dsi_dcs_set_display_off(pinfo->link);
> -	if (err < 0)
> -		dev_err(panel->dev, "failed to set display off: %d\n", err);
> +	mipi_dsi_dcs_set_display_off_multi(&dsi_ctx);
> +	if (dsi_ctx.accum_err < 0)
> +		dev_err(panel->dev, "failed to set display off: %d\n", dsi_ctx.accum_err);
>  
> -	err = mipi_dsi_dcs_enter_sleep_mode(pinfo->link);
> -	if (err < 0)
> -		dev_err(panel->dev, "failed to enter sleep mode: %d\n", err);
> +	mipi_dsi_dcs_enter_sleep_mode_multi(&dsi_ctx);
> +	if (dsi_ctx.accum_err < 0)
> +		dev_err(panel->dev, "failed to enter sleep mode: %d\n", dsi_ctx.accum_err);

[Severity: Medium]
Does sharing dsi_ctx here skip entering sleep mode when
mipi_dsi_dcs_set_display_off_multi() fails?

Previously, boe_panel_unprepare() still sent the enter-sleep-mode command
even if display-off failed before disable_gpios() cut power.  Because
mipi_dsi_dcs_enter_sleep_mode_multi() returns early when dsi_ctx.accum_err
is non-zero, a display-off error now skips the sleep command and triggers
a false "failed to enter sleep mode" message from the stale accum_err.

>  
>  	/* sleep_mode_delay: 1ms - 2ms */
>  	usleep_range(1000, 2000);
[ ... ]
> @@ -178,7 +191,12 @@ static int boe_panel_enable(struct drm_panel *panel)
>  
>  	usleep_range(120000, 121000);
>  
> -	ret = mipi_dsi_dcs_set_display_on(pinfo->link);
> +	struct mipi_dsi_multi_context dsi_ctx = {
> +		.dsi = pinfo->link,
> +	};
> +
> +	mipi_dsi_dcs_set_display_on_multi(&dsi_ctx);
> +	ret = dsi_ctx.accum_err;
>  	if (ret < 0) {
>  		dev_err(panel->dev, "failed to set display on: %d\n", ret);
>  		return ret;

[Severity: Low]
Could these conversions declare dsi_ctx at the top of each function, drop
the redundant dev_err() calls, and convert the remaining DSI helpers in
the same functions?

The mipi_dsi_dcs_*_multi() helpers already log an error via dev_err() on
failure, so keeping the caller dev_err() blocks here and in the other
touched drivers logs every failure twice.  In addition, declaring dsi_ctx
mid-function after statements to wrap a single call leaves adjacent
deprecated DSI calls in the same functions (such as in
k101_im2ba02_enable(), innolux_panel_prepare(),
khadas_ts050_panel_prepare(), kingdisplay_panel_prepare(),
ltk500hd1829_prepare(), panel_nv3051d_prepare(), nt35510_prepare(),
rad_panel_enable(), rm68200_prepare(), s6e63j0x03_enable() and
sharp_panel_prepare()) unconverted.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118094800.54292-1-amittibi123@gmail.com?part=1

      reply	other threads:[~2026-11-18 10:01 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1794145178-999776-mlmmj-06e01102@vger.kernel.org>
2026-11-18  9:48 ` [PATCH v2] drm/panel: Replace deprecated DCS display-on calls amit
2026-11-18 10:01   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220650@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=amittibi123@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.