From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01AD6606A320 for ; Wed, 18 Nov 2026 10:20:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WneREFMS; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DOkxgQz+ DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Date:References: In-Reply-To:Cc:To:Subject:From:Message-ID:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Unsubscribe-Post:List-Owner; bh=pabn2WgXosaeYv5GveS574iD9Uqdtgr2wRKoj3/EnXs=; b=WneREFMSeEJMqx1f/jUBONw1gh aVOYTN3yi3nRK0TMR//yk3g+qll+OT8SS5Vw+LKFuKHt81aloO7/ovoJ52MsXQ41cN3PtPDhVPNnN VMD5VbLy+1A0rPuwKaM5m9btmjP4W9SFKoyAoNE2aO7SOPxyGrvkRoxuc2n5Pqq2LJQd3xcnnjviZ qRmDBNzRjuNfTlNZA5BbYkr409xX3guslsvrSEvidMBo94QS6P0lQ3nQzEKzfPPSZ2VpmVD74K/ud 77HHnh0ue2J/a2frmt1IhTMEjsnbl7Ve/+ycKFdV1ybR4tiCgwctTRD2SQUYqcXcG5VxrVxAugN13 2X4dFSug==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTclq-00000008XuA-3Rs2; Wed, 18 Nov 2026 10:20:06 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xTclq-00000008XtM-0yQr for linux-amlogic@lists.infradead.org; Wed, 18 Nov 2026 10:20:06 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id BFCEF429FF; Wed, 18 Nov 2026 10:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AF201F000C6; Wed, 18 Nov 2026 10:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794997205; bh=JnsQmCXjRdvCfa7rFtMJClu/GumOzSB9b5qlE0ziBHA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DOkxgQz+JPegfqu3sirjOmlV2+as8VLnUcmyRcgOm4CXt5YEQj4Nc5XoxTL9xGnnv YyStur6uB9erivrqnaW3AqbP3xoTvpvSlUb2HySJBQw37utjj4xnWp6RTHyOjq7ens KW06u74VURVhTn/E1SvTuRYdeylAsNqYAeQggzN54gRIo3Fhs4Nu5+kYwBCI6qFSaZ GCnTU1MTej7z7CA34HOXUXDRCXQ07eZ0TzLTg0rJMZ3+WQWlbxAjDaR6IP+P3usCaX BsF/dSfDj1i+Iu9QjidxMdjXHgBlrDlxsvmQ6O3bAEKYunF7+ZlirI/TpcEZGDnopF 5YKQeKfOTNy/g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261118-a9-i2c-v12-2-fc83c53121e6@amlogic.com> References: <20261118-a9-i2c-v12-0-fc83c53121e6@amlogic.com> <20261118-a9-i2c-v12-2-fc83c53121e6@amlogic.com> Date: Wed, 18 Nov 2026 10:20:04 +0000 X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev X-Archived-By: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-amlogic" X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 VGhhbmsgeW91IGZvciB5b3VyIGNvbnRyaWJ1dGlvbiEgU2FzaGlrbyBBSSByZXZpZXcgZm91bmQg MiBwb3RlbnRpYWwKaXNzdWVzIHRvIGNvbnNpZGVyOgotIFtNZWRpdW1dIGkyYzogYW1sb2dpYy1h OTogdHJhbnNmZXIgc3RhcnRlZCBiZWZvcmUgSVJRIHNldHVwIGluCiAgYW1sX2kyY19kb19zdGFy dCgpCi0gW01lZGl1bV0gaTJjOiBhbWxvZ2ljLWE5OiBzdGFsZSBpcnFfc3RhdGUgYW5kIGVkZ2Ug SVJRIG1pc3MgaW4KICBhbWxfaTJjX2lycSgpCi0tCgpjb21taXQgY2U2ZTA1NjkyYzE2ZmQ1MGU1 ZjM0ZGYzOGVhZjQyMjA5ODEzMTEwZQpBdXRob3I6IEp1bnlpIFpoYW8gPGp1bnlpLnpoYW9AYW1s b2dpYy5jb20+CgppMmM6IGFtbG9naWM6IEFkZCBBbWxvZ2ljIEE5IEkyQyBjb250cm9sbGVyIGRy aXZlcgoKVGhpcyBjb21taXQgYWRkcyB0aGUgSTJDIGNvbnRyb2xsZXIgZHJpdmVyIGZvciBBbWxv Z2ljIEE5IFNvQ3MgYWxvbmcgd2l0aCBpdHMKS2NvbmZpZywgTWFrZWZpbGUsIGFuZCBNQUlOVEFJ TkVSUyBlbnRyaWVzLgoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pMmMvYnVzc2VzL2kyYy1hbWxv Z2ljLWE5LmMgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFtbG9naWMtYTkuYwo+IG5ldyBmaWxl IG1vZGUgMTAwNjQ0Cj4gaW5kZXggMDAwMDAwMDAwMDAwMC4uZDI1YmQ1MGU3OGY2ZAo+IC0tLSAv ZGV2L251bGwKPiArKysgYi9kcml2ZXJzL2kyYy9idXNzZXMvaTJjLWFtbG9naWMtYTkuYwpbIC4u LiBdCj4gK3N0YXRpYyBpcnFyZXR1cm5fdCBhbWxfaTJjX2lycShpbnQgaXJxbm8sIHZvaWQgKmRl dl9pZCkKPiArewo+ICsJc3RydWN0IGFtbF9pMmMgKmkyYyA9IGRldl9pZDsKPiArCXU4ICpidWYg PSBOVUxMOwo+ICsJdTMyIHJkX2xlbiwgaTsKPiArCXUzMiByZF92YWw7Cj4gKwl1MzIgaXJxX3N0 YXRlOwo+ICsKPiArCWd1YXJkKHNwaW5sb2NrKSgmaTJjLT5sb2NrKTsKPiArCWlycV9zdGF0ZSA9 IHJlYWRsKGkyYy0+cmVncyArIFJFR19DRkdfSVJRX1NUQVRFKTsKPiArCWlmIChpMmMtPnN0YXRl ID09IEE5X1NUQVRFX0lETEUpIHsKPiArCQlkZXZfd2FybihpMmMtPmRldiwgImkyYyBpcnEgdHJp Z2dlcmVkIGFibm9ybWFsbHksIGlycV9zdGF0ZToweCV4LGlycV9lbjoweCV4XG4iLAo+ICsJCQkg aXJxX3N0YXRlLCByZWFkbChpMmMtPnJlZ3MgKyBSRUdfQ0ZHX0lSUV9FTkFCTEUpKTsKPiArCQln b3RvIGlycV90cmFuc19vdXQ7Cj4gKwl9Cj4gKwo+ICsJaWYgKGlycV9zdGF0ZSAmIEE5X1RSQU5T X0VSUk9SKSB7Cj4gKwkJaTJjLT5lcnJvciA9IC1FTlhJTzsKPiArCQlnb3RvIGNvbXBsZXRlX2ly cV9vdXQ7Cj4gKwl9Cj4gKwo+ICsJc3dpdGNoIChpMmMtPnN0YXRlKSB7Cj4gKwljYXNlIEE5X1NU QVRFX1JFQUQ6Cj4gKwkJYnVmID0gaTJjLT5tc2ctPmJ1ZjsKPiArCQlyZF9sZW4gPSBtaW4oaTJj LT5tc2ctPmxlbiAtIGkyYy0+cG9zLCBBOV9JMkNfRklGT19ERVBUSCk7Cj4gKwkJZm9yIChpID0g MDsgaSA8IHJkX2xlbjsgaSsrKSB7Cj4gKwkJCXJkX3ZhbCA9IHJlYWRsKGkyYy0+cmVncyArIFJF R19DRkdfUlgpOwo+ICsJCQlidWZbaTJjLT5wb3MrK10gPSByZF92YWwgJiBUWF9SWF9EQVRBOwo+ ICsJCX0KPiArCQkvKiBSeCBtdXN0IGNsZWFyIHRocmVzaCBhZnRlciByZWFkIGZpZm8gKi8KPiAr CQljbGVhcl9pcnFfc3RhdHVzKGkyYywgQTlfUlhfVEhSRVNIX1JFQUQpOwo+ICsJCWJyZWFrOwo+ ICsJY2FzZSBBOV9TVEFURV9XUklURToKPiArCQlhbWxfaTJjX3ByZXBhcmVfeGZlcihpMmMsIEE5 X0ZJRk9fRklMTF9IQUxGKTsKPiArCQlpZiAoaTJjLT5wb3MgPT0gaTJjLT5tc2ctPmxlbikKPiAr CQkJYW1sX2kyY19zZXRfbWFzayhpMmMsIFJFR19DRkdfSVJRX0VOQUJMRSwgQTlfVFhfVEhSRVNI X1dSSVRFLCAwKTsKPiArCQkvKiBUeCBtdXN0IGNsZWFyIHRocmVzaCBhZnRlciB3cml0ZSBmaWZv ICovCj4gKwkJY2xlYXJfaXJxX3N0YXR1cyhpMmMsIEE5X1RYX1RIUkVTSF9XUklURSk7Cj4gKwkJ YnJlYWs7Cj4gKwlkZWZhdWx0Ogo+ICsJCWJyZWFrOwo+ICsJfQo+ICsKPiArCWlmICghKGlycV9z dGF0ZSAmIEE5X1RSQU5TX0RPTkUpIHx8Cj4gKwkgICAgKGkyYy0+c3RhdGUgPT0gQTlfU1RBVEVf UkVBRCAmJiBpMmMtPnBvcyA8IGkyYy0+bXNnLT5sZW4pKQo+ICsJCXJldHVybiBJUlFfSEFORExF RDsKCltTZXZlcml0eTogTWVkaXVtXQpDYW4gYW1sX2kyY19pcnEoKSBtaXNzIEE5X1RSQU5TX0RP TkUgb24gbXVsdGktY2h1bmsgdHJhbnNmZXJzIGFuZCBjYXVzZQp3YWl0X2Zvcl9jb21wbGV0aW9u X3RpbWVvdXQoKSB0byB0aW1lIG91dD8KClRoZSBiaW5kaW5nIHNwZWNpZmllcyBhIHJpc2luZy1l ZGdlIGludGVycnVwdCAoSVJRX1RZUEVfRURHRV9SSVNJTkcpLCB3aGljaApyZXF1aXJlcyAoUkVH X0NGR19JUlFfU1RBVEUgJiBSRUdfQ0ZHX0lSUV9FTkFCTEUpIHRvIGRyb3AgdG8gMCBhbmQgdHJh bnNpdGlvbgpiYWNrIHRvIDEgdG8gbGF0Y2ggYSBuZXcgaW50ZXJydXB0IGluIHRoZSBHSUM6CgpE b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvaTJjL2FtbG9naWMsYTktaTJjLnlhbWw6 CiAgICAuLi4KICAgICAgICBpbnRlcnJ1cHRzID0gPDAgMTY0IDE+OwogICAgLi4uCgpPbiBhIG11 bHRpLWNodW5rIHJlYWQgd2hvc2UgbGVuZ3RoIGlzIGEgbXVsdGlwbGUgb2YgQTlfSTJDX0ZJRk9f REVQVEggKDMyKSwKc3VjaCBhcyA2NCBieXRlcywgQTlfUlhfVEhSRVNIX1JFQUQgcmVtYWlucyBl bmFibGVkIGZvciB0aGUgZmluYWwgMzItYnl0ZQpjaHVuayBhbmQgZmlyZXMgYXMgc29vbiBhcyB0 aGUgMzJuZCBieXRlIGVudGVycyB0aGUgUlggRklGTywgYmVmb3JlIHRoZSBmaW5hbApOQUNLIGFu ZCBTVE9QIGZpbmlzaCBvbiB0aGUgYnVzOgoKQ1BVMCAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIEkyQyBIVwphbWxfaTJjX2lycSgpCiAgaXJxX3N0YXRlID0gcmVhZGwoUkVHX0NGR19JUlFf U1RBVEUpCiAgLyogQTlfUlhfVEhSRVNIX1JFQUQgb25seSAqLwogIHJlYWQgMzIgYnl0ZXMgZnJv bSBSRUdfQ0ZHX1JYCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTVE9QIGZpbmlz aGVzOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkVHX0NGR19JUlFfU1RBVEUg fD0gQTlfUEhZX0RPTkUKICBjbGVhcl9pcnFfc3RhdHVzKEE5X1JYX1RIUkVTSF9SRUFEKQogIC8q IEE5X1BIWV9ET05FIGtlZXBzIElSUSBsaW5lIGhpZ2g7IG5vIG5ldyByaXNpbmcgZWRnZSAqLwog ICEoaXJxX3N0YXRlICYgQTlfVFJBTlNfRE9ORSkKICAgIHJldHVybiBJUlFfSEFORExFRCAgICAg ICAgICAgIDwtLSBjb21wbGV0aW9uIG1pc3NlZCwgaGFuZ3MgNTAwIG1zCgpCZWNhdXNlIGlycV9z dGF0ZSBpcyBub3QgcmUtcmVhZCBhZnRlciBkcmFpbmluZyBvciBmaWxsaW5nIHRoZSBGSUZPLCB0 aGUgc2FtZQptaXNzIGhhcHBlbnMgaWYgQTlfUEhZX0RPTkUgb3IgQTlfTkNLX0VSUk9SIGFzc2Vy dHMgd2hpbGUgQTlfU1RBVEVfV1JJVEUgaXMKZmlsbGluZyBSRUdfQ0ZHX1RYIGJlZm9yZSBjbGVh cl9pcnFfc3RhdHVzKGkyYywgQTlfVFhfVEhSRVNIX1dSSVRFKS4KClNpbWlsYXJseSwgaWYgYm90 aCBBOV9SWF9USFJFU0hfUkVBRCBhbmQgQTlfUEhZX0RPTkUgYXJlIGFscmVhZHkgc2V0IGluCmly cV9zdGF0ZSB3aGVuIG1vcmUgdGhhbiAzMiBieXRlcyByZW1haW4gdG8gYmUgcmVhZCwgYW1sX2ky Y19pcnEoKSByZWFkcyBvbmx5CjMyIGJ5dGVzLCBjbGVhcnMgb25seSBBOV9SWF9USFJFU0hfUkVB RCwgYW5kIHJldHVybnMgZWFybHkgYmVjYXVzZQppMmMtPnBvcyA8IGkyYy0+bXNnLT5sZW4sIGxl YXZpbmcgQTlfUEhZX0RPTkUgY29udGludW91c2x5IGFzc2VydGVkIHdpdGggbm8KZnVydGhlciBy aXNpbmcgZWRnZSB0byByZWFkIHRoZSByZW1haW5pbmcgYnl0ZXMgb3IgY29tcGxldGUgdGhlIHRy YW5zZmVyLgoKPiArCj4gK2NvbXBsZXRlX2lycV9vdXQ6Cj4gKwlpMmMtPnN0YXRlID0gQTlfU1RB VEVfSURMRTsKPiArCXJlc2V0X2ZpZm9fcG9zKGkyYyk7Cj4gKwlhbWxfaTJjX3NldF9tYXNrKGky YywgUkVHX0NGR19JUlFfRU5BQkxFLCBBOV9SWF9USFJFU0hfUkVBRCB8IEE5X1RYX1RIUkVTSF9X UklURSwgMCk7Cj4gKwljb21wbGV0ZSgmaTJjLT5kb25lKTsKPiAraXJxX3RyYW5zX291dDoKPiAr CWNsZWFyX2lycV9zdGF0dXMoaTJjLCBJUlFfQUxMX01BU0spOwo+ICsKPiArCXJldHVybiBJUlFf SEFORExFRDsKPiArfQo+ICsKPiArc3RhdGljIHZvaWQgYW1sX2kyY19kb19zdGFydChzdHJ1Y3Qg YW1sX2kyYyAqaTJjLCBzdHJ1Y3QgaTJjX21zZyAqbXNnKQo+ICt7Cj4gKwl1bnNpZ25lZCBpbnQg cmVnX3ZhbDsKPiArCXVuc2lnbmVkIGludCB0cmFuc19sZW47Cj4gKwo+ICsJdHJhbnNfbGVuID0g bXNnLT5sZW47Cj4gKwlyZWdfdmFsID0gKHVuc2lnbmVkIGludCkoKChtc2ctPmFkZHIgJiAweDdm KSA8PCBTVEFSVF9TQUREUl9TSElGVCkgfAo+ICsJCQkJKChtc2ctPmZsYWdzICYgSTJDX01fUkQp ID8gU1RBUlRfUkVBRCA6IDApIHwKPiArCQkJCSgodHJhbnNfbGVuICYgMHhmZmYpIDw8IFNUQVJU X0xFTl9TSElGVCkgfCBTVEFSVF9TVEFSVCk7Cj4gKwlhbWxfaTJjX3NldF9tYXNrKGkyYywgUkVH X0NGR19TVEFSVCwKPiArCQkJIFNUQVJUX1NUQVJUIHwgU1RBUlRfU0xBVkVfQUREUiB8IFNUQVJU X1JFQUQgfCBTVEFSVF9MRU4sIHJlZ192YWwpOwo+ICsJY2xlYXJfaXJxX3N0YXR1cyhpMmMsIElS UV9BTExfTUFTSyk7Cj4gKwkvKiBlbmFibGUgdGhyZXNoIG1vZGUgKi8KPiArCWlmICh0cmFuc19s ZW4gPiBBOV9JMkNfRklGT19ERVBUSCkgewo+ICsJCXJlZ192YWwgPSAobXNnLT5mbGFncyAmIEky Q19NX1JEKSA/IEE5X1JYX1RIUkVTSF9SRUFEIDogQTlfVFhfVEhSRVNIX1dSSVRFOwo+ICsJCWFt bF9pMmNfc2V0X21hc2soaTJjLCBSRUdfQ0ZHX0lSUV9FTkFCTEUsCj4gKwkJCQkgQTlfUlhfVEhS RVNIX1JFQUQgfCBBOV9UWF9USFJFU0hfV1JJVEUsIHJlZ192YWwpOwo+ICsJfQo+ICt9CgpbU2V2 ZXJpdHk6IE1lZGl1bV0KQ2FuIGNsZWFyX2lycV9zdGF0dXMoaTJjLCBJUlFfQUxMX01BU0spIHdp cGUgb3V0IGludGVycnVwdCBzdGF0dXMgYml0cyBmb3IKdGhlIHRyYW5zZmVyIHRoYXQgd2FzIGp1 c3Qgc3RhcnRlZCBieSB3cml0aW5nIFNUQVJUX1NUQVJUIHRvIFJFR19DRkdfU1RBUlQ/CgpDUFUw ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgSTJDIEhXCmFtbF9pMmNfeGZlcl9tc2coKQog IGFtbF9pMmNfZG9fc3RhcnQoKQogICAgd3JpdGVsKC4uLiwgUkVHX0NGR19TVEFSVCkKICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIGFkZHJlc3MgTkFDSyBvciBmYXN0IHRyYW5zZmVy IGZpbmlzaGVzOgogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgUkVHX0NGR19JUlFf U1RBVEUgfD0gQTlfTkNLX0VSUk9SCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBH SUMgbGF0Y2hlcyByaXNpbmctZWRnZSBJUlEKICAgIGNsZWFyX2lycV9zdGF0dXMoSVJRX0FMTF9N QVNLKQogIHNwaW5fdW5sb2NrX2lycXJlc3RvcmUoKQphbWxfaTJjX2lycSgpCiAgaXJxX3N0YXRl ID0gcmVhZGwoUkVHX0NGR19JUlFfU1RBVEUpIC8qIDAgKi8KICBzd2l0Y2ggKGkyYy0+c3RhdGUp CiAgICAvKiByZWFkcyBlbXB0eSBSWCBGSUZPIG9yIHdyaXRlcyBleHRyYSBUWCBGSUZPIGJ5dGVz ICovCiAgIShpcnFfc3RhdGUgJiBBOV9UUkFOU19ET05FKQogICAgcmV0dXJuIElSUV9IQU5ETEVE ICAgICAgICAgICAgPC0tIG5ldmVyIGNvbXBsZXRlcywgdGltZXMgb3V0CgpJZiB0aGUgQ1BVIGlz IGRlbGF5ZWQgYmV0d2VlbiB3cml0aW5nIFJFR19DRkdfU1RBUlQgYW5kIGNsZWFyaW5nClJFR19D RkdfSVJRX1NUQVRFIChmb3IgZXhhbXBsZSB1bmRlciBDT05GSUdfUFJFRU1QVF9SVCB3aGVyZSBz cGlubG9ja190IGlzCnByZWVtcHRpYmxlLCBvciBvbiBhIHZDUFUpLCBjbGVhcmluZyBJUlFfQUxM X01BU0sgYWZ0ZXIgYXNzZXJ0aW5nIFNUQVJUX1NUQVJUCmRpc2NhcmRzIHRoZSBuZXdseSBhc3Nl cnRlZCBzdGF0dXMgYml0cy4gIFdoZW4gYW1sX2kyY19pcnEoKSBydW5zIGZvciB0aGUKYWxyZWFk eS1sYXRjaGVkIGVkZ2UgaW50ZXJydXB0LCBpdCBzZWVzIGlycV9zdGF0ZSA9PSAwLCBtaXNzZXMg QTlfVFJBTlNfRVJST1IsCnVuY29uZGl0aW9uYWxseSBhY2Nlc3NlcyB0aGUgRklGTyBpbiB0aGUg c3dpdGNoIChpMmMtPnN0YXRlKSBibG9jaywgYW5kCnJldHVybnMgd2l0aG91dCBjb21wbGV0aW5n IGkyYy0+ZG9uZS4KCkNsZWFyaW5nIFJFR19DRkdfSVJRX1NUQVRFIGFuZCBlbmFibGluZyB0aGUg dGhyZXNob2xkIGludGVycnVwdHMgaW4KUkVHX0NGR19JUlFfRU5BQkxFIGJlZm9yZSBhc3NlcnRp bmcgU1RBUlRfU1RBUlQgaW4gUkVHX0NGR19TVEFSVCB3b3VsZCBhdm9pZAp0aGlzIHJhY2UuCgot LSAKU2FzaGlrbyBBSSByZXZpZXcgwrcgaHR0cHM6Ly9zYXNoaWtvLmRldi8jL3BhdGNoc2V0LzIw MjYxMTE4LWE5LWkyYy12MTItMC1mYzgzYzUzMTIxZTZAYW1sb2dpYy5jb20/cGFydD0yCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hbWxvZ2lj IG1haWxpbmcgbGlzdApsaW51eC1hbWxvZ2ljQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xp c3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hbWxvZ2ljCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=100.103.45.18 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794997206; b=uDOC1Xpl3tshd6l2QtCiG2TvaQ3tQ3C8FNUay5MJmb25VUnKc0pkNVoTR+GyWmHkHQs7 V/q1qCNPvo/51af1Dxc8ERZCO/cGhr/WygjD4lTrEsA5a34HGT5l/2QHCKgS9rQH3N96I oJKWuHCtbRPBkoQNkadxpVBCkbRbYRlUBm5GD4eXD4oky9Hn6SJBrE1FRwWodfd/9jzBk RBZVPlt+JDTBmQGP+jj84wHyjhVtkSgIy+obE+tbDWaR6yFdsU8BAiK50IKzglU7+a2U+ iphVDj91n+3QDVs2OaE2iUalVsJSB1bSKmqheEaYBkq49Njet0bMVT9W/tIBUaV1LHQ== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794997206; h=Received:DKIM-Signature:Message-ID:From:Subject:Reply-To:To:Cc: In-Reply-To:References:Content-Type:Content-Transfer-Encoding:Date; bh=JnsQmCXjRdvCfa7rFtMJClu/GumOzSB9b5qlE0ziBHA=; b=OPfepUygW1O3H1UCabNFGwqHhLgF53/0XsnOHdi/9d8+dupbcjed1qaRAprUZ1FVMK72 VCd/cb8orQqcLYKo6QDxoN0ByUU6vjWEGeEkj7kM3jsdqwGMBtb3OvvkoeKGEl5MTB+35 rMPL7Za2DPu91y4RI3tyjOcA/tK+cYA9W1Yiycrrv48rnBEE7ymJy0QycWASKQVKBeil1 dF2gUUCUCJWgmwbQbazaVPK5k/9uWvK+M2c18cAWnusavoeJMr5ni24EN4vExHYawf//A Mm61N3+RIG+3CZF4GhgpiGOb4MwgdMMeA7LPrf+pWiaDgG27uJVmx3t5KLIZbnQghjA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DOkxgQz+; arc=none smtp.remote-ip=100.103.45.18 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7AFBE606A31C for ; Wed, 18 Nov 2026 10:20:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=DOkxgQz+ Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5AF201F000C6; Wed, 18 Nov 2026 10:20:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1794997205; bh=JnsQmCXjRdvCfa7rFtMJClu/GumOzSB9b5qlE0ziBHA=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=DOkxgQz+JPegfqu3sirjOmlV2+as8VLnUcmyRcgOm4CXt5YEQj4Nc5XoxTL9xGnnv YyStur6uB9erivrqnaW3AqbP3xoTvpvSlUb2HySJBQw37utjj4xnWp6RTHyOjq7ens KW06u74VURVhTn/E1SvTuRYdeylAsNqYAeQggzN54gRIo3Fhs4Nu5+kYwBCI6qFSaZ GCnTU1MTej7z7CA34HOXUXDRCXQ07eZ0TzLTg0rJMZ3+WQWlbxAjDaR6IP+P3usCaX BsF/dSfDj1i+Iu9QjidxMdjXHgBlrDlxsvmQ6O3bAEKYunF7+ZlirI/TpcEZGDnopF 5YKQeKfOTNy/g== Message-ID: From: sashiko-bot@kernel.org Subject: Re: [PATCH v12 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Reply-To: sashiko-reviews@lists.linux.dev To: "Xianwei Zhao" Cc: linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, robh@kernel.org, conor+dt@kernel.org, neil.armstrong@linaro.org In-Reply-To: <20261118-a9-i2c-v12-2-fc83c53121e6@amlogic.com> References: <20261118-a9-i2c-v12-0-fc83c53121e6@amlogic.com> <20261118-a9-i2c-v12-2-fc83c53121e6@amlogic.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Wed, 18 Nov 2026 10:20:04 +0000 X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list Thank you for your contribution! Sashiko AI review found 2 potential issues to consider: - [Medium] i2c: amlogic-a9: transfer started before IRQ setup in aml_i2c_do_start() - [Medium] i2c: amlogic-a9: stale irq_state and edge IRQ miss in aml_i2c_irq() -- commit ce6e05692c16fd50e5f34df38eaf42209813110e Author: Junyi Zhao i2c: amlogic: Add Amlogic A9 I2C controller driver This commit adds the I2C controller driver for Amlogic A9 SoCs along with i= ts Kconfig, Makefile, and MAINTAINERS entries. > diff --git a/drivers/i2c/busses/i2c-amlogic-a9.c b/drivers/i2c/busses/i2c= -amlogic-a9.c > new file mode 100644 > index 0000000000000..d25bd50e78f6d > --- /dev/null > +++ b/drivers/i2c/busses/i2c-amlogic-a9.c [ ... ] > +static irqreturn_t aml_i2c_irq(int irqno, void *dev_id) > +{ > + struct aml_i2c *i2c =3D dev_id; > + u8 *buf =3D NULL; > + u32 rd_len, i; > + u32 rd_val; > + u32 irq_state; > + > + guard(spinlock)(&i2c->lock); > + irq_state =3D readl(i2c->regs + REG_CFG_IRQ_STATE); > + if (i2c->state =3D=3D A9_STATE_IDLE) { > + dev_warn(i2c->dev, "i2c irq triggered abnormally, irq_state:0x%x,irq_e= n:0x%x\n", > + irq_state, readl(i2c->regs + REG_CFG_IRQ_ENABLE)); > + goto irq_trans_out; > + } > + > + if (irq_state & A9_TRANS_ERROR) { > + i2c->error =3D -ENXIO; > + goto complete_irq_out; > + } > + > + switch (i2c->state) { > + case A9_STATE_READ: > + buf =3D i2c->msg->buf; > + rd_len =3D min(i2c->msg->len - i2c->pos, A9_I2C_FIFO_DEPTH); > + for (i =3D 0; i < rd_len; i++) { > + rd_val =3D readl(i2c->regs + REG_CFG_RX); > + buf[i2c->pos++] =3D rd_val & TX_RX_DATA; > + } > + /* Rx must clear thresh after read fifo */ > + clear_irq_status(i2c, A9_RX_THRESH_READ); > + break; > + case A9_STATE_WRITE: > + aml_i2c_prepare_xfer(i2c, A9_FIFO_FILL_HALF); > + if (i2c->pos =3D=3D i2c->msg->len) > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_TX_THRESH_WRITE, 0); > + /* Tx must clear thresh after write fifo */ > + clear_irq_status(i2c, A9_TX_THRESH_WRITE); > + break; > + default: > + break; > + } > + > + if (!(irq_state & A9_TRANS_DONE) || > + (i2c->state =3D=3D A9_STATE_READ && i2c->pos < i2c->msg->len)) > + return IRQ_HANDLED; [Severity: Medium] Can aml_i2c_irq() miss A9_TRANS_DONE on multi-chunk transfers and cause wait_for_completion_timeout() to time out? The binding specifies a rising-edge interrupt (IRQ_TYPE_EDGE_RISING), which requires (REG_CFG_IRQ_STATE & REG_CFG_IRQ_ENABLE) to drop to 0 and transiti= on back to 1 to latch a new interrupt in the GIC: Documentation/devicetree/bindings/i2c/amlogic,a9-i2c.yaml: ... interrupts =3D <0 164 1>; ... On a multi-chunk read whose length is a multiple of A9_I2C_FIFO_DEPTH (32), such as 64 bytes, A9_RX_THRESH_READ remains enabled for the final 32-byte chunk and fires as soon as the 32nd byte enters the RX FIFO, before the fin= al NACK and STOP finish on the bus: CPU0 I2C HW aml_i2c_irq() irq_state =3D readl(REG_CFG_IRQ_STATE) /* A9_RX_THRESH_READ only */ read 32 bytes from REG_CFG_RX STOP finishes: REG_CFG_IRQ_STATE |=3D A9_PHY_DONE clear_irq_status(A9_RX_THRESH_READ) /* A9_PHY_DONE keeps IRQ line high; no new rising edge */ !(irq_state & A9_TRANS_DONE) return IRQ_HANDLED <-- completion missed, hangs 500 ms Because irq_state is not re-read after draining or filling the FIFO, the sa= me miss happens if A9_PHY_DONE or A9_NCK_ERROR asserts while A9_STATE_WRITE is filling REG_CFG_TX before clear_irq_status(i2c, A9_TX_THRESH_WRITE). Similarly, if both A9_RX_THRESH_READ and A9_PHY_DONE are already set in irq_state when more than 32 bytes remain to be read, aml_i2c_irq() reads on= ly 32 bytes, clears only A9_RX_THRESH_READ, and returns early because i2c->pos < i2c->msg->len, leaving A9_PHY_DONE continuously asserted with no further rising edge to read the remaining bytes or complete the transfer. > + > +complete_irq_out: > + i2c->state =3D A9_STATE_IDLE; > + reset_fifo_pos(i2c); > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, A9_RX_THRESH_READ | A9_TX_THR= ESH_WRITE, 0); > + complete(&i2c->done); > +irq_trans_out: > + clear_irq_status(i2c, IRQ_ALL_MASK); > + > + return IRQ_HANDLED; > +} > + > +static void aml_i2c_do_start(struct aml_i2c *i2c, struct i2c_msg *msg) > +{ > + unsigned int reg_val; > + unsigned int trans_len; > + > + trans_len =3D msg->len; > + reg_val =3D (unsigned int)(((msg->addr & 0x7f) << START_SADDR_SHIFT) | > + ((msg->flags & I2C_M_RD) ? START_READ : 0) | > + ((trans_len & 0xfff) << START_LEN_SHIFT) | START_START); > + aml_i2c_set_mask(i2c, REG_CFG_START, > + START_START | START_SLAVE_ADDR | START_READ | START_LEN, reg_val); > + clear_irq_status(i2c, IRQ_ALL_MASK); > + /* enable thresh mode */ > + if (trans_len > A9_I2C_FIFO_DEPTH) { > + reg_val =3D (msg->flags & I2C_M_RD) ? A9_RX_THRESH_READ : A9_TX_THRESH= _WRITE; > + aml_i2c_set_mask(i2c, REG_CFG_IRQ_ENABLE, > + A9_RX_THRESH_READ | A9_TX_THRESH_WRITE, reg_val); > + } > +} [Severity: Medium] Can clear_irq_status(i2c, IRQ_ALL_MASK) wipe out interrupt status bits for the transfer that was just started by writing START_START to REG_CFG_START? CPU0 I2C HW aml_i2c_xfer_msg() aml_i2c_do_start() writel(..., REG_CFG_START) address NACK or fast transfer finishes: REG_CFG_IRQ_STATE |=3D A9_NCK_ERROR GIC latches rising-edge IRQ clear_irq_status(IRQ_ALL_MASK) spin_unlock_irqrestore() aml_i2c_irq() irq_state =3D readl(REG_CFG_IRQ_STATE) /* 0 */ switch (i2c->state) /* reads empty RX FIFO or writes extra TX FIFO bytes */ !(irq_state & A9_TRANS_DONE) return IRQ_HANDLED <-- never completes, times out If the CPU is delayed between writing REG_CFG_START and clearing REG_CFG_IRQ_STATE (for example under CONFIG_PREEMPT_RT where spinlock_t is preemptible, or on a vCPU), clearing IRQ_ALL_MASK after asserting START_STA= RT discards the newly asserted status bits. When aml_i2c_irq() runs for the already-latched edge interrupt, it sees irq_state =3D=3D 0, misses A9_TRANS= _ERROR, unconditionally accesses the FIFO in the switch (i2c->state) block, and returns without completing i2c->done. Clearing REG_CFG_IRQ_STATE and enabling the threshold interrupts in REG_CFG_IRQ_ENABLE before asserting START_START in REG_CFG_START would avoid this race. --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20261118-a9-i2c-v12= -0-fc83c53121e6@amlogic.com?part=3D2