All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Kory Maincent" <kory.maincent@bootlin.com>
Cc: dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 8/8] drm: Move DSC capability reading helper out of i915
Date: Wed, 18 Nov 2026 10:45:54 +0000	[thread overview]
Message-ID: <sashiko-outbox-220741@kernel.org> (raw)
In-Reply-To: <20261118-feat_move_i915_helper-v1-8-652177f3107a@bootlin.com>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] drm/dp: kernel-doc function name mismatch for
  drm_dp_dsc_read_dpcd()
--

commit 383d83dc14220cf2fa31928b2396a83fa5b46bff
Author: Kory Maincent <kory.maincent@bootlin.com>

drm: Move DSC capability reading helper out of i915

This commit moves the DSC DPCD capability reading helper from the i915
driver into the generic DRM DisplayPort helpers as drm_dp_dsc_read_dpcd().

> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index fc3d4db1c7639..06bf7a6ec8934 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -5144,3 +5144,33 @@ int drm_dp_read_edp_sink_rates(struct drm_dp_aux *aux, u8 edp_dpcd_rev,
>  	return num_sink_rates;
>  }
>  EXPORT_SYMBOL_GPL(drm_dp_read_edp_sink_rates);
> +
> +/**
> + * drm_dp_read_dsc_dpcd() - read the DSC capabilities from the DPCD
> + * @aux: DisplayPort AUX channel
> + * @dsc_dpcd: Buffer to store the DSC capabilities read from the DPCD
> + *
> + * Attempts to read the sink DSC capabilities from the DPCD of @aux.
> + *
> + * Returns: 0 on success or a negative error code on failure.
> + */
> +int drm_dp_dsc_read_dpcd(struct drm_dp_aux *aux,
> +			 u8 dsc_dpcd[DP_DSC_RECEIVER_CAP_SIZE])

[Severity: Low]
Should the kernel-doc header name drm_dp_dsc_read_dpcd() instead of
drm_dp_read_dsc_dpcd() to match the function definition and avoid a W=1 /
htmldocs kernel-doc warning?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118-feat_move_i915_helper-v1-0-652177f3107a@bootlin.com?part=8

      reply	other threads:[~2026-11-18 10:46 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 10:36 [PATCH 0/8] Move DRM helpers out of i915 driver Kory Maincent
2026-11-18 10:36 ` [PATCH 1/8] drm/dp: Move max DPRX link rate helper out of i915 Kory Maincent
2026-11-18 10:36 ` [PATCH 2/8] drm/dp: Move DPRX 128b/132b link rates " Kory Maincent
2026-11-18 10:36 ` [PATCH 3/8] drm/dp: Move DPRX 128b/132b support " Kory Maincent
2026-11-18 10:36 ` [PATCH 4/8] drm/dp: Move supported 128b/132b link rates " Kory Maincent
2026-11-18 10:36 ` [PATCH 5/8] drm/dp: Move DP sink link rates reading " Kory Maincent
2026-11-18 10:36 ` [PATCH 6/8] drm/dp: Make the DPRX link rates helpers static Kory Maincent
2026-11-18 10:36 ` [PATCH 7/8] drm/dp: Move eDP sink link rates reading helper out of i915 Kory Maincent
2026-11-18 10:53   ` sashiko-bot
2026-11-18 10:36 ` [PATCH 8/8] drm: Move DSC capability " Kory Maincent
2026-11-18 10:45   ` sashiko-bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220741@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=kory.maincent@bootlin.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.