From: sashiko-bot@kernel.org
To: "Sai Krishna Potthuri" <sai.krishna.potthuri@amd.com>
Cc: linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2] pinctrl: zynqmp: Ensure function names are NUL terminated
Date: Wed, 18 Nov 2026 11:25:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-220822@kernel.org> (raw)
In-Reply-To: <20261118111816.2483052-1-sai.krishna.potthuri@amd.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] pinctrl: zynqmp: missing Fixes trailer for NUL termination fix
--
commit 9edfc24329d75f5063aa1d16738b9cc9a5a2b745
Author: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
> pinctrl: zynqmp: Ensure function names are NUL terminated
>
> PM_QID_PINCTRL_GET_FUNCTION_NAME returns the function name in a fixed
> 16-byte field and does not guarantee NUL termination. A 16-character
> name fills the entire field.
> The driver copies this field into a 16-byte buffer and subsequently
> uses it as a C string. For a non-NUL-terminated name, string operations
> can read past the end of the buffer into the adjacent groups pointer.
>
> Reserve an extra byte for the NUL terminator and explicitly terminate
> the copied function name.
>
> Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
[Severity: Low]
Since this fixes an out-of-bounds string read when a 16-character function
name is returned without a NUL terminator, should it include a Fixes: tag?
Fixes: 8b242ca700f8 ("pinctrl: Add Xilinx ZynqMP pinctrl driver support")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261118111816.2483052-1-sai.krishna.potthuri@amd.com?part=1
prev parent reply other threads:[~2026-11-18 11:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 11:18 [PATCH v2] pinctrl: zynqmp: Ensure function names are NUL terminated Sai Krishna Potthuri
2026-11-18 11:25 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-220822@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=sai.krishna.potthuri@amd.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.