All of lore.kernel.org
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: "Stian Halseth" <stian@itx.no>, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/2] sparc64: Stop the hwcap-list parser at an unterminated entry
Date: Wed, 18 Nov 2026 12:07:37 +0000	[thread overview]
Message-ID: <sashiko-outbox-220876@kernel.org> (raw)
In-Reply-To: <20261118115537.160675-2-stian@itx.no>

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] sparc64: missing Fixes trailer for mdesc_cpu_hwcap_list() bug
  fix
--

commit d3a59092fe2c64c80fb8dba94ba6f29bf1d288f4
Author: Stian Halseth <stian@itx.no>

> sparc64: Stop the hwcap-list parser at an unterminated entry
>
> mdesc_cpu_hwcap_list() walks the hwcap-list strings with strlen() and
> strcmp(). If the last entry has no NUL within the property, both read
> past its end. len then goes negative, and while (len) does not stop.
>
> Measure each entry with strnlen() first, and stop at one that does not
> fit, as of_property_read_string_helper() does.
>
> Signed-off-by: Stian Halseth <stian@itx.no>

[Severity: Low]
This fixes a bug in mdesc_cpu_hwcap_list().  Should this include:

  Fixes: ac85fe8b2124 ("sparc: Sanitize cpu feature detection and reporting.")

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261118115537.160675-1-stian@itx.no?part=1

  reply	other threads:[~2026-11-18 12:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 11:55 [PATCH v2 0/2] sparc64: Read qemu,hwcap-list on sun4u Stian Halseth
2026-11-18 11:55 ` [PATCH v2 1/2] sparc64: Stop the hwcap-list parser at an unterminated entry Stian Halseth
2026-11-18 12:07   ` sashiko-bot [this message]
2026-11-18 12:53     ` Stian Halseth
2026-11-18 11:55 ` [PATCH v2 2/2] sparc64: Read qemu,hwcap-list from the OF cpu node on sun4u Stian Halseth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-220876@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    --cc=sparclinux@vger.kernel.org \
    --cc=stian@itx.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.