From: sashiko-bot@kernel.org
To: "Nicolás Antinori" <nico.antinori.7@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
robh@kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH v7 2/2] drm/ch1115: add support for Chipwealth CH1115 OLED controller
Date: Wed, 18 Nov 2026 14:10:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-221161@kernel.org> (raw)
In-Reply-To: <39277a7a51b0bc59e0aa6ec570e86076b6b64b4e.1795008752.git.nico.antinori.7@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/ch1115: out-of-range display offset 64 sent in
ch1115_oled_init()
--
commit 267a026ef99b05c8104e1fd889562214c3da0086
Author: Nicolás Antinori <nico.antinori.7@gmail.com>
drm/ch1115: add support for Chipwealth CH1115 OLED controller
This commit adds a DRM driver for Chipwealth CH1115 monochrome dot matrix
OLED panels connected over I2C, along with its Kconfig, Makefile, and
MAINTAINERS entries.
> diff --git a/drivers/gpu/drm/tiny/ch1115-i2c.c b/drivers/gpu/drm/tiny/ch1115-i2c.c
> new file mode 100644
> index 0000000000000..22d99da3e5019
> --- /dev/null
> +++ b/drivers/gpu/drm/tiny/ch1115-i2c.c
[ ... ]
> +static int ch1115_oled_init(struct ch1115_device *ch1115)
> +{
> + u8 commands[] = {
> + CH1115_CMD_OFF,
> +
> + CH1115_CMD_CLOCK_DIVIDE_RATIO,
> + CH1115_VAL_CLOCK_DIVIDE_RATIO(CH1115_VAL_CLOCK_OSC_FREQ,
> + CH1115_VAL_CLOCK_DIV_RATIO),
> +
> + CH1115_CMD_MUX_RATIO,
> + ch1115->height - 1,
> +
> + CH1115_CMD_OFFSET,
> + ch1115->flip_vertical
> + ? ch1115->y_start_offset
> + : CH1115_MAX_HEIGHT - ch1115->y_start_offset,
[Severity: Medium]
Does CH1115_CMD_OFFSET send an out-of-range value of 64 (0x40) when
flip_vertical is false and y_start_offset is 0?
ch1115_parse_dt() defaults y_start_offset to 0 when "chipwealth,offset" is
omitted and restricts explicit values to [0, CH1115_MAX_HEIGHT - 1] (0 to
63) to fit the controller's 6-bit vertical offset field. With the default
offset of 0 and flip_vertical disabled, CH1115_MAX_HEIGHT -
ch1115->y_start_offset evaluates to 64 instead of wrapping modulo
CH1115_MAX_HEIGHT to 0.
--
Sashiko AI review · https://sashiko.dev/#/patchset/cover.1795008752.git.nico.antinori.7@gmail.com?part=2
prev parent reply other threads:[~2026-11-18 14:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 13:48 [PATCH v7 0/2] Add support for CH1115 Controller Nicolás Antinori
2026-11-18 13:48 ` [PATCH v7 1/2] dt-bindings: display: add Chipwealth CH1115 OLED Controller Nicolás Antinori
2026-11-18 13:48 ` [PATCH v7 2/2] drm/ch1115: add support for Chipwealth CH1115 OLED controller Nicolás Antinori
2026-11-18 14:10 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-221161@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=nico.antinori.7@gmail.com \
--cc=robh@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.